From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4E1FA0C46; Tue, 14 Sep 2021 10:39:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C1A39410DC; Tue, 14 Sep 2021 10:39:23 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id AFF254068F for ; Tue, 14 Sep 2021 10:39:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631608762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XHCcqLM4svoFrcASdt0pPMmIDPy2zRFMw7W/dO9EdXc=; b=ccgAoDLC2Awue+k7xPqJSmpiZTnAfdDEBLsxFco6MlglIekSqkJuN6w30OkqUN0wH8KzZK n10W1kRbPrwe0wgtj17IXCtUfMkfDKwVhnipnKp3yVTmJFGHXn5HuPx40oI0MukQJYv2Tz CPJlBwz4ZcvMEp8LK+JHGZ+XStXpfc0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-578-BzsE2CKzPvmaNP_8e3lHkw-1; Tue, 14 Sep 2021 04:39:21 -0400 X-MC-Unique: BzsE2CKzPvmaNP_8e3lHkw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0DE231800D41; Tue, 14 Sep 2021 08:39:20 +0000 (UTC) Received: from [10.39.208.12] (unknown [10.39.208.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EF40919739; Tue, 14 Sep 2021 08:39:15 +0000 (UTC) To: David Marchand , dev@dpdk.org Cc: stable@dpdk.org, Chenbo Xia , Jianfeng Tan References: <20210830151313.25481-1-david.marchand@redhat.com> <20210831155411.17672-1-david.marchand@redhat.com> <20210831155411.17672-3-david.marchand@redhat.com> From: Maxime Coquelin Message-ID: <5cf210a0-5ef2-b5ca-9a22-8fd850120219@redhat.com> Date: Tue, 14 Sep 2021 10:39:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210831155411.17672-3-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/virtio: fix virtio-user Rx interrupts with multi queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/31/21 5:54 PM, David Marchand wrote: > The callfds[] array stores eventfds sequentially for Rx and Tx vq. > > Fixes: 3d4fb6fd2505 ("net/virtio-user: support Rx interrupt") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > --- > drivers/net/virtio/virtio_user/virtio_user_dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c > index 16c58710d7..89f8b2271f 100644 > --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c > +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c > @@ -416,7 +416,7 @@ virtio_user_fill_intr_handle(struct virtio_user_dev *dev) > } > > for (i = 0; i < dev->max_queue_pairs; ++i) > - eth_dev->intr_handle->efds[i] = dev->callfds[i]; > + eth_dev->intr_handle->efds[i] = dev->callfds[2 * i]; > eth_dev->intr_handle->nb_efd = dev->max_queue_pairs; > eth_dev->intr_handle->max_intr = dev->max_queue_pairs + 1; > eth_dev->intr_handle->type = RTE_INTR_HANDLE_VDEV; > Reviewed-by: Maxime Coquelin Thanks, Maxime