From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E11DCA0A03; Mon, 18 Jan 2021 12:54:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 165E7140E6B; Mon, 18 Jan 2021 12:54:26 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 79ACC140E52 for ; Mon, 18 Jan 2021 12:54:23 +0100 (CET) IronPort-SDR: qDfzTbvD15OyeGffN3DaHz6CjmxpxbEMyFLzvK+Kc96z8WIbX2vuNLD4Z6Sf2G7Dj17kDMXs0n AKNA6gOO8CIA== X-IronPort-AV: E=McAfee;i="6000,8403,9867"; a="157973264" X-IronPort-AV: E=Sophos;i="5.79,356,1602572400"; d="scan'208";a="157973264" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2021 03:54:21 -0800 IronPort-SDR: teRofq2i1RG/lNunsBRnL68KWM2yhbuPxSxxKZCY4I3FVooqnqT5zoGyap6w3nNs2GDfmaRyqn 90k5b3q5cYhg== X-IronPort-AV: E=Sophos;i="5.79,356,1602572400"; d="scan'208";a="383543042" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.241.24]) ([10.213.241.24]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2021 03:54:20 -0800 To: Steve Yang , dev@dpdk.org References: <20210114094537.13661-1-stevex.yang@intel.com> <20210118070428.36998-1-stevex.yang@intel.com> From: Ferruh Yigit Message-ID: <5d243f04-dd87-b15c-cf23-df5b94094c0d@intel.com> Date: Mon, 18 Jan 2021 11:54:15 +0000 MIME-Version: 1.0 In-Reply-To: <20210118070428.36998-1-stevex.yang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 00/22] fix rx packets dropped issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/18/2021 7:04 AM, Steve Yang wrote: > The jumbo frame used the 'RTE_ETHER_MAX_LEN' as boundary condition, this > fix will change the boundary condition with 'RTE_ETHER_MTU' and overhead. > > When the MTU(1500) set, the frame type of rx packet will be different > if used different overhead, it will cause the consistency issue, and the > normal packet will be dropped. Hence, using fixed value 'RTE_ETHER_MTU' > can avoid this issue. > > Like, > app -> max_rx_pkt_len = 1500/*mtu*/ + 22/*overhead*/ = 1522 > ethdev -> 1522 > 1518/*MAX*/; max_rx_pkt_len = 1518 > driver -> MTU = 1518 - 22 = 1496 > Packets with size 1497-1500 are dropped although intention is to be able > to send/receive them. > > Following scopes will be changed: > - 'rte_ethdev' > - 'app', e.g.: 'test-pmd'; > - net PMDs which support VLAN tag(s) within overhead, e.g.: i40e; > > Following scopes perhaps will be impacted: > - the cases of jumbo frame related; > - the logic of 'max_rx_pkt_len' and 'mtu' related; > - the using place of 'RTE_ETHER_MAX_LEN'; > > --- > v4: > - moved mtu assignment to the same if-true-block of jumbo frame; > v3: > - removed redundant if-conditions in rte_ethdev and testpmd; > - adjusted the alignment style; > - added offload check before updating mtu; > v2: > - defined the 'RTE_ETHER_MTU + overhead' to 'driver_ETH_MAX_LEN'; > - changed the 'mtu > RTE_ETHER_MTU' to 'frame_size > driver_ETH_MAX_LEN'; > --- > > Steve Yang (22): > ethdev: fix MTU size exceeds max rx packet length > app/testpmd: fix max rx packet length for VLAN packets > net/dpaa: fix the jumbo frame flag condition for mtu set > net/dpaa2: fix the jumbo frame flag condition for mtu set > net/e1000: fix the jumbo frame flag condition for mtu set > net/hns3: fix the jumbo frame flag condition for mtu set > net/i40e: fix the jumbo frame flag condition > net/iavf: fix the jumbo frame flag condition > net/ice: fix the jumbo frame flag condition > net/ipn3ke: fix the jumbo frame flag condition for mtu set > net/octeontx: fix the jumbo frame flag condition for mtu set > net/octeontx2: fix the jumbo frame flag condition for mtu > net/qede: fix the jumbo frame flag condition for mtu set > net/sfc: fix the jumbo frame flag condition for mtu set > net/thunderx: fix the jumbo frame flag condition for mtu set > net/ixgbe: fix the jumbo frame flag condition > net/cxgbe: fix the jumbo frame flag condition > net/axgbe: fix the jumbo frame flag condition for mtu set > net/enetc: fix the jumbo frame flag condition for mtu set > net/hinic: fix the jumbo frame flag condition for mtu set > net/nfp: fix the jumbo frame flag condition for mtu set > net/liquidio: fix the jumbo frame flag condition for mtu set For series, Reviewed-by: Ferruh Yigit Series applied to dpdk-next-net/main, thanks.