From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22AB0A0561; Mon, 20 Apr 2020 07:05:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F00D31C293; Mon, 20 Apr 2020 07:05:27 +0200 (CEST) Received: from mx03.napatech.com (mx03.napatech.com [185.150.198.123]) by dpdk.org (Postfix) with ESMTP id A4D841C226; Mon, 20 Apr 2020 07:05:26 +0200 (CEST) Received: from mx03.napatech.com (localhost [127.0.0.1]) by mx03.napatech.com (Postfix) with ESMTP id 4A841B05B6; Mon, 20 Apr 2020 07:05:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=napatech.com; s=mar2017; t=1587359124; bh=jtOXwmG22DClXrLxiMAg4YBqywKkoVWhyA0dEm9tdKA=; h=From:To:CC:Subject:Date:References:In-Reply-To; b=lwG34HNsyfCnd/shoSPNBXtC4e4RUSaVZCTndompLagyXs/pEgmrvDb7Cn/cecApi 0hUHEfBTjkBJ/YTzrBYie2FvcRuwzXb2SLX3Z1wdKpivIwSVODeRUlNf0iGHukOLG5 u3rSGkqqKHovJO6F42yO0hGqVMWsqRvDuGndrM+aUutkzr6nGwQzBKS6HLkkIrbuAf bh9h96vofO4FpXWug2zQdZESe7+DPOXjowj3fumJDPbgCcIwGPD3ML9FskHVyIdzhE CK6t8jHm33jJ7PjSPusBb//H+P0IAH3GcigpczJvg02vqgZkQp1VWZjbue0Xx3/DFc qFnZsxDS5Qc6g== Received: from localhost (localhost [127.0.0.1]) by mx03.napatech.com (Postfix) with ESMTP id 46C6DB05B4; Mon, 20 Apr 2020 07:05:24 +0200 (CEST) X-Virus-Scanned: by SpamTitan at napatech.com Received: from mx03.napatech.com (localhost [127.0.0.1]) by mx03.napatech.com (Postfix) with ESMTP id B77D7B05BB; Mon, 20 Apr 2020 07:05:21 +0200 (CEST) Authentication-Results: mx03.napatech.com; none Received: from mail.napatech.com (cph-gen-exch02.napatech.com [10.240.1.84]) by mx03.napatech.com (Postfix) with ESMTPS id 33C23B05B6; Mon, 20 Apr 2020 07:05:19 +0200 (CEST) Received: from cph-gen-exch02.napatech.com (10.240.1.84) by cph-gen-exch02.napatech.com (10.240.1.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1913.5; Mon, 20 Apr 2020 07:05:17 +0200 Received: from cph-gen-exch02.napatech.com ([fe80::581:51a1:ac3f:84e]) by cph-gen-exch02.napatech.com ([fe80::581:51a1:ac3f:84e%12]) with mapi id 15.01.1913.005; Mon, 20 Apr 2020 07:05:17 +0200 From: Michael Lilja To: Neil Horman CC: Thomas Monjalon , Finn Christensen , "dev@dpdk.org" , Bent Kuhre , "techboard@dpdk.org" Thread-Topic: [dpdk-dev] Napatech pmd Thread-Index: AQHWB1gAjoqbSs4S00yV0CaMaRpMEahi/NeAgAAC3wCAGZc6gIAAPGVQgAQcBICAAKJ+EA== Date: Mon, 20 Apr 2020 05:05:17 +0000 Message-ID: <5d2a6aff385e47a39a412a738882b7ca@napatech.com> References: <11835288.hYdu0Ggh8K@xps> <20200331195655.GC3858830@hmswarspite.think-freely.org> <4836428.jY9Djz4Zq0@xps> <20200417025457.h4uqif7qtjfb2x2q@penguin.lxd> <20200419211625.gndkmvhiw5kmjflo@penguin.lxd> In-Reply-To: <20200419211625.gndkmvhiw5kmjflo@penguin.lxd> Accept-Language: en-US, da-DK, de-DE, de-CH, en-GB Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [188.177.108.27] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] Napatech pmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Neil Horman > Sent: 19. april 2020 23:16 > To: Michael Lilja > Cc: Thomas Monjalon ; Finn Christensen > ; dev@dpdk.org; Bent Kuhre ; > techboard@dpdk.org > Subject: Re: [dpdk-dev] Napatech pmd >=20 > On Fri, Apr 17, 2020 at 04:38:42AM +0000, Michael Lilja wrote: > > > -----Original Message----- > > > From: Neil Horman > > > Sent: 17. april 2020 04:55 > > > To: Thomas Monjalon > > > Cc: Finn Christensen ; dev@dpdk.org; Bent Kuhre > > > ; Michael Lilja ; > > > techboard@dpdk.org > > > Subject: Re: [dpdk-dev] Napatech pmd > > > > > > On Tue, Mar 31, 2020 at 10:07:12PM +0200, Thomas Monjalon wrote: > > > > 31/03/2020 21:56, Neil Horman: > > > > > On Tue, Mar 31, 2020 at 02:29:08PM +0200, Thomas Monjalon > wrote: > > > > > > 31/03/2020 14:17, Neil Horman: > > > > > > > On Tue, Mar 31, 2020 at 01:25:25PM +0200, Thomas Monjalon > > > wrote: > > > > > > > > Hi, > > > > > > > > > > > > > > > > Raising this topic again. > > > > > > > > > > > > > > > > As said in the past, it is better to have this PMD > inside > > > DPDK. > > > > > > > > We discussed some concerns, but I think the consensus > was > > > > > > > > to integrate Napatech PMD anyway. > > > > > > > > > > > > > > > > I am sad that you did not feel welcome enough to follow > up > > > > > > > > with patches during all these years. > > > > > > > > Please would you like to restart the upstreaming > process? > > > > > > > > > > > > > > > Whats changed here? > > > > > > > > > > > > Nothing changed, except years. > > > > > > > > > > > > > I still don't see what the advantage is to accepting this > > > > > > > code > > > in the DPDK tree. > > > > > > > No one will be able to use it without accepting Napatechs > > > > > > > license for their underlying library. As such, the code > > > > > > > can't really be maintained at all by anyone other than > > > > > > > Napatech in > > > the > > > > > > > community, and so may as well just be maintained as an out > > > > > > > of > > > tree driver. > > > > > > > > > > > > You are the only one having this concern. > > > > > I don't think its wise to assume that silence implies > acceptance. > > > > > > > > > > > Nobody from the Technical Board looks to be against the > > > acceptance. > > > > > > > > > > > > The advantage is simple: Napatech customers will be able to > > > > > > run > > > any DPDK version. > > > > > Why is that not possible by having napatech maintain an out- > of- > > > tree > > > > > PMD? Theres no reason that can't be done. > > > > > > > > They are maintaining an out-of-tree PMD: > > > > https://github.com/napatech/dpdk/releases > > > > > > > > I'm just trying to improve the situation, avoiding DPDK forks. > > > > > > > > > > > > > > > Apologies, I completely missed responding to this note > > > > > > I took a look at the PMD above. Its not an open source > > > implementation of their driver, its the same thing they offered 4 > > > years ago, a skeleton pmd that still uses the same closed licensed > library. > > > > > > It was my understanding that they were working on a completely > open > > > sourced PMD that could be generally useful to the community. If > > > that exists, then yes, by all means, lets take a look at it, and > > > consider merging it. That effort deserves consideration. > > > > > > This however, is the same thing we saw last time. Theres no > benefit > > > in including that > > > > > > Neil > > I understand the confusion. The PMD in our github is still, as you > correctly state, based on our closed source driver and only a > skeleton. We are working on a open source version, but currently that > is WIP and not pushed yet. I'll let you know when there is something > to look at. > > >=20 > So, I have to ask. I referenced this email from 2016 earlier in this > thread: > https://mails.dpdk.org/archives/dev/2016-September/046522.html >=20 > Where a colleague of yours from Napatech noted that you were working > on an fully open source driver. Given that you have been working on > this to some degree since then, I would presume that you could share > what code you have thus far. Can you place the code you have written > thus far in a public repository so we can start reviewing it? >=20 > Thanks > Neil Actually the open-source driver development has been on hold until just rec= ently, due to other priorities. We just recently allocated a new team to do= the open source driver, a team of people who has not been working with DPD= K before, so the learning curve is steep for these guys. I will check up on= how far they are and if they are ready to share something.=20 Michael