From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C122A0C47; Wed, 3 Nov 2021 19:24:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 252BF40E0F; Wed, 3 Nov 2021 19:24:40 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 7497C40689 for ; Wed, 3 Nov 2021 19:24:38 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10157"; a="231515965" X-IronPort-AV: E=Sophos;i="5.87,206,1631602800"; d="scan'208";a="231515965" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2021 11:24:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,206,1631602800"; d="scan'208";a="599996862" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga004.jf.intel.com with ESMTP; 03 Nov 2021 11:24:37 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 3 Nov 2021 11:24:37 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 3 Nov 2021 11:24:36 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 3 Nov 2021 11:24:36 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 3 Nov 2021 11:24:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ahGYFWOD/DR2BFYZ83JZ7ZWu38BarLiHywTXVQ6Oo51Ef+s2C5MAvg9v3AN8TNr/fmXXyIzJJiFQcuCRJepgojVLn0Ke3sqnN1D93lmjACFr/+TAidYKhqEGmUWtigM5bNSHHsSfrSlAzaG41sxB/iq6PY6oZtNJ+1e4N0JKkPETiwg9pQOj6XOXH8YTeGQfYjyRhGMwR41OOvDqDPQTZyFARxexR2uWI5wsXM6DzSh2fcjrpGpn89LzJYLuWLmb8Vbojy8LrbqcJbJcJGAOnWdC+a9OHInWA63OgRkQTxweNdG0sNZlWRTcnIp+VvXwM098KS5ICJShGaKmMqVCeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L6NsY3mqDEcbQUURCalP7ze01ybHdtnw8UDoYZ2ooGs=; b=U/vyQTb+bJ/fDSb2EIMNIHNuo7ahffntV74U5wLtf/D8sVzBIUUFXEqiF0zf/ILcZYPD5KI0yz3Kysg9q8k8A0s5ZZmR+Czfdr7uIQzZT0dvrNFhq/mfqytCBIJ8zc9WzNxRzJGYrqmTt7yMZA7IR89DUbefocdbtr1Y59fZnCBDpBSYKQvFlLLHVDHBdiLJY5Gecaq+bgp3AzUm0ROMN7UTES4TL05bWTRNdMMcYa/zR5MxQPrTjm5MW+kwakRN8G4LS+0lMtTQ0gVB/yAq5g9/8TQwuvZvK/CKPG9gHdd7TQhF4so3FXi2boQzkHBISR38suvu7yrtzi2WGaen8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L6NsY3mqDEcbQUURCalP7ze01ybHdtnw8UDoYZ2ooGs=; b=eeT6HOk3BHlgMSk0OL6AITtY/C/XFZjGsE/KcFD5C4YgM/Rw/0azMresyDvl7pM0ZzP/oF0A3yGBh9pQ6nP14ztXRjf+Hrm4TPlUh6LLrJg070EA4B7sDrgO/1jhBLLWRMfL4eNLc9oAyRnfRCTPpBElcWAZdb8kV546cDPcx/0= Authentication-Results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4982.namprd11.prod.outlook.com (2603:10b6:510:37::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Wed, 3 Nov 2021 18:24:35 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%7]) with mapi id 15.20.4669.011; Wed, 3 Nov 2021 18:24:35 +0000 Message-ID: <5d3ff885-d07b-3d55-2cd0-34e28cf7b20f@intel.com> Date: Wed, 3 Nov 2021 18:24:29 +0000 Content-Language: en-US To: Gregory Etelson , , CC: , Raslan Darawsheh References: <20211101091514.3891-1-getelson@nvidia.com> <20211102085347.20568-1-getelson@nvidia.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211102085347.20568-1-getelson@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO3P123CA0017.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:ba::22) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by LO3P123CA0017.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:ba::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10 via Frontend Transport; Wed, 3 Nov 2021 18:24:33 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a1faa038-6e3e-49a0-262c-08d99ef72fff X-MS-TrafficTypeDiagnostic: PH0PR11MB4982: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2201; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: F966p0QXT4qZm+xlZBbmMVL9GGbnLHfvMV7A//BGFxU1LArv8rgjFdJVDFswo46rjGN765Cz50wXvirG2ywAtaL7fjbaPoMEEjuuPZU8w+5GnUtZoWxWJUQ/aNeAj5AGjevkPv2/niUH2X2Gi4XB9aTNIBpYCimcGNTOkFByrV/1Sxb2xTfN5KtrI97RXUUglwy07qVUB3iw5IY/6Xz1eTgccymX7+6yUIbaSpOF9UtYMUz/snCeGcICwlgYr8IPzYg+1QMiuBD6ak/nx8+LyvNOx++D6S00ZV3eldOWYIbv1uxUhKMSTS/gvUiTXZW+j+8SN01gC5mxqZTZRVg86urfaHpYmw1Aho4CO63kU9KDkiaS8m3n564zZioE9rpL83J2jStuK2nJFCew3lt9eVJaZGZmPI7ThKEmU/TOIl/WL0SoVZJqETcU6ojIRGeTA8FXGB9rFtE8CoeWXMWlvoWlht38Svx1MKKgpIxnpCogj5MPbIeX+b45GWAQLkws6bcsLu9CCmM+BKOZxQCR0AdUha4eCdxngtIrT6hkknagUJ7M0gRLt6t9rZHnKZp6Kg62E/K48Rt8TEtGKsJFVkwL87r+sTXkXqxZxjVrn7m4Pu7bQbkqXgAlCfyd1lzsSP4fpYo5WdgVTxvrrW10KIsM3FVe81dqvb656OdW9g2M6m/BLCtv2ve5p0cfk7SK9dCrbgwIDz+TLKRw8+I/Kg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(66476007)(956004)(66556008)(8936002)(508600001)(26005)(66946007)(82960400001)(83380400001)(38100700002)(36756003)(31696002)(186003)(316002)(44832011)(86362001)(6486002)(8676002)(2616005)(16576012)(53546011)(4326008)(2906002)(6666004)(5660300002)(31686004)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eWpOZlBZQzRYOHN5WmVpN0RsdHdGV0Y3MVJFOC9ZWWowRFRJSDY0WlZ3RnpM?= =?utf-8?B?UmZYRGVIVGxaQUYzcXNLQkRoQnRBTEJSTDVIek1DVnRQdUJ5d05lYW41cmNq?= =?utf-8?B?WmNEeUl5VzNYeHk5eWdKMFlGcE50L1NPNUVUZG1wSkt4TUhDMEJBS3p1NGkv?= =?utf-8?B?a25RcDdpTStKSkhGdDJKekxpbDNwYjE4SmdOK0tFZlhlVGlveG56UnRBYVUv?= =?utf-8?B?b2ZaYVFMdnFpMHIzYklRVld1MExsQjV2SEZPV2VSOFJGOTN4NCtJeXV5RXVE?= =?utf-8?B?dmd4V3VBNXhjb2w1VGNUZzY3T0liNnptemVmMi94WHJwelppU0xWZFNwNUgr?= =?utf-8?B?OWVpblhlRmNxYjJTODUrS3l2OTEwbnF0ajZlcXF6WWwycG9lMm0vYndqUE1N?= =?utf-8?B?TFJwTHBVZ0Erd1NWeXF6dDliRHhjOUxOL1lraVA4Y2FPS2c2bzV4aXFTK3Rr?= =?utf-8?B?eU55dVJwcFRRYlVQVlNtZkY5VnppR1JDMUNjY0duUkdqaGVvMnVYY3owYXdz?= =?utf-8?B?SmNQS0xtSStCbUZ0cXNXK1o3T0tuY2t0VmpDTC9lUE9NWklOZmJmcWRjUyth?= =?utf-8?B?L2lTV3FteTFKZGt3cTlvM3pjZThMd203cDVhd25YcE9aekVWaUtGYk50a1Jt?= =?utf-8?B?dVJZd1Y3ZDJVcnNYcEVLcmJTQXp2eWI4VkhVOHVsS3BVSTFneEpLMmtXTmtl?= =?utf-8?B?UHMwcWIxSVVUUUNDRGc2Vjl1eDR3bnVjdXFWNVlSY0tsSkhkck9yMzYvb01U?= =?utf-8?B?QnVHSkhYN3RkNmlxanRGa2dnWVN3REM4ZnNLZXg1WDQ2M3pZVHVuZEVMN0da?= =?utf-8?B?VnQyTEkwVTRBSmk1S29aczlOcWRQN25sRVFPK0NkTXVnZ2J3QldPMU9wdFNR?= =?utf-8?B?MUpKaCtlSVBST0F0VExjZURQUk5oeGg3czJ2Sld1MUVXVU9iZCs5ZklFV1Vu?= =?utf-8?B?Y0NUbEJrNmt1NXdQU2FwQVI1Uy91cUJBSlAvZEZyQ010cEdJbVZpS0ZXMXlS?= =?utf-8?B?RXVzVFEwUmI2YXNocy9SWFFrM1lDQ0Vod2ptVG9zNHpDN2tZaGEyUFVXL3F1?= =?utf-8?B?SllaanFieWNWcVQ3V05VRCs2elFsWXFZQkxFL1VJeUhpUi9rVnJmSGlSenFt?= =?utf-8?B?TkhsR3NDVXVNOEtVVHdvMWJjcTNEZE0vMTZCOVF5WUhiaGxiRE9JV2k5T0Zk?= =?utf-8?B?V0o4dkhtT2hiZFdlcFNIS0xJdHFPakJ4VmZGRlQrOFhyeHo2TFZlUHdKM2pI?= =?utf-8?B?TlhDaklDNFcyWERjYkMwZ3BTK1NEeWZqUGNMS3BPN3Q2blozb2ErNFlrRE9t?= =?utf-8?B?SFc3V0dnVDJoaFYvcnoyc3hXbGZ6ZG01c2JteUk2Mjl3R01LM2JMTTNiZlVi?= =?utf-8?B?dVFyOFE3NHU4bXNRc1p0OGo5clFxUDNYNnVGbTFGNHFUaGdIdHlJR2ViT1Y3?= =?utf-8?B?aGhUMzQ0VmVqQlZ0OWFhSHJqZFZBVEVwRXBHWjd3UG1PZHVJaUJYQlAwR0Q0?= =?utf-8?B?SU1pUCtoZUxSTzFpd1hSRlRlaTNEVEhGSEMrM1pVd3ZtVDhNM3RRaWI0KzVT?= =?utf-8?B?ZzlTSTFXZWhaZnFvYzhpb2JrejVpT1NCSEt5UHhtOFlYV1hhTmsyM2s4ZEh2?= =?utf-8?B?a2ZjM1VnNnRMOC9wbUNzS3RBTFEzUlNRMXN5RmQzdytPbWwvYWFTOVN0SUZz?= =?utf-8?B?WXd0TGFWSlpHK0NucXdtM1d3YnN6aU5qK3Z2TVkwa21UR2QrQ2czUVhHbU52?= =?utf-8?B?N2RyTTlhK0hQdWdBZ0R6SCt3RUZ5Y3J0SGFqQm9ENE9PUVJlelh4eUVxZEo0?= =?utf-8?B?V0tjYWZOK2dQUWZjTVRrNnFRZUVJcDN1Q1JFNGcwRlk5T3VLWmozbTIxNnJR?= =?utf-8?B?NGNwRDVsV1JWMDQ3WVJucmZxUGFmVkdpMVh0RTFJQkJXa1Y4bEVUZEpKQVR1?= =?utf-8?B?SFFWUFY3WlBYSDFwdWV6TkhMd3IyYzRQeXFsTXM3Y1QvbEVxajQxelhpL3hn?= =?utf-8?B?TWZQTi9vMUdPeEFnQitDV0JRY1ZSSVN4eENmZU1SVCtYWkNGVDNiMDdPYVVx?= =?utf-8?B?SWlLLzM4QU9nRmRIRnc3cFB0cmdiTVZlU1V6TjdSSXFwcGJLVVNhNytzL2xS?= =?utf-8?B?eTR0eVcwL0dqVGtLVXcwZ0FCL2NNZzdISEFBUlA1bnowMGZTMm84dkEyaS9q?= =?utf-8?Q?A99u9vmaA2OOQFyxbLYgGgU=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: a1faa038-6e3e-49a0-262c-08d99ef72fff X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2021 18:24:35.1655 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RvyMknmQUbL1/LjD5ec1PZPg0hc0UX6uMsyIQ86J6mTGU6lsKqvVBuynCY08yC+2C9pkJV3bUN1ksYasAWMc+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4982 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 0/9] net/mlx5: add flex item support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/2/2021 8:53 AM, Gregory Etelson wrote: > Gregory Etelson (4): > common/mlx5: extend flex parser capabilities > common/mlx5: fix flex parser DevX creation routine > net/mlx5: add flex parser DevX object management > net/mlx5: handle flex item in flows > > Viacheslav Ovsiienko (5): > common/mlx5: refactor HCA attributes query > net/mlx5: update eCPRI flex parser structures > net/mlx5: add flex item API > net/mlx5: translate flex item configuration > net/mlx5: translate flex item pattern into matcher > Hi Gregory, Can you please check following doc error [1] and build error [2]: [1] $ ./devtools/check-doc-vs-code.sh rte_flow doc out of sync for mlx5 item flex [2] from ../lib/eal/x86/include/rte_rwlock.h:13, from ../lib/eal/include/rte_fbarray.h:40, from ../lib/eal/include/rte_memory.h:25, from ../lib/eal/include/rte_malloc.h:17, from ../drivers/net/mlx5/mlx5_flow_flex.c:4: ../drivers/net/mlx5/mlx5_flow_flex.c: In function ‘mlx5_flex_flow_translate_item’: ../drivers/net/mlx5/mlx5_flow_flex.c:240:37: error: ‘priv’ undeclared (first use in this function) 240 | MLX5_ASSERT(mlx5_flex_index(priv, tp) >= 0); | ^~~~ ../lib/eal/include/rte_branch_prediction.h:38:45: note: in definition of macro ‘unlikely’ 38 | #define unlikely(x) __builtin_expect(!!(x), 0) | ^ ../lib/eal/include/rte_debug.h:47:25: note: in expansion of macro ‘RTE_VERIFY’ 47 | #define RTE_ASSERT(exp) RTE_VERIFY(exp) | ^~~~~~~~~~ ../drivers/common/mlx5/mlx5_common.h:104:26: note: in expansion of macro ‘RTE_ASSERT’ 104 | #define MLX5_ASSERT(exp) RTE_ASSERT(exp) | ^~~~~~~~~~ ../drivers/net/mlx5/mlx5_flow_flex.c:240:9: note: in expansion of macro ‘MLX5_ASSERT’ 240 | MLX5_ASSERT(mlx5_flex_index(priv, tp) >= 0); | ^~~~~~~~~~~ ../drivers/net/mlx5/mlx5_flow_flex.c:240:37: note: each undeclared identifier is reported only once for each function it appears in 240 | MLX5_ASSERT(mlx5_flex_index(priv, tp) >= 0); | ^~~~ ../lib/eal/include/rte_branch_prediction.h:38:45: note: in definition of macro ‘unlikely’ 38 | #define unlikely(x) __builtin_expect(!!(x), 0) | ^ ../lib/eal/include/rte_debug.h:47:25: note: in expansion of macro ‘RTE_VERIFY’ 47 | #define RTE_ASSERT(exp) RTE_VERIFY(exp) | ^~~~~~~~~~ ../drivers/common/mlx5/mlx5_common.h:104:26: note: in expansion of macro ‘RTE_ASSERT’ 104 | #define MLX5_ASSERT(exp) RTE_ASSERT(exp) | ^~~~~~~~~~ ../drivers/net/mlx5/mlx5_flow_flex.c:240:9: note: in expansion of macro ‘MLX5_ASSERT’ 240 | MLX5_ASSERT(mlx5_flex_index(priv, tp) >= 0); | ^~~~~~~~~~~