From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79080A0548; Mon, 26 Apr 2021 14:41:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2F9CE41104; Mon, 26 Apr 2021 14:41:25 +0200 (CEST) Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by mails.dpdk.org (Postfix) with ESMTP id B2A7640140 for ; Mon, 26 Apr 2021 14:41:23 +0200 (CEST) Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4FTPb21S3szBsBt for ; Mon, 26 Apr 2021 20:38:54 +0800 (CST) Received: from [127.0.0.1] (10.40.190.165) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.498.0; Mon, 26 Apr 2021 20:41:12 +0800 To: Ferruh Yigit References: <1619056552-43937-1-git-send-email-humin29@huawei.com> <1619056552-43937-4-git-send-email-humin29@huawei.com> <1e1b9fac-51f7-7420-b67d-260e7865db3c@intel.com> CC: "Min Hu (Connor)" , From: fengchengwen Message-ID: <5d7d0346-67a9-5db2-91f7-2cae0e1c901f@huawei.com> Date: Mon, 26 Apr 2021 20:41:12 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <1e1b9fac-51f7-7420-b67d-260e7865db3c@intel.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.40.190.165] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH 3/4] net/hns3: fix parse link fails code fail X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2021/4/26 20:26, Ferruh Yigit wrote: > On 4/22/2021 2:55 AM, Min Hu (Connor) wrote: >> From: Chengwen Feng >> >> The link fails code should be parsed using the structure >> hns3_mbx_vf_to_pf_cmd, else it will parse fail. >> >> Fixes: 109e4dd1bd7a ("net/hns3: get link state change through mailbox") >> Cc: stable@dpdk.org >> >> Signed-off-by: Chengwen Feng >> Signed-off-by: Min Hu (Connor) >> --- >> drivers/net/hns3/hns3_mbx.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/hns3/hns3_mbx.c b/drivers/net/hns3/hns3_mbx.c >> index ba04ac9..0550c9a 100644 >> --- a/drivers/net/hns3/hns3_mbx.c >> +++ b/drivers/net/hns3/hns3_mbx.c >> @@ -346,12 +346,13 @@ hns3_link_fail_parse(struct hns3_hw *hw, uint8_t link_fail_code) >> } >> >> static void >> -hns3pf_handle_link_change_event(struct hns3_hw *hw, >> - struct hns3_mbx_pf_to_vf_cmd *req) >> +hns3pf_handle_link_change_event(struct hns3_hw *hw, void *data) > > Why not s/struct hns3_mbx_pf_to_vf_cmd/struct hns3_mbx_vf_to_pf_cmd/ but change > to parameter to "void *", wouldn't it reduce the type check? > Only this message needs to be converted using hns3_mbx_vf_to_pf_cmd. All other messages are processed using hns3_mbx_pf_to_vf_cmd. So here we simplifying fix it. Beside we will refactor hns3_mbx module in later version because the PF and VF process logic is mixed. thanks >> { >> #define LINK_STATUS_OFFSET 1 >> #define LINK_FAIL_CODE_OFFSET 2 >> >> + struct hns3_mbx_vf_to_pf_cmd *req = data; >> + >> if (!req->msg[LINK_STATUS_OFFSET]) >> hns3_link_fail_parse(hw, req->msg[LINK_FAIL_CODE_OFFSET]); >> >> > > > . >