From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 882B1A0C45; Thu, 25 Nov 2021 15:28:44 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 155D840DF5; Thu, 25 Nov 2021 15:28:44 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 8113A40140 for ; Thu, 25 Nov 2021 15:28:42 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10178"; a="234253688" X-IronPort-AV: E=Sophos;i="5.87,263,1631602800"; d="scan'208";a="234253688" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Nov 2021 06:28:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,263,1631602800"; d="scan'208";a="457884519" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga006.jf.intel.com with ESMTP; 25 Nov 2021 06:28:40 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 25 Nov 2021 06:28:40 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 25 Nov 2021 06:28:39 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 25 Nov 2021 06:28:39 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 25 Nov 2021 06:28:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bU/a7jFsBAanHMKsHKXMcSXus0jE5A2Qk7nCIXv5Ln8LmRnawV7KAWJfuTVeVI+CwXOqxctsthodNcRznyrFJcbMoK4NU8k0OedWdEXa9BjKm0a1jGRUjHaSPysbje6j2QCwH2JGuOJKlVYAINQ2U1IZ71xKO9HeKXQIONCSN0ScoAeEWNyQE+RuRcbDzVT5RxweCz/qgQY40xmS9/8+4f07D8ZrPECYRghccfv8kmTy6GeaFiJsNrkDKZhLZ6hT1W03hoiyL9Hnyc1ZYNuU8SXBYSiuksa9IA6USGUC0r2CvVrTcAE44Jb0RQBOJlw8KRQ5/C8SU8dMz/qKNIIZTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PsQl2Jni0sxiE0sI1KUA8lywpfFBYsUss6fnPqyPZw8=; b=auwdwSQDH4uFvbhU2mD5+zG12CIYNRoi+2SS58HQKSk/uWdkXFxRhjp9kqsDBWpB+qMkO4iZk7wzSB/VcdAaNE2WGwnKBWRflWaFBEnQHZ7xNIRf+JOHdBYQmZ1CuBhqSd4uCmfsA93uM5b4tqZ11wNlhj4tos+/NsRlC5WG2XqSJNOZFsy2Bp3p31hDDd1glBlqfuiRHA2R8kvr511Cy2H7aqm5zWdHVukiBigCUot2l80IK5jg7EsvCsUSktHAo/f8VXIws084m8DHQyjEZLZ2YqkK9FH93AguFK1Aso72rArxoycj17L3BBKUD1Bn0WL7v7cwRV+RWdgadFfLJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PsQl2Jni0sxiE0sI1KUA8lywpfFBYsUss6fnPqyPZw8=; b=hD/eJoqsEWK80S22E/e2RxCL+V1i6h5DzTg0AQrI7+MFSwBKwMNw8hSzlLV+XGVIihYwqDQHVIICMilPmcLsEtLFZJesOsLeQ9XE1jtdgNFArSWyw9a7Gvn7PjEdbzqzTSPEAf5le35CBNOcDoiIvSmIt/UtjJ4Oifknx7/uvKA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.19; Thu, 25 Nov 2021 14:28:38 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c%5]) with mapi id 15.20.4690.030; Thu, 25 Nov 2021 14:28:38 +0000 Message-ID: <5d7d8083-18c6-f1fc-13f9-fbb024c3cbac@intel.com> Date: Thu, 25 Nov 2021 14:28:31 +0000 Content-Language: en-US To: Ori Kam , Slava Ovsiienko CC: "NBU-Contact-Thomas Monjalon (EXTERNAL)" , "David Marchand" , Andrew Rybchenko , "dev@dpdk.org" , Ray Kinsella References: <20211123075940.5521-1-viacheslavo@nvidia.com> <20211124153756.12198-1-viacheslavo@nvidia.com> <843154cd-4ed4-046e-e01c-3fb154ddad86@intel.com> From: Ferruh Yigit Subject: Re: [PATCH v3] ethdev: deprecate header fields and metadata flow actions X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DBBPR09CA0031.eurprd09.prod.outlook.com (2603:10a6:10:d4::19) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DBBPR09CA0031.eurprd09.prod.outlook.com (2603:10a6:10:d4::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.21 via Frontend Transport; Thu, 25 Nov 2021 14:28:36 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 54387718-3b89-4e3d-5638-08d9b01fded6 X-MS-TrafficTypeDiagnostic: PH0PR11MB5013: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nnJqabUwEHQjPn7hHoD5F74CcRZ4WsGILVRiyCvefp/w8J1L1CSLUGaLULnPwyuz6NRL4RMG3h8Lb/OEaTLAEKTpjRNQJGeI4M1YY2E5ahCdTVwD+x5eXj+eEV92ZC0RNrwkolwsmJCpn35hCVjM6L2ragKTnfv6n9h7KvKqHY7irnoguYZpQqGZmod/t91/xIbjvFh0/k+CsWJPLcvMhJBQhF7eL166bAwEDIoEXENUbUf7e5i4rbIXfMBccAxW5x/tY7uhV23CT8ny80POh7k/PrOaBE7O51s55TrqPTCvGOEmQT9Y5sOta3xcdZ3P2EMusyN3tkDmniPdsF0vevBj9tEbETD9HY/k3XDtWzIq0rUEgWG9w/B9P7+27tS1+2IdRv4ij9sADEwrYmNVXQuWPDWOqXZrt0yFjWsE8Nq43gN63IE0rTm0R4fm6Dfxv63wcag5d/1N6spRVAe4/RwD0pGqsN2ZZSjxYiDmdqRUOx5D5ZeO1L32OuQ5tsiR9BHXlYeVS3rkBEd83wCJ7OhLe+Xc+b1UcybXA2oE3vaCBURO9emVaV4xVP0xVwP/A/4VlCVKCYGGRl0fIYkvkeZv3DUAWa6p6zkSJqODvlsQq+omeWhdf6xQLj6X63MuR2pkGgpxT2nakLEsVkJC6yQC5q/GvynBSvhTri595zL3ksw1bzKfBLsGGkl4DPpa93txgMrqA6vPgC2jd2s2+Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(86362001)(16576012)(5660300002)(82960400001)(26005)(316002)(2906002)(83380400001)(2616005)(66556008)(38100700002)(36756003)(31696002)(6486002)(4326008)(956004)(66946007)(110136005)(53546011)(186003)(508600001)(6666004)(44832011)(31686004)(54906003)(66476007)(8676002)(8936002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bFFISTNDVWEzWGVpWlYvOEZIQmhGQXJURWpLeFQ3c2FWTDFVOGtrREpTNHRu?= =?utf-8?B?M3BTRGJtT0p3VFBYMzJwS3daQnlJSUZZM0JVYmJqZkMyRGhPdFR4cUxOSG1N?= =?utf-8?B?Q2t3RllDTjlzZzhrdXdiYnpwV0dYUDdzRkxLVm5teldJOERWaDNMSDY1dEVv?= =?utf-8?B?R09jRld6aDlqYWY0V09zMkI3ZmJ3Ymlmc29UcUYrZnl4bmR0UFhSMGRUTTMr?= =?utf-8?B?K0J4Znd6V2dMZTNYRVJ1MDJqOE1oaHpCWTZCUCtkQUxwS2V1bnJqU2ZvUU5Z?= =?utf-8?B?SmlWbXY2YjVLN1hsY0hOQ05wWmR0MUE0Y1JESFFYSXpDQ0ZZZEw5cUNDam9a?= =?utf-8?B?bFBGL3NWa1hOZnB6bWJKZlFxcjJkQ1k1QUxjeHZ6bHhBTGNnblEwdUVaTERk?= =?utf-8?B?T1ozbkdLb2QwVWpXbGxzVWFtOFNKcWgzZXhQdVV2QzhzaUdrM0tkcGtLY2NH?= =?utf-8?B?MlZmb1BxQlhoNjR0NkkzNmRvVWQzcTFCS1VyUkRyOXZEYm0xczBNNSs3TkN3?= =?utf-8?B?R1B0SXljbGc3cjdjd1psTU5sMkRZT0UyY0dOVFUxL05Ca1FaZlJXam9uQlhB?= =?utf-8?B?QWYrZ0tXMTUvNWMxbU5adjlZYlNjOHFuTWEvL1IvQkRTSHZnRnpVMytzSXRJ?= =?utf-8?B?aXc1NXRvVHRyWFBKcEp2a2JXM0lmTElUdGdUUm00ZEVzSUhVak5DY1ZoWXB3?= =?utf-8?B?Ymw1MUFtQ0o5aXRPQlN5V1hhRFl0M0c1cTIyUVBYc1ZTWTBBVFM1dEJ5SzZY?= =?utf-8?B?NmpGT0FqakQ3a1d1UktLQ0thKy9TYkdVcEx3REZTRlBwZkNSa0J0UXBDblQ5?= =?utf-8?B?UzE3bmpQb1hmRG5IR1BmWkxCZEJ4ZTNmRnlQWUg2NWdGSklldVQySEN2OUM4?= =?utf-8?B?T2NUOFgrYWVtcWNadGFtOXovSWM1eWxxZFd4bVlUcTJHODdpVFlkMHZkaHVS?= =?utf-8?B?VkJPZlRyWU96QytVQjQvQ1JlSzlpT3hkSEZpSVhQd2dQa0hXU3pwQlhMc2Zy?= =?utf-8?B?ejNaWTdOU0V5clFWbFNDWUMxWXZ4SElQbGdHdTl2MEY0MERUVm5yUWg5Q09x?= =?utf-8?B?R0F4NDFuOXZ5N2QyUHZWcnlha0hyZ1o1M3pIYU5MbVhlb2tycEo0NURzYUpV?= =?utf-8?B?UUtYYm1BUFZVbEh0amFVa1J3UDlXcFVFdWE4bjA2d3c1eHQ2ZTJJYXdlQWNP?= =?utf-8?B?WE1IM2FBenFZbDJNeVVWdWl4RjBqaTBveHZtZ2Y0K01uK2syWkVmRC9jdUNn?= =?utf-8?B?cm9TTDVpVGo4NFVycTdvWU1xNkVXaHdKR1BXL1VSdHhIT1hicWVxdzFTMmxS?= =?utf-8?B?UFpLUHE5RXEySE1mb1VNcFc4NXNnZ3pCOHhYMDlKbDkyNGtQVUV6YU5GZURD?= =?utf-8?B?SllSaTFWS0NLWlpFL2x2L1RCK3QvZE81T3Axalc1Z0k3UEprVldwUmc3OTQ4?= =?utf-8?B?eGJHWE1Bb2NNeC95NU5TelArSDJyaXlibmlUL1VNSE5rVjJGYzFjQkdkMkpa?= =?utf-8?B?MzhseWViQ2pmUGlWakxtWHNNOXV0Y0ZVNUtZaDY2ZVlRSnJOOVc3RTZHZ3d5?= =?utf-8?B?a1FGN2xiZXNKRi82TXdVYXV5amFlOVBUeGdHVU4wVG9iOTU3Z2VjUTVsR1Zh?= =?utf-8?B?OXZpVVkyblpJK25FLzVnelMwUCtyb1N2RW1zMFZ4cnplZEtsVnpBbUxoTE00?= =?utf-8?B?V1ZaWXhZSGdrcThIUWpkbzFHVGRTY09hbmNqc0V2Z3VQYU0raDF1OFpCbGhm?= =?utf-8?B?eCsvQ2pqR1dZdW5NU0hCclBrZzN2L0oyN0VvN0dwcTVwMGgrT0NXb1N1ZmYy?= =?utf-8?B?N2MzL2d3SEdIcmNRUGN3VnNsSGxJaStUdkVoWmZ1MmV1ZzY2a3UwbUQrWm1H?= =?utf-8?B?ZUM3RStxV2NaMERTSy9QWGZqQmRjdExLbjk4MEVReHF6dDBhOWF1WUJrRXBE?= =?utf-8?B?VUVMRUwwbUQ0bVl4Ky9aRVRreXIvRmI4dGZsR2xqM1JWK0hIUzNtZWZGOUxs?= =?utf-8?B?QzFURXBnTFFvS2VtR3cwMHNORDZpeXVPbFppdDdHdmRJSEJZaEVTcjlLZkU1?= =?utf-8?B?N20wSWpZOFVFajkwdWxmV3lwYnJZVjRVTGZlQWhWRHNvcGc5RmNiSGZEaXBq?= =?utf-8?B?Zkw3Ykc5cDFPN1BXNnFhT25YaWFoS3ZYeVhBOE5keHhpQzl1ZHViTWNMd0pN?= =?utf-8?Q?vmAII7o3rgVDQX3ZqzfTRhQ=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 54387718-3b89-4e3d-5638-08d9b01fded6 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2021 14:28:38.1088 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /y0+j6j1z3LQoD5QFnshkyRhBLI78bb80DP6p0eI2Hl+sLgQjg250iXvU0hmhTohr4wd8hP/paiCAJiXNvhqyQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5013 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/25/2021 1:56 PM, Ori Kam wrote: > > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Thursday, November 25, 2021 2:47 PM >> To: Ori Kam ; Slava Ovsiienko >> Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; David Marchand >> ; Andrew Rybchenko ; >> dev@dpdk.org; Ray Kinsella >> Subject: Re: [PATCH v3] ethdev: deprecate header fields and metadata flow actions >> >> On 11/25/2021 12:29 PM, Ori Kam wrote: >>> Hi >>> >>>> -----Original Message----- >>>> From: Ferruh Yigit >>>> Sent: Thursday, November 25, 2021 2:19 PM >>>> Subject: Re: [PATCH v3] ethdev: deprecate header fields and metadata flow actions >>>> >>>> On 11/24/2021 3:37 PM, Viacheslav Ovsiienko wrote: >>>>> @@ -3331,6 +3430,9 @@ struct rte_flow_action_set_tag { >>>>> }; >>>>> >>>>> /** >>>>> + * @deprecated >>>>> + * @see RTE_FLOW_ACTION_TYPE_MODIFY_FIELD >>>>> + * >>>>> * @warning >>>>> * @b EXPERIMENTAL: this structure may change without prior notice >>>>> * >>>>> @@ -3355,6 +3457,9 @@ struct rte_flow_action_set_meta { >>>>> }; >>>>> >>>>> /** >>>>> + * @deprecated >>>>> + * @see RTE_FLOW_ACTION_TYPE_MODIFY_FIELD >>>>> + * >>>>> * RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP >>>>> * RTE_FLOW_ACTION_TYPE_SET_IPV6_DSCP >>>>> * >>>> >>>> Hi Viacheslav, Ori, >>>> >>>> Just recognized that some of the "struct rte_flow_*" added as experimental >>>> (experimental note in the struct comment), some without experimental note. >>>> >>>> Is it because some forgotten the add the experimental note? >>>> >>>> What is the rule to add new "struct rte_flow_*"? >>>> >>> >>> In the beginning struct were never experimental, >>> and in the last few releases we started to put experimental also on structs >>> which I think is much better since at the end this is a new API and just like any other >>> new API it is not stable. >>> >> >> Got it, thanks. >> >> So to record for archives, new "struct rte_flow_*" structs should be >> experimental by default. >> >> Does it applies to enums too? > > Yes, I think that anything new is experimental don't you? > I just want to record some guidelines that we can reference later. So we all can check that new struct & enums are marked as experimental in rte_flow.h after this point.