From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0084.outbound.protection.outlook.com [104.47.41.84]) by dpdk.org (Postfix) with ESMTP id 39B7AA56E for ; Mon, 15 Jan 2018 15:35:23 +0100 (CET) Received: from BN6PR03CA0002.namprd03.prod.outlook.com (10.168.230.140) by DM5PR03MB2699.namprd03.prod.outlook.com (10.168.197.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.407.7; Mon, 15 Jan 2018 14:35:22 +0000 Received: from BN1AFFO11FD033.protection.gbl (2a01:111:f400:7c10::128) by BN6PR03CA0002.outlook.office365.com (2603:10b6:404:23::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.407.7 via Frontend Transport; Mon, 15 Jan 2018 14:35:21 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; caviumnetworks.com; dkim=none (message not signed) header.d=none; caviumnetworks.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11FD033.mail.protection.outlook.com (10.58.52.246) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.345.12 via Frontend Transport; Mon, 15 Jan 2018 14:35:21 +0000 Received: from [10.214.249.235] ([10.214.249.235]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id w0FEZH2i020713; Mon, 15 Jan 2018 07:35:18 -0700 To: Jerin Jacob References: <1513333483-4372-1-git-send-email-hemant.agrawal@nxp.com> <1515996674-26338-1-git-send-email-hemant.agrawal@nxp.com> <1515996674-26338-6-git-send-email-hemant.agrawal@nxp.com> <20180115122944.GA833@jerin> CC: , , From: Hemant Agrawal Message-ID: <5d7e0a4f-7007-fa43-80f7-d84e822d8f18@nxp.com> Date: Mon, 15 Jan 2018 20:05:16 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20180115122944.GA833@jerin> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131605005212887858; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(346002)(396003)(39860400002)(39380400002)(376002)(2980300002)(1110001)(1109001)(339900001)(24454002)(189003)(199004)(13464003)(85426001)(23746002)(8936002)(229853002)(230700001)(5660300001)(81156014)(81166006)(65956001)(65806001)(356003)(47776003)(8676002)(6246003)(65826007)(36756003)(76176011)(86362001)(104016004)(2906002)(2950100002)(97736004)(6916009)(498600001)(305945005)(58126008)(105606002)(59450400001)(106466001)(4326008)(67846002)(31686004)(53546011)(316002)(68736007)(54906003)(53936002)(50466002)(83506002)(93886005)(64126003)(77096006)(31696002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR03MB2699; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD033; 1:iE30HYRvU/H5F61sFke4WG0TGEyxFscyYukp3kMsqP3105aQXp5bGaDIh0Kj0fc0Ly9U0L8BTExrqhZagTrZepbgVc3zqpvX6S2gUR55QnUVq+jPyrG89oZuZFNnSXN/ X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 27cff37c-d414-4ea1-ab32-08d55c2534d7 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(5600026)(4604075)(2017052603307); SRVR:DM5PR03MB2699; X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2699; 3:oMw/jnvaJmG/Hbf/xJ684b9Zlb9D4BW5y3EyjpQJXloj+0R6uGppuwAK+HkKZSean50PnmUrygwuFkwO0F7spJoQZBM8xbWcV+UW1TPsAnylE3grkxf1HvQuIHwMK//jUdBeJVdKsRJ1biHgU0qSqWExj6NrfSCfR78Z03LJ750gszCKNlMoUuuI1XmkG3rhGfxh11b+kPUJGwJNEMmcEZ7W+U4qs6pL/ntAaDHbSztgs66nqhCXCqK0hauhDJy2AT/yGVrJAh+9JdJ6QXp4lnRWuK0uLVkcNHp8L1Aam4StchP4IeT6Yg7TNan5QwmDGYXZfrGpaGI+ifxREwW3nh+PtImR3wNNGeYdirKQ0S4=; 25:lTkVsuZWaHMjsStAMvgae7T8qENQ0h7TCMADE7o/BCZokJ0iX1+GCQ9Wz+SrIimKajWuwtlU74id9XJ+OLE34RSMqXWwWC07wU2bSRdp9KscGc1Oom6aZPu8i1bFdd+RrET1ILkzZL+UhSzIK7h7dzMzGev1a2TWCr0+0R0tQos8uc8Q1MLNrgaavjaMuee4Kaxy/IzC294WY8sv3LOS45FwQuafwGeiI+L5+M/jZHFIWXUWYoehkofmMvWWyGMpsBlkZ/Vz2QOFAnsGR+VxgWDZDbZfs1Vfe2WwKy52d8wmm3oH0jOw17t8D0Yol7wemid73xBPWPz65xC4v941Dg== X-MS-TrafficTypeDiagnostic: DM5PR03MB2699: X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2699; 31:6Q8KJWROdew0y7k1bf6rnmUUqQWDhmgcYmA+Y6TENXoVEGjxZ+yoYKwzdPGJ2MUZm5nR057lgdMHV4is6+CA6yD6B3aagJnD9uIeqemZLYWv3v28Dl0XA+lSSMHKzXxLw6boWLv7bqpffwzKnRPzWW66cLtedy1O24a3Srw1fo04x1QD7j6qEsXYNmxjSNC+tMinz4V5fMXEl/Ve0aDWYlBBWChwKvGy2ijHFQ0MZdM=; 4:mgtrCPwizDdieR1oawLLq0lYKlQLH3/BeoIcJzzpRcS8sp7v9+oGImfnz0KRIfLqS5T31VF5KprPWxNdC4heHpplPlmA9QFrTsk3UZ+anpFNmgc732uk/+TGu06MUmTFjz3NpBUXi+yabgLLmkuJwQA+3T/XkR7i/5mYJT9MnKxEIG5kTuhWmYSbE1ZdhABd+iI61HfKMU1pN1eX8Xwp5bl8o0aynjXRDHg4qmFUvyXuA+5Dt/i/N2+o2b7Gp5e9WCtEP+/MRCA8gJF6XNpTh1ry1R8htBuEklNM13VlhW9ITEGXZU9UFlZ/gZcLVaFg X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(2401047)(5005006)(8121501046)(3002001)(3231023)(944501161)(93006095)(93001095)(10201501046)(6055026)(6096035)(20161123563025)(20161123556025)(201703131430075)(201703131433075)(201703131448075)(201703151042153)(20161123561025)(20161123565025)(20161123559100)(201708071742011); SRVR:DM5PR03MB2699; BCL:0; PCL:0; RULEID:(100000803101)(100110400095)(400006); SRVR:DM5PR03MB2699; X-Forefront-PRVS: 0553CBB77A X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; DM5PR03MB2699; 23:YocS3bldKLyX0tPIz177669NSeWFQSHnzY6Mt?= =?Windows-1252?Q?ipKCOEvg+CEYRLkAoqtvUxalNJOIBHDqAlRbTOzli1gvm/E9dndrrd3e?= =?Windows-1252?Q?e05Cqr35P7fG+W97Uj6LqFYyv2Iu4SOCQFzBXHWeF1/cXD1QylGEqE6a?= =?Windows-1252?Q?WinakKIeXfH18Qqssb9HGTfQ366g/n4nyS1py2Urpj3tYDVwu8T5Vf3t?= =?Windows-1252?Q?dzIDDXXaq2GJNTLCBTQQkGcKVY9DPSnmcXDKAWBEL3oKjgrAnb620B/w?= =?Windows-1252?Q?bWsoIdBPrN7+R3VTeirgq3Il7IDCkS+/WD8jeO/vJEfb+Ay7r51MjDNN?= =?Windows-1252?Q?IcIJcbw/34ooO9HzzauzzMCx6FxhCa8k2ifkaixuU5r0X2pfNQnWXmfl?= =?Windows-1252?Q?NoTEG9YmDp56dGGB5c6/KcPekKrL8OzAmANG7daK+pTSYTAEa3OFSRRj?= =?Windows-1252?Q?h7SRuQ+7r1tXG1KzBPV1Ivdsk8vv1PIqak9nauHwenNrCVnQN7i3G0aP?= =?Windows-1252?Q?W0hE0m9ggShCuCa4g5xWgAXZNVJt82K1s7iMt6EoW+CMYsjCqNsUmJCs?= =?Windows-1252?Q?VD4tWnWgqsCC1ETxQm3wwHRiH7syn7T3sTKQkbWdFXCFSFqGyS1n98zO?= =?Windows-1252?Q?0FsX/7g2oWj6rpP5s7dChCuPfc+lwrLo81cdDjQdEim/HVZdX5LVxwy+?= =?Windows-1252?Q?R92EV9ppP02xF9s6MRAaEVXOt6RPGBPfrytC0KcGXNbP+OIoK6sreC6L?= =?Windows-1252?Q?W2cSUYlMzHYQjtAx6k1JIZUHQ/orvC2l5ITBSFBRUz3XxDLRQq01mFrQ?= =?Windows-1252?Q?rRYIDS6YBqTPnSlyAPFFlEZmEF4NNZ3IJ7Xjsq1Gf/7Mkbp6Zd2F3qHx?= =?Windows-1252?Q?ND2QxWldQLOAy1CLd5ib9IIJIiUT/nR7IaojZ7V62S0bWWq2Y0BSDj0V?= =?Windows-1252?Q?GhJUTQK9ewSqcpqMWGyJ0XYAGUoa3u1Zionuezbj2FfZ+aXgGHge/2Ms?= =?Windows-1252?Q?lXlLUCZ+8dfr+yThuueEPwFQCr5ZfVMf6KdDT7sHpIaahi//9T53aDTX?= =?Windows-1252?Q?2AoebgJ0dpJ85q8oKZTGTNGCECDIO7DngMwr/68Fx7g/pI4xISINjk1m?= =?Windows-1252?Q?FLsgforu3PBl9wLAndzraV3KXjXo7iJIHR+JZSbrBi0iwmTPCqD+uC0f?= =?Windows-1252?Q?2D/gEoELkfWd+X3BzyAp5Ym656vAPx6lmW+sbYhRA20tqOFEXQNQrqrS?= =?Windows-1252?Q?D3tVtyqh4letH1qVfXVDNTptUevKXM6y7uHjYYtw77nqp6YM0rQn+o8L?= =?Windows-1252?Q?8shTE2/iPGxVgWDnXua+n/FNcbbIgUFVPs08kVB2rkIelKjuTCBXAzfM?= =?Windows-1252?Q?qIv4DBBcSBpd3VtpWs+KI4anyrjW9AtX4a9i4Di1IARN/OS1FWXV4o?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2699; 6:UjIwjuWRqRzv0SiucrvVVB49SJzWNZkTL4WwkobOmnl9qyZnBnObJ0P+7aGNllcnPpHk1c8KIWwoKgcYGFG0u18b+izT9FqtX6fGUxW56uMhr301wp6D0vj3nC+pF2aRkivHOqIVNdOQlyRf5E4wYknspUdtW/tOptVSkQwZeCypp/9DKjeelEOcelLp2YV6I8Amu6eMY3ZYXQ13WwJoihiQVWrIbe2oP3XTcnkesw68v+i6df0CkDplpoZhqaSy/0vAnrAHlXJHC2rlyxDQDD9KK8LCC+dwwICnuAakCzNR/4d1L7FjCnGU0RUZR2ghvtNcBL+8kmJiSehlfpe2gBBSXHJBNPx5m3fJ2uQT5AQ=; 5:uVyhWfkpWgHSkDA4W94K/ueJRwkNUBSg/7M/5drqziTLgnyGcezJ8TmDRv75oSsNozPvCAnbTt1f9aUFRljmmaO5yfjNLj94yW7/kEpy2GSu9pZCtbEaGlvMxIsg1OtdOGwSFaXmkkgQkqmq9zDFoVLsOXKiQ4Rfyg3+nBE7ic0=; 24:VrXp5tYvD3y0ICAzmOOOVvixwLNQLNNOs362CRENZtE5JtR81amVW9S+dS9npyFZ8p+mEL8irW1nechGRVjfKIR7sTbFZXolJZZSdRVXRsk=; 7:+1zbPB/7fMT02+ApvDj6Uudjp0mw12VLq0y6CrnngtC8EwdEPgaHSSLP5aKIcSm4v7RdLJuZqKvmM/9Y1ISqq11DX33xvJwvFCD737aQ9SuxpvF+7b5zZiPhQV2F6nAd2mGn69Z1OHXjk93o41O4kyq2ef55B0soVUWztHAyPDerbYvDp0y+ttrVBIRmC/6O7yoeWtXxBcH8B7ohtqvZOixoAC0DBrzy52sXYMyS43Gf1QA8DgYT+mWTB+4BsiJ1 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2018 14:35:21.0859 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 27cff37c-d414-4ea1-ab32-08d55c2534d7 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2699 Subject: Re: [dpdk-dev] [PATCH v2 5/5] mbuf: add user command line config mempools ops API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 14:35:23 -0000 On 1/15/2018 5:59 PM, Jerin Jacob wrote: > -----Original Message----- >> Date: Mon, 15 Jan 2018 11:41:14 +0530 >> From: Hemant Agrawal >> This patch add the user command line configured mempool ops name >> API to librte_mbuf and sends a deprecation notice to remove the >> similar API from eal. >> >> Signed-off-by: Hemant Agrawal >> --- >> doc/guides/rel_notes/deprecation.rst | 7 +++++++ >> lib/librte_mbuf/rte_mbuf.c | 8 +++++++- >> lib/librte_mbuf/rte_mbuf.h | 10 ++++++++++ >> lib/librte_mbuf/rte_mbuf_version.map | 1 + >> 4 files changed, 25 insertions(+), 1 deletion(-) >> >> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst >> index 13e8543..ec8018f 100644 >> --- a/doc/guides/rel_notes/deprecation.rst >> +++ b/doc/guides/rel_notes/deprecation.rst >> @@ -8,6 +8,13 @@ API and ABI deprecation notices are to be posted here. >> Deprecation Notices >> ------------------- >> >> +* eal: a mbuf specific API was part of eal APIs. This is now being >> + moved to librte_mbuf to be with other similar APIs. >> + The following API is target to be deprecated on 18.05. >> + >> + - ``rte_eal_mbuf_default_mempool_ops`` replaced by >> + ``rte_mbuf_user_mempool_ops'' >> + > > I think, deprecation notice need to be in a separate 'doc" patch. Yes. you are right. .. >> +const char * >> +rte_mbuf_user_mempool_ops(void) >> +{ >> + return internal_config.user_mbuf_pool_ops_name; >> +} >> + >> /* Return mbuf pool ops name */ >> static const char * >> rte_mbuf_best_mempool_ops(void) >> { >> /* User defined mempool ops takes the priority */ >> - const char *best_ops = rte_eal_mbuf_default_mempool_ops(); > > I think, we may need to remove the stale rte_eal_mbuf_default_mempool_ops() once > it is replaced. Do you mean that till the API is not deprecated, we shall keep the usage?