From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8C2DA0547; Wed, 29 Sep 2021 18:21:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD9D1410EB; Wed, 29 Sep 2021 18:21:31 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id A46D8410E5 for ; Wed, 29 Sep 2021 18:21:30 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10122"; a="212063672" X-IronPort-AV: E=Sophos;i="5.85,332,1624345200"; d="scan'208";a="212063672" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2021 09:21:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,332,1624345200"; d="scan'208";a="707378032" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga006.fm.intel.com with ESMTP; 29 Sep 2021 09:21:28 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 29 Sep 2021 09:21:28 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 29 Sep 2021 09:21:27 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 29 Sep 2021 09:21:27 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.171) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 29 Sep 2021 09:21:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LKt+5pVwkQ3RxtZOXYF6qXDDyF+p3lx7kRD4vNk5aikcwsDOAFPS2dg799NY5REnqu8++Pc/+e8xSs4Q+ZFxUh32k9KKDsYfKnfP5SXVjfAq8keDGQpneqY160KplZT/cFZLl8eUMwufnBJlPhSWIAuQn65tioqmU/XhkRwERZCFF5dRxyAGw7k4Run9C7YDK/c4AjK+L6NoE0DtRkiXfhgtgAg/K3RsMRRrk6zzcQ7H+EYcNbrb5M1Yd+y0HfQ9Z2g8i6k3vAtANaCk4awNA6wzunLujaFCtyC6aeVOsN8zV99XYJhXgIwj0cpPdh68JfG+IkhNeY8O9/Bq2JQPwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=cq/dfJVtwO0eYovPW9tsbufVuLoSq+l+qJ3XSAbaqxs=; b=I9WrY36oZ4IHr6EUHW4bPNKPVyrE28SpcaItGeH8vXMPulX8XZmjMR0JxglaN6HMPZtLiKItnjs9tWtsiOEmmH8QRprC4hyIn+4L+LxBSnw8jkLLpUKnBXREJpWIGbdeuvurYl90PJKed/dysgtx1f4XCNHtsX74Y4cpRVGpcGGZRc3wErHqYtPFgdqN4b/a2hL0vCyitKjeJIOB/CocrJJa+QkbUKZIqfj1uPtl/BGkEGr7MiKWeP7XwrgLk3G6s14zXdySLkuBDgfNbdAQQKcD7ssx6gi9VBF3mTuUMFF44qBZwYzaYGB430ohzhfyjDjOeCk8kHy1ydN+6VGruw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cq/dfJVtwO0eYovPW9tsbufVuLoSq+l+qJ3XSAbaqxs=; b=ucA5yCj85E3O8oLV/B7ZHhn/7SblLCjhSTuDb2Chz3Tg3Mi9aaCEY3wjEKgu3+5y6B3KriZjnK6fDywy6y0S4uwnepPd2/5u9OMdpFcRmLqXjzlWKgCdPvNhyH74LyrgJqJLehIcu48DDShuxpxyB9ZfGNOptdTTRZYMP2ty7sE= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5047.namprd11.prod.outlook.com (2603:10b6:510:3c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14; Wed, 29 Sep 2021 16:21:25 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4544.021; Wed, 29 Sep 2021 16:21:25 +0000 To: Robin Zhang , CC: , , , , , , , , , , , , , , , Sylwester Dziedziuch References: <20210618063851.3694702-1-robinx.zhang@intel.com> <20210906020258.1291688-1-robinx.zhang@intel.com> <20210906020258.1291688-2-robinx.zhang@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <5da1e903-34da-e02d-96a6-9733b3ee190b@intel.com> Date: Wed, 29 Sep 2021 17:21:16 +0100 In-Reply-To: <20210906020258.1291688-2-robinx.zhang@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU2PR04CA0200.eurprd04.prod.outlook.com (2603:10a6:10:28d::25) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0200.eurprd04.prod.outlook.com (2603:10a6:10:28d::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Wed, 29 Sep 2021 16:21:22 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3f7226cf-c11d-4229-d34f-08d983652f26 X-MS-TrafficTypeDiagnostic: PH0PR11MB5047: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iZwhJepRU+geGnXR7uhBiMmsZu9VmFsGgOX9JADb9gAMYe+o4H5XCE2D4fRFdxkxSHroKqNTrmHXl+QytMxCln0NIaI2D3wybkwtQs/oxmmuaIoM+VVibV1Pl8jVfjdzE9N3Ngsu9iFCbWj2N5xKpgpaul0h/Ham5lmR67wXoKYxDzIHPffTNyly3DmiuiEAh1KA1Sgk8yGbuwWrmc5z5RTO/5vENem5SNApxHvxmH2UDEN10Buy1X4VPYWoupmOKFk4FBOPDkEph16Ugn3i/0AzzIICiQXi49k1XYVY9b2jysQ71NPBfxr4qiEL5n4Cco2a2JgS42RXl3Yk050Q2qeYz3CWVgi+K01j5nz0VPVB7Ez0eZV9Na8c2LHKUzvUfPviKyScWVZEI8nfT6Ik4SvJvAGVI/aKrgqTAFB/dCAoNxYzhrLAbNwOzdYEnutUpb+Sm3mUKGdZTvXxOuJLHm2KQH+3gPGV9CIjvhQN8vhQeli/xyfzcC+r08/wJNrxmnvWvKtEZG8B36dLdYjbfFr3xQnSqrejsioZ04wRQOQoAzr310Arl580dANrT32wdKoE8N2I9C7qQPsCyChCQwqSnvfldHqPFsV8xahUcheTkx5m7Dhi1vajic0fCxNKAiCgZ4aX49nrNqe8XcYmQSg1NdTNR4A2dBFD4yJNKy2ArF70ZMLFdym0ZJ8VTr2Ur9lEUl0Isf8wsvdMh0QXTw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(66946007)(8676002)(66556008)(66476007)(53546011)(44832011)(508600001)(6486002)(31686004)(6666004)(83380400001)(4326008)(5660300002)(38100700002)(107886003)(31696002)(2906002)(2616005)(316002)(16576012)(956004)(26005)(186003)(8936002)(86362001)(36756003)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TVRBY2dOdS9VZ3ZKbkxJVDUzQyt5TkVsNVFTWGJiNHdWdGMweFFPNGZ4SWJm?= =?utf-8?B?bEREaFEwQmFSQWFhZDNLbEpmL2ZZaGtaMzRmeVNSNTlRVDVsQTZzemZneEY5?= =?utf-8?B?UE1WaGR2akFKUWFodGVwWmxKemJHV1ltdEpnRTZnL1laY0ZNY0laZEhyR3Iy?= =?utf-8?B?SjU1UTFiclJ0Y01pODBzbExwMXZtc0g3NzNKNkZVQmViaG55L001emZHOXRS?= =?utf-8?B?ZEMwa0VRL0UvYk1VVjduMDJacU1TOHFnYjM1M2VhMTNKN29kMFpYWVpualZV?= =?utf-8?B?bHZoVFZYVGdsVzBwTUljTElKaHd1Rjg2WWN6V2VWM2VXOXlMMXlkNzNrdHh6?= =?utf-8?B?UWhjTnNVQk1Day8xVFVFSG9MT2NuYTVEOEUrMThaVDhrcmhzSTc2N0FPbkdx?= =?utf-8?B?ekhsSkJEUGpNL2tJOW4xUXlVejBCOC93WTl2MVVUMXVzdGNQNGRmTWVITEhp?= =?utf-8?B?UWtHUGZUbTdpaDhRWU9zMEswMFUzaEdnM01jcm9BTXJlSWNLR2FRd1ljKzdm?= =?utf-8?B?NkcxNzFzZkVyV3NFd2xzVE1VNFhvMUMrak5YcG5FMW1DN05ZNmlMck9DbS9N?= =?utf-8?B?VDN2WlpoVnBvSUhrdDNwV2Uxb1JhZW05L2l6TWorcTNMN1dTbFM0V1ZreWc4?= =?utf-8?B?MlZWSnJtTjZwV004c1hXTkhyQk1aMzBHQllFWnNpQW1vb0pObmN2eFczSjBv?= =?utf-8?B?bVdoN0g5dGRtUDBJYTZqSmdhbEdES2krZXAzZFBiRjRJSHQreEV0SkVUYXYr?= =?utf-8?B?bmVIZXozRlZ0MzJ4alYzQ1ozU0RhT1dEVjJweTk0eW9CZEVwNzJ2TzR0TG92?= =?utf-8?B?SmZQTGFkVkNPWXM4Y0pSR1I3R1I2ZEx6Z1oxQ25vaGJCaXozUC94QkVIbi9E?= =?utf-8?B?NkFPbHc1dGZ6R1ZiTE4yeW1LcEZsQjdJTERlVEJ5RTc5MWdiT0tOS0hSVFZU?= =?utf-8?B?RWFqZDN2d0dIcjZwVkhwOUg2ZlZHd1pleGY3NG40Q3lNaUt0YWk3YTdBNTBR?= =?utf-8?B?VkRkSXNFdkJESm5ERUtxTWVHdElNZk9ReUgvWUlyZ0dJbGJ6YkhLalpFY1FO?= =?utf-8?B?SGlkMHBxeTgvbWk5aHFKNWFmaVhJQVpBTm4xb3RuS1RKenVEaHphMzI1VWJ6?= =?utf-8?B?S1lMekJGcUxPRklhWkE3a1VUUFNiOGplOEYwNW1hemE4d3M4TVNoTjhRWFhC?= =?utf-8?B?UGtzTGx3WXRHSVluVHFZT1ZXUEIyWDFNQlgxMEQ0UHd2Z1VJY2g3NWFxWDVJ?= =?utf-8?B?WjhyTUpsL1NnVUdJY2pPdnZxc2kvNmFmT3pMQXhNZExTdXplNGpJWXUvV0Zs?= =?utf-8?B?dFplWFJmRlMwUEJRdXpDM1hudVl2WEN3ZFNRay9iSU1YWE1td2RaSDQreFkx?= =?utf-8?B?YTd1SmNzYWMyOFFvalV1U2tYdmpqd0J2YWQ5Q0cwdERrYVo0Q1EvalZmWTV1?= =?utf-8?B?ZTJFMjZJcFRoeUtZYjlSekQxeERLaDV2THk5Z29IYlozWnA0eXk3OERFT3Nv?= =?utf-8?B?ejZSd1cxNm1laE5CSHU1b21oajhaMUh3ck1KM2ttYXBFODAxQ3lTT3lQV3lh?= =?utf-8?B?NkI1eWVhMjUwc2dzNkVtV2FBSEJ6cHV1enY0dllJWS9sMWNveVh1WDgyVzdz?= =?utf-8?B?dGIzRW1UdWU3UDduSUJpZDI4Z0FOSDMwb3hkRDNEL0puMldCSjVhS2ZHdlB0?= =?utf-8?B?QmgzU0UvMXNpREpLRTcyaXZRZmlLQ3lRN0ZiS0ltR0YxL005U3ZYZytJMXVS?= =?utf-8?Q?wsDimQMeh7aHyw5y5D7yxy2mI4I/Uh7fd4dW8q+?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3f7226cf-c11d-4229-d34f-08d983652f26 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2021 16:21:25.7626 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SPDzeZoQQwv+lTNzGVpzdQzNImTgip/AB2MtvzttBof+Rsk9PT69fPZ0wLGXxIrPxdsdmVLHNbnA45hwlvpI7w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5047 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4 01/18] net/i40e/base: add new versions of send ASQ command functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/6/2021 3:02 AM, Robin Zhang wrote: > ASQ send command functions are returning only i40e status codes > yet some calling functions also need Admin Queue status > that is stored in hw->aq.asq_last_status. Since hw object > is stored on a heap it introduces a possibility for > a race condition in access to hw if calling function is not > fast enough to read hw->aq.asq_last_status before next > send ASQ command is executed. > > Added new versions of send ASQ command functions that return > Admin Queue status on the stack to avoid race conditions > in access to hw->aq.asq_last_status. > Added new _v2 version of i40e_aq_remove_macvlan and i40e_aq_add_macvlan > that is using new _v2 versions of ASQ send command functions and > returns the Admin Queue status on the stack. > > Signed-off-by: Sylwester Dziedziuch > Signed-off-by: Robin Zhang I assume ASQ is "Admin Send Queue" (although datasheet refers to it as ATQ), can you please give the long version of the abbreviations in the commit log in first usage as: "ASQ (Admin Send Queue) ... "