From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48FC041C66; Sat, 11 Feb 2023 04:04:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 285BE40E50; Sat, 11 Feb 2023 04:04:31 +0100 (CET) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 0D94C40E0F for ; Sat, 11 Feb 2023 04:04:29 +0100 (CET) Received: from kwepemm600004.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4PDFlQ62GnzHtd4; Sat, 11 Feb 2023 11:02:42 +0800 (CST) Received: from [10.67.103.231] (10.67.103.231) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Sat, 11 Feb 2023 11:04:26 +0800 Message-ID: <5dc7b13b-7e29-1cec-558d-d597e55defa4@huawei.com> Date: Sat, 11 Feb 2023 11:04:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH] mem: fix displaying heap ID failed for heap info command To: , CC: , , , fengchengwen References: <20230209030341.9697-1-lihuisong@huawei.com> From: "lihuisong (C)" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.231] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemm600004.china.huawei.com (7.193.23.242) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 在 2023/2/9 11:23, fengchengwen 写道: > Acked-by: Chengwen Feng > > And, how abort add error log in telemetry valid_name, so so that problems can > be identified as early as possible. It might be better for adding an error log. What do you think, Bruce? > > On 2023/2/9 11:03, Huisong Li wrote: >> The telemetry lib has added a allowed characters set for dictionary names, >> See commit >> 2537fb0c5f34 ("telemetry: limit characters allowed in dictionary names") >> >> The space is not in this set, which cause the heap ID in /eal/heap_info >> cannot be displayed. Additionally, 'heap' is also misspelling. So use >> 'Heap_id' to replace 'Head id'. >> >> Fixes: e6732d0d6e26 ("mem: add telemetry infos") >> Cc: stable@dpdk.org >> >> Signed-off-by: Huisong Li >> --- >> lib/eal/common/eal_common_memory.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lib/eal/common/eal_common_memory.c b/lib/eal/common/eal_common_memory.c >> index c917b981bc..c2a4c8f9e7 100644 >> --- a/lib/eal/common/eal_common_memory.c >> +++ b/lib/eal/common/eal_common_memory.c >> @@ -1139,7 +1139,7 @@ handle_eal_heap_info_request(const char *cmd __rte_unused, const char *params, >> malloc_heap_get_stats(heap, &sock_stats); >> >> rte_tel_data_start_dict(d); >> - rte_tel_data_add_dict_uint(d, "Head id", heap_id); >> + rte_tel_data_add_dict_uint(d, "Heap_id", heap_id); >> rte_tel_data_add_dict_string(d, "Name", heap->name); >> rte_tel_data_add_dict_uint(d, "Heap_size", >> sock_stats.heap_totalsz_bytes); >> > .