From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7A01A0A02; Thu, 25 Mar 2021 08:21:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 87F85140D03; Thu, 25 Mar 2021 08:21:55 +0100 (CET) Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by mails.dpdk.org (Postfix) with ESMTP id 3299A40693 for ; Thu, 25 Mar 2021 08:21:53 +0100 (CET) Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4F5c1f3M7Bz9spJ; Thu, 25 Mar 2021 15:19:50 +0800 (CST) Received: from [10.78.49.194] (10.78.49.194) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.498.0; Thu, 25 Mar 2021 15:21:49 +0800 To: Ruifeng Wang , "thomas@monjalon.net" , "ferruh.yigit@intel.com" CC: "dev@dpdk.org" , "linuxarm@openeuler.org" , nd References: <1612356396-21309-1-git-send-email-oulijun@huawei.com> <1615340142-19115-1-git-send-email-oulijun@huawei.com> <1615340142-19115-2-git-send-email-oulijun@huawei.com> From: oulijun Message-ID: <5dcaf497-b146-a1b1-ac92-0ab98017af47@huawei.com> Date: Thu, 25 Mar 2021 15:21:49 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.78.49.194] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 在 2021/3/23 23:40, Ruifeng Wang 写道: >> -----Original Message----- >> From: oulijun >> Sent: Tuesday, March 23, 2021 9:52 PM >> To: Ruifeng Wang ; thomas@monjalon.net; >> ferruh.yigit@intel.com >> Cc: dev@dpdk.org; linuxarm@openeuler.org; nd >> Subject: Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon >> kunpeng920 implementer >> >> >> >> 2021/3/23 16:07, Ruifeng Wang д : >>>> -----Original Message----- >>>> From: dev On Behalf Of Lijun Ou >>>> Sent: Wednesday, March 10, 2021 9:36 AM >>>> To: thomas@monjalon.net; ferruh.yigit@intel.com >>>> Cc: dev@dpdk.org; linuxarm@openeuler.org >>>> Subject: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon >>>> kunpeng920 implementer >>>> >>>> Here addes Kunpeng920 config back which was deleted. >>>> >>>> Fixes: 91c730fd4e09 ("config/arm: remove unused or superfluous >>>> variables") >>>> >>>> Signed-off-by: Chengchang Tang >>>> Signed-off-by: Lijun Ou >>>> --- >>>> V1->V2: >>>> - rewrite patch title. >>>> - split the patch into two. >>>> --- >>>> config/arm/meson.build | 20 ++++++++++++++++++++ >>>> 1 file changed, 20 insertions(+) >>>> >>>> diff --git a/config/arm/meson.build b/config/arm/meson.build index >>>> 00bc461..3826900 100644 >>>> --- a/config/arm/meson.build >>>> +++ b/config/arm/meson.build >>>> @@ -133,6 +133,25 @@ implementer_cavium = { >>>> } >>>> } >>>> >>>> +implementer_hisilicon = { >>>> + 'description': 'Hisilicon', >>>> + 'flags': [ >>>> + ['RTE_USE_C11_MEM_MODEL', true], >>>> + ['RTE_CACHE_LINE_SIZE', 128], >>> >>> Just want to double check. >>> One Kunpeng920 box I can access have cache line size 64B. >>> >> I have a question, which level does RTE_CACHE_LINE_SIZE refer to? For >> kunpeng920, L1/L2 cache size is 64B L3 is 128B > > Got it. > I think RTE_CACHE_LINE_SIZE is not defined for a certain level of cache. > Data can be prefetched into any level of cache by using different APIs. > So our current configuration should be fine. >>> Thanks. >>>> + ['RTE_MAX_NUMA_NODES', 4] >>>> + ], >>>> + 'part_number_config': { >>>> + '0xd01': { >>>> + 'machine_args': ['-march=armv8.2-a+crypto', >>>> + '-mtune=tsv110'], >>>> + 'flag': [['RTE_MACHINE', '"kunpeng920"'], >>>> + ['RTE_MAX_LCORE', 128], >>>> + ['RTE_ARM_FEATURE_ATOMICS', true] >>>> + ] >>>> + } >>>> + } >>>> +} >>>> + >>>> implementer_ampere = { >>>> 'description': 'Ampere Computing', >>>> 'flags': [ >>>> @@ -190,6 +209,7 @@ implementers = { >>>> 'generic': implementer_generic, >>>> '0x41': implementer_arm, >>>> '0x43': implementer_cavium, >>>> + '0x48': implementer_hisilicon, >>>> '0x50': implementer_ampere, >>>> '0x51': implementer_qualcomm, >>>> '0x56': implementer_marvell, >>>> -- >>>> 2.7.4 >>> >>> . >>>