From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 196FAA046B; Thu, 9 Jan 2020 17:36:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B5AE01E497; Thu, 9 Jan 2020 17:36:20 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id B04631DDD8 for ; Thu, 9 Jan 2020 17:36:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578587779; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Wx80/L2hXwINvCSpPxLtxUTzkPhrOm3dq2C7TsAUYuY=; b=XimcI4dkrKybw9DoRalqdUacG90PpeRXRRZO0O/zaZXl27pPs9VAme1avminyRqDStgz/Y r0plOZP+KhyjwtJz+BFn025MhLA58Sla5oLYi2LovKWVFBKRIVDfw6UwscJKPXvW82SFaX HaY+KzBp5aP+MVftHXHXmg51xxEcD4o= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-310-kQlnx_NeMdOgdncJECEifQ-1; Thu, 09 Jan 2020 11:36:17 -0500 Received: by mail-wr1-f71.google.com with SMTP id z14so3107398wrs.4 for ; Thu, 09 Jan 2020 08:36:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Wx80/L2hXwINvCSpPxLtxUTzkPhrOm3dq2C7TsAUYuY=; b=aHZqV/09sPGZWUPLPYp2J8THPq2lFYL4g3ODA+kzHlBhmrDNy90weP/mQq2zJ4A8w4 xCjHKvMP5ZMpJ6kiT6zGy5PS81ANX4yAMR/fZk+oWI1V9S0Hskq8SmvOhbzyWHXM8N88 qhe2ULpoc2ETsUNR1gQPQ12KJoGag/nkEJ1LR3RSI1dPBRXCd8IX4BB91DNmQgpNsiqA iYm3BTZ4o+1YHRg1jq0DH0BckD18s/+hFbEud0swJl3Nybt/t3zGZ5yBAsA8ksOmNmU/ sg02JSFD9ZHDIQB4jmz50hBywk89cKMBTU7TzzSa67BxCsIQmpJ1pEVMql7/OyzAX1dy 1EcQ== X-Gm-Message-State: APjAAAUlZeq96U1FYA2xQrxAz3HWWS2RV2cqPetYQE09DBsvVamnQwun B/5UJIssaCmOnUF9pTm7JZebOAuqwTkHOd1wTPFOw4NxYI/JNlVw9ZHAMb1QDSV6uCxN1PvgbSg 843I= X-Received: by 2002:adf:f802:: with SMTP id s2mr11967620wrp.201.1578587776499; Thu, 09 Jan 2020 08:36:16 -0800 (PST) X-Google-Smtp-Source: APXvYqw8+beoTmeReQecvDlMts8FCQnDv5RqiajwXmMDJoWOifVW5Xb4wuHqkbOmG2RreuS0QZitfg== X-Received: by 2002:adf:f802:: with SMTP id s2mr11967605wrp.201.1578587776280; Thu, 09 Jan 2020 08:36:16 -0800 (PST) Received: from amorenoz.users.ipa.redhat.com (static.169.4.0.81.ibercom.com. [81.0.4.169]) by smtp.gmail.com with ESMTPSA id z8sm8274385wrq.22.2020.01.09.08.36.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jan 2020 08:36:15 -0800 (PST) To: Maxime Coquelin , dev@dpdk.org Cc: tiwei.bie@intel.com, zhihong.wang@intel.com, huawei.xie@intel.com References: <20191204150729.31816-1-amorenoz@redhat.com> <497fb633-061b-76e3-b6de-bf08b691dbaf@redhat.com> <283236ea-8d47-46d8-08ba-17aebcf607c5@redhat.com> From: Adrian Moreno Autocrypt: addr=amorenoz@redhat.com; prefer-encrypt=mutual; keydata= mQENBF1syNUBCADQ9dk3fDMxOZ/+OQpmbanpodYxEv8IRtDz8PXw8YX7UyGfozOpLjQ8Fftj ZxuubYNbt2QVbSgviFilFdNWu2eTnN/JaGtfhmTOLPVoakkPHZF8lbgImMoch7L0fH8wN2IM KPxQyPNlX+K9FD5brHsV1lfe1TwAxmhcvLW8yNrVq+9eDIDykxc7tH4exIqXgZroahGxMHKy c8Ti2kJka/t6pDfRaY0J+6J7I1nrn6GXXSMNA45EH8+0N/QlcXhP3rfftnoPeVmpjswzvJqY FNjf/Q5VPLx7RX0Qx+y8mMB2JcChV5Bl7D7x5EUbItj6+Sy7QfOgCtPegk9HSrBCNYaLABEB AAG0I0FkcmlhbiBNb3Jlbm8gPGFtb3Jlbm96QHJlZGhhdC5jb20+iQFUBBMBCAA+FiEEogUD gihhmbOPHy26d5C5fbYeFsUFAl1syNUCGwMFCQHhM4AFCwkIBwIGFQoJCAsCBBYCAwECHgEC F4AACgkQd5C5fbYeFsX7qwgArGHSkX+ILNcujkVzjTG4OtkpJMPFlkn/1PxSEKD0jLuzx14B COzpg/Mqj3Re/QBuOas+ci9bsUA0/2nORtmmEBvzDOJpR5FH1jaGCx8USlY4WM6QqEDNZgTw hsy9KhjFzFjMk+oo3HyItXA+Uq9yrRBTjNBGTXxezMRcMuUZ4MIAfY0IRBglL2BufiuL43jD BvTENNFLoQ/wFV7qkFWSkv+8IjTsxr7M6XUo1QLd29Hn0dvwssN579HL1+BP46i2REpzeBEG L75iVChi+YnIQQNMJ9NYarVabZx4Y1Gn8+7B/1SNArDV+IDgnYgt7E58otoV2Ap310dmtuvE VbxGpbkBDQRdbMjVAQgAqyp9oA7WDu7/Y9T4Ommt69iZx8os7shUIfdgPEy5xrcPn6qGwN1/ HQ4j8nWfBG9uuX1X0RXUZIUEtYTxtED4yaCQMTqDUf9cBAwAA2mYxBfoiNYx8YqxM+sT0/J4 2qmDd+y+20UR4yzHE8AmIbspTzDFIJDAi+jKSR8F355z0sfW7CIMDC4ZWrPsskjEy1YN/U10 r6tRRH1kNyrCSbTG0d9MtcQO58h7DLXuzUhErB+BtG52A04t5cweIJTJC+koV5XPeilzlHnm RFoj0ncruGa9Odns21BNt3cy9wLfK+aUnWuAB1uc6bJGQPiAwjkilz7g7MBRUuIQ2Zt7HGLc SwARAQABiQE8BBgBCAAmFiEEogUDgihhmbOPHy26d5C5fbYeFsUFAl1syNUCGwwFCQHhM4AA CgkQd5C5fbYeFsUlSwf8CH+u/IXaE7WeWxwFkMaORfW8cM4q0xrL3M6yRGuQNW+kMjnrvK9U J9G+L1/5uTRbDQ/4LdoKqize8LjehA+iF6ba4t9Npikh8fLKWgaJfQ/hPhH4C3O5gWPOLTW6 ylGxiuER4CdFwQIoAMMslhFA7G+teeOKBq36E+1+zrybI6Xy1UBSlpDK9j4CtTnMQejjuSQb Qhle+l8VroaUHq869wjAhRHHhqmtJKggI+OvzgQpDIwfHIDypb1BuKydi2W6cVYEALUYyCLS dTBDhzj8zR5tPCsga8J7+TclQzkWOiI2C6ZtiWrMsL/Uym3uXk5nsoc7lSj7yLd/MrBRhYfP JQ== Message-ID: <5dd8242b-27c1-e02b-b579-1e72b115ca59@redhat.com> Date: Thu, 9 Jan 2020 17:36:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <283236ea-8d47-46d8-08ba-17aebcf607c5@redhat.com> Content-Language: en-US X-MC-Unique: kQlnx_NeMdOgdncJECEifQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] vhost: Add dynamic logging system X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/9/20 4:45 PM, Maxime Coquelin wrote: > > > On 1/9/20 3:40 PM, Maxime Coquelin wrote: >> >> >> On 12/4/19 4:07 PM, Adrian Moreno wrote: >>> Currently there are a couple of limitations on the logging system: Most >>> of the logs are compiled out and both datapath and controlpath logs >>> share the same loglevel. >>> >>> This patch tries to help fix that situation by: >>> - Splitting control plane and data plane logs >>> - Making control plane logs dynamic while keeping data plane logs >>> compiled out by default for log levels lower than the INFO. >>> >>> As a result, two macros are introduced: >>> - VHOST_LOG_CONFIG(LEVEL, ...): Config path logging. Level can be >>> dynamically controlled by "lib.vhost.config" >>> >>> - VHOST_LOG_DATA(LEVEL, ...): Data path logging. Level can be dynamically >>> controlled by "lib.vhost.data". Every log macro with a level lower than >>> RTE_LOG_DP_LEVEL (which defaults to RTE_LOG_INFO) will be compiled out. >>> >>> Signed-off-by: Adrian Moreno >>> Fixes: 1c01d52392d5 ("vhost: add debug print") > > I propose to remove the Fixes line, as thinking at it again, it is more > an improvement. > > Also, I fixed the title to remove the upper case to "Add" so that it > complies with the guidelines. > Thanks Maxime, and sorry for the typo. Adrian. > > Thanks, > Maxime > >>> Cc: huawei.xie@intel.com >>> Cc: maxime.coquelin@redhat.com >>> --- >>> lib/librte_vhost/iotlb.c | 10 +- >>> lib/librte_vhost/socket.c | 84 ++++++------- >>> lib/librte_vhost/vhost.c | 34 ++++-- >>> lib/librte_vhost/vhost.h | 24 ++-- >>> lib/librte_vhost/vhost_user.c | 218 +++++++++++++++++----------------- >>> lib/librte_vhost/virtio_net.c | 38 +++--- >>> 6 files changed, 214 insertions(+), 194 deletions(-) >>> >> >> Reviewed-by: Maxime Coquelin >> >> Thanks, >> Maxime >> >