From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BEFDFA034F; Mon, 22 Mar 2021 18:08:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC015140DD9; Mon, 22 Mar 2021 18:08:36 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 806024003D for ; Mon, 22 Mar 2021 18:08:34 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12MH52VQ030498; Mon, 22 Mar 2021 10:08:33 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=message-id : date : mime-version : subject : to : references : from : cc : in-reply-to : content-type : content-transfer-encoding; s=pfpt0220; bh=v67Y+2+R64lXU/PRTrU2yTwa13jC4ycla2+AVhHE2L0=; b=IsUfM1UYvdqUsVVf8G63W8dZUC8IfpkaHcDOBTWrwBDFlX75HdP9rqQdKom/igCfwxYI 9uVrqyJPJ5+6cIvJO0rLSHjP1ZZ6lgwdP4O5WJdmDtrHXkHqHA5XyE8OYDvhirDCsnrR hxHyehtVf9+8JoX80rHdS4vpu+b70hpbf8UhbHpAk1bjo1jO645wsln8csAQI06lWxhv 9wqFD5ZoQkOHbFz0A/wawtQW7ADHYku3CGTGBrnch0uEt8UwFamzoSsGRYbCCcp0Q014 XN5XwVjZ4DZRiQQcbFqNV1DZskwSuHsD6nGd+Yd5mjzBKHTQ3g3Q6MyMZ4aj8NP5GYFz Iw== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0b-0016f401.pphosted.com with ESMTP id 37dgjnwt1r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 22 Mar 2021 10:08:33 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 22 Mar 2021 10:08:31 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 22 Mar 2021 10:08:31 -0700 Received: from [10.193.38.106] (unknown [10.193.38.106]) by maili.marvell.com (Postfix) with ESMTP id 9CFC53F7041; Mon, 22 Mar 2021 10:08:30 -0700 (PDT) Message-ID: <5df2a5e4-972e-499c-7f23-12cf191d00fd@marvell.com> Date: Mon, 22 Mar 2021 18:08:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:87.0) Gecko/20100101 Thunderbird/87.0 Content-Language: en-US To: Balazs Nemeth , , Jerin Jacob References: From: Igor Russkikh CC: Devendra Singh Rawat , Rasesh Mody In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-03-22_09:2021-03-22, 2021-03-22 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH 0/8] Optimize qede use of rx/tx_entries X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/5/2021 2:13 PM, Balazs Nemeth wrote: > External Email > > ---------------------------------------------------------------------- > This patch set optimizes qede_{rx,tx}_entry and introduces > rte_pktmbuf_free_bulk in qede_process_tx_compl. The overall performance > improvement depends on the use-case; in a physical-virtual-physical test > on a ThunderX2 99xx system with two SMT threads used in ovs, > and two cores used in a vm, an improvement of around 2.55% is observed > due to this patch set. > > Balazs Nemeth (8): > net/qede: remove flags from qede_tx_entry and simplify to rte_mbuf > net/qede: avoid repeatedly calling ecore_chain_get_cons_idx > net/qede: assume txq->sw_tx_ring[idx] is never null in > qede_free_tx_pkt > net/qede: inline qede_free_tx_pkt to prepare for rte_pktmbuf_free_bulk > net/qede: use rte_pktmbuf_free_bulk instead of rte_pktmbuf_free > net/qede: prefetch txq->hw_cons_ptr > net/qede: prefetch next packet to free > net/qede: remove page_offset from struct qede_rx_entry and simplify > > drivers/net/qede/qede_rxtx.c | 148 +++++++++++++++++++---------------- > drivers/net/qede/qede_rxtx.h | 21 +---- > 2 files changed, 81 insertions(+), 88 deletions(-) Series reviewed, for the series Acked-by: Igor Russkikh One checkpatch warn I see in patchwork output, probably worth fixing: ERROR:POINTER_LOCATION: "(foo**)" should be "(foo **)" #120: FILE: drivers/net/qede/qede_rxtx.c:56: + ret = rte_mempool_get_bulk(rxq->mb_pool, (void**)&rxq->sw_rx_ring[idx], count); Thanks Igor