Re: [PATCH v3] net/intel: add IDPF PCI class ID support

["Singh, Aman Deep" <aman.deep.singh@intel.com>]

On 25-09-2025 23:17, Vemula Venkatesh wrote:
> Current IDPF supports only the MEV device IDs. MMG has new set of
> device IDs and same might be the case for the future devices. Instead
> of adding new device IDs every time, make use of the IDPF PCI class
> ID(0x20001) to differentiate between PF and VF.
>
> Write and read the VF_ARQBAL register to find if the current device is
> a PF or a VF.
>
> v3: addressed reviewers comments.
>
> Signed-off-by: Vemula Venkatesh <venkatesh.vemula@intel.com>
> ---
>   drivers/net/intel/cpfl/cpfl_ethdev.c          |  3 ++-
>   drivers/net/intel/cpfl/cpfl_ethdev.h          |  3 ++-
>   .../net/intel/idpf/base/idpf_controlq_api.h   |  1 +
>   drivers/net/intel/idpf/idpf_common_device.c   | 20 +++++++++++++++++--
>   drivers/net/intel/idpf/idpf_common_device.h   | 20 +++++++++++++++++++
>   drivers/net/intel/idpf/idpf_ethdev.c          |  2 ++
>   6 files changed, 45 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/intel/cpfl/cpfl_ethdev.c b/drivers/net/intel/cpfl/cpfl_ethdev.c
> index 6d7b23ad7a..8cec977ecf 100644
> --- a/drivers/net/intel/cpfl/cpfl_ethdev.c
> +++ b/drivers/net/intel/cpfl/cpfl_ethdev.c
> @@ -2606,7 +2606,8 @@ cpfl_dev_vport_init(struct rte_eth_dev *dev, void *init_params)
>   }
>   
>   static const struct rte_pci_id pci_id_cpfl_map[] = {
> -	{ RTE_PCI_DEVICE(IDPF_INTEL_VENDOR_ID, IDPF_DEV_ID_CPF) },
> +	{ RTE_PCI_DEVICE(IDPF_INTEL_VENDOR_ID, CPFL_DEV_ID_MEV) },
> +	{ RTE_PCI_DEVICE(IDPF_INTEL_VENDOR_ID, CPFL_DEV_ID_MMG) },
>   	{ .vendor_id = 0, /* sentinel */ },
>   };
>   
> diff --git a/drivers/net/intel/cpfl/cpfl_ethdev.h b/drivers/net/intel/cpfl/cpfl_ethdev.h
> index d4e1176ab1..566b395dae 100644
> --- a/drivers/net/intel/cpfl/cpfl_ethdev.h
> +++ b/drivers/net/intel/cpfl/cpfl_ethdev.h
> @@ -59,7 +59,8 @@
>   #define CPFL_ALARM_INTERVAL	50000 /* us */
>   
>   /* Device IDs */
> -#define IDPF_DEV_ID_CPF			0x1453
> +#define CPFL_DEV_ID_MMG			0x11E0
> +#define CPFL_DEV_ID_MEV			0x1453
>   #define VIRTCHNL2_QUEUE_GROUP_P2P	0x100
>   
>   #define CPFL_HOST_ID_NUM	2
> diff --git a/drivers/net/intel/idpf/base/idpf_controlq_api.h b/drivers/net/intel/idpf/base/idpf_controlq_api.h
> index 8a90258099..bcea789ae9 100644
> --- a/drivers/net/intel/idpf/base/idpf_controlq_api.h
> +++ b/drivers/net/intel/idpf/base/idpf_controlq_api.h
> @@ -179,6 +179,7 @@ struct idpf_hw {
>   	struct idpf_hw_func_caps func_caps;
>   
>   	/* pci info */
> +	uint32_t cls_id;
>   	u16 device_id;
>   	u16 vendor_id;
>   	u16 subsystem_device_id;
> diff --git a/drivers/net/intel/idpf/idpf_common_device.c b/drivers/net/intel/idpf/idpf_common_device.c
> index ff1fbcd2b4..357a2c692e 100644
> --- a/drivers/net/intel/idpf/idpf_common_device.c
> +++ b/drivers/net/intel/idpf/idpf_common_device.c
> @@ -130,7 +130,7 @@ idpf_init_mbx(struct idpf_hw *hw)
>   	struct idpf_ctlq_info *ctlq;
>   	int ret = 0;
>   
> -	if (hw->device_id == IDPF_DEV_ID_SRIOV)
> +	if (idpf_is_vf_device(hw))
>   		ret = idpf_ctlq_init(hw, IDPF_CTLQ_NUM, vf_ctlq_info);
>   	else
>   		ret = idpf_ctlq_init(hw, IDPF_CTLQ_NUM, pf_ctlq_info);
> @@ -389,7 +389,7 @@ idpf_adapter_init(struct idpf_adapter *adapter)
>   	struct idpf_hw *hw = &adapter->hw;
>   	int ret;
>   
> -	if (hw->device_id == IDPF_DEV_ID_SRIOV) {
> +	if (idpf_is_vf_device(hw)){
>   		ret = idpf_check_vf_reset_done(hw);
>   	} else {
>   		idpf_reset_pf(hw);
> @@ -443,6 +443,22 @@ idpf_adapter_init(struct idpf_adapter *adapter)
>   	return ret;
>   }
>   
> +#define IDPF_VF_TEST_VAL		0xFEED0000
> +
> +/**
> + * idpf_is_vf_device - Helper to find if it is a VF/PF device
> + * @hw: idpf_hw struct
> + *
> + * Return: 1 for VF device, 0 for PF device.
> + */
> +bool idpf_is_vf_device(struct idpf_hw *hw)
> +{
> +	if (hw->device_id == IDPF_DEV_ID_SRIOV)
> +		return 1;
> +	IDPF_WRITE_REG(hw, VF_ARQBAL, IDPF_VF_TEST_VAL);
> +	return IDPF_READ_REG(hw, VF_ARQBAL) == IDPF_VF_TEST_VAL;
> +}
> +
>   RTE_EXPORT_INTERNAL_SYMBOL(idpf_adapter_deinit)
>   int
>   idpf_adapter_deinit(struct idpf_adapter *adapter)
> diff --git a/drivers/net/intel/idpf/idpf_common_device.h b/drivers/net/intel/idpf/idpf_common_device.h
> index 5f3e4a4fcf..f6154862da 100644
> --- a/drivers/net/intel/idpf/idpf_common_device.h
> +++ b/drivers/net/intel/idpf/idpf_common_device.h
> @@ -44,6 +44,26 @@
>   	(sizeof(struct virtchnl2_ptype) +				\
>   	 (((p)->proto_id_count ? ((p)->proto_id_count - 1) : 0) * sizeof((p)->proto_id[0])))
>   
> +/** Macro used to help building up tables of device IDs with PCI class */
> +#define IDPF_PCI_CLASS(cls)          \
> +	.class_id = (cls),      \
> +	.vendor_id = RTE_PCI_ANY_ID,  \
> +	.device_id = RTE_PCI_ANY_ID,  \
> +	.subsystem_vendor_id = RTE_PCI_ANY_ID, \
> +	.subsystem_device_id = RTE_PCI_ANY_ID
> +
> +
> +/* PCI Class network ethernet */
> +#define PCI_BASE_CLASS_NETWORK_ETHERNET 0x02
> +#define PCI_SUB_BASE_CLASS_NETWORK_ETHERNET 0x00
> +
> +#define IDPF_NETWORK_ETHERNET_PROGIF				0x01
> +#define IDPF_CLASS_NETWORK_ETHERNET_PROGIF			\
> +(PCI_BASE_CLASS_NETWORK_ETHERNET << 16 | PCI_SUB_BASE_CLASS_NETWORK_ETHERNET << 8 |  \
> +IDPF_NETWORK_ETHERNET_PROGIF )
> +
> +bool idpf_is_vf_device(struct idpf_hw *hw);
> +
>   struct idpf_adapter {
>   	struct idpf_hw hw;
>   	struct virtchnl2_version_info virtchnl_version;
> diff --git a/drivers/net/intel/idpf/idpf_ethdev.c b/drivers/net/intel/idpf/idpf_ethdev.c
> index 90720909bf..80bf53db0f 100644
> --- a/drivers/net/intel/idpf/idpf_ethdev.c
> +++ b/drivers/net/intel/idpf/idpf_ethdev.c
> @@ -1201,6 +1201,7 @@ idpf_adapter_ext_init(struct rte_pci_device *pci_dev, struct idpf_adapter_ext *a
>   	hw->vendor_id = pci_dev->id.vendor_id;
>   	hw->device_id = pci_dev->id.device_id;
>   	hw->subsystem_vendor_id = pci_dev->id.subsystem_vendor_id;
> +	hw->cls_id = pci_dev->id.class_id;
I think we don't need this variable "cls_id".
It's not getting checked anywhere
>   
>   	strncpy(adapter->name, pci_dev->device.name, PCI_PRI_STR_SIZE);
>   
> @@ -1313,6 +1314,7 @@ idpf_dev_vport_init(struct rte_eth_dev *dev, void *init_params)
>   static const struct rte_pci_id pci_id_idpf_map[] = {
>   	{ RTE_PCI_DEVICE(IDPF_INTEL_VENDOR_ID, IDPF_DEV_ID_PF) },
>   	{ RTE_PCI_DEVICE(IDPF_INTEL_VENDOR_ID, IDPF_DEV_ID_SRIOV) },
> +	{ IDPF_PCI_CLASS(IDPF_CLASS_NETWORK_ETHERNET_PROGIF) },
>   	{ .vendor_id = 0, /* sentinel */ },
>   };
>   
Regards
Aman