From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f173.google.com (mail-pf0-f173.google.com [209.85.192.173]) by dpdk.org (Postfix) with ESMTP id 271DB1B5E3 for ; Fri, 13 Oct 2017 03:16:01 +0200 (CEST) Received: by mail-pf0-f173.google.com with SMTP id b85so7464260pfj.13 for ; Thu, 12 Oct 2017 18:16:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=sjIUvlgK4ld3kvtFigjjyEHf8dCDvzAyvlhateP3Z2Y=; b=d7pmLgvY8j/H8Qg5jwOP3pVcAvDte+i1prD0DnFoO5SuoSP7SZ1fBWX5jIUEBNacGt eYp73hS/LiMd0BKs2c9SsJ1bo7hR8b89qBCGWw7ywLYQLM8ynRcxyNLv1JuWiK95bQql qDWmiwtLseLMy0oCObbdntwinWvNBcVrTHx+1UJm2M5F0pbMM7FR3OF/Kd6DuFqtIEGJ XLfYkE8lvQHDprUKCnKYhXfJ4WpS/4rSgHvmaPOjEV+9UWWH5aUc29YynOEYJRjq5qs7 hAuTPsIYS3/4VOpuFXUFs3lVCXz9NriI+LQBnu1sWGJwXn6NXRiM0p3m00XddY+nk9TG SPWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=sjIUvlgK4ld3kvtFigjjyEHf8dCDvzAyvlhateP3Z2Y=; b=oWRae8N82xcoqZ4jkrtgirg8yGeARC+4+EJH5KwYX0UAMbHjHpVuybNC2Hg6ES8oFj dcXjGl+CRO1UZgx/AUpJ4YF5IirN7uTyqWvTUXemMouXaCIoXBNrdBrK0KVPJIoEbdUP JM7SSxq9L+b/7yZoEihrZypNpY0HC3JJ5ed+m/+iM27VhsYVQIu8xVXgIYhhD9Nnr4ex Yx4P2Yz3dpCs4FPRf1Cfwg9wdI5FCoIN2lMVKJuvnSCXvUzvXNmliA9Y3ft4GkC8aJmz CCR4o+6hvrSvkWipdxQvH3mwHy/4yQwZlxkEYbD23DT/Gg0SWGOrv/4r84O6afZgRGrj +QrQ== X-Gm-Message-State: AMCzsaU4k6CIzwdYPTLVGF6tQ77QOC/gMnKlqlU+krrYlB7eLDhM2XNt rCRgrRt+meC+ZFuMEXeE7TSPcEx7 X-Google-Smtp-Source: AOwi7QAsPQusvaZz/ADdKY0AOlFywa9C8qoHdn2+sEeZ0/7blvixOhPjBOA94ihFkEsyQf1ug9gdFg== X-Received: by 10.99.43.150 with SMTP id r144mr1629298pgr.380.1507857361220; Thu, 12 Oct 2017 18:16:01 -0700 (PDT) Received: from [0.0.0.0] (67.209.179.165.16clouds.com. [67.209.179.165]) by smtp.gmail.com with ESMTPSA id o13sm29766391pfh.91.2017.10.12.18.15.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Oct 2017 18:16:00 -0700 (PDT) From: Jia He To: Jerin Jacob , "Ananyev, Konstantin" Cc: Olivier MATZ , "dev@dpdk.org" , "jia.he@hxt-semitech.com" , "jie2.liu@hxt-semitech.com" , "bing.zhao@hxt-semitech.com" References: <20171010095636.4507-1-hejianet@gmail.com> <20171012155350.j34ddtivxzd27pag@platinum> <2601191342CEEE43887BDE71AB9772585FAA859F@IRSMSX103.ger.corp.intel.com> <20171012172311.GA8524@jerin> Message-ID: <5df4a28b-be1d-d0d8-8148-96f982e212d6@gmail.com> Date: Fri, 13 Oct 2017 09:15:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] ring: guarantee ordering of cons/prod loading when doing enqueue/dequeue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Oct 2017 01:16:02 -0000 On 10/13/2017 9:02 AM, Jia He Wrote: > Hi Jerin > > > On 10/13/2017 1:23 AM, Jerin Jacob Wrote: >> -----Original Message----- >>> Date: Thu, 12 Oct 2017 17:05:50 +0000 >>> [...] >> On the same lines, >> >> Jia He, jie2.liu, bing.zhao, >> >> Is this patch based on code review or do you saw this issue on any of >> the >> arm/ppc target? arm64 will have performance impact with this change. sorry, miss one important information Our platform is an aarch64 server with 46 cpus. If we reduced the involved cpu numbers, the bug occurred less frequently. Yes, mb barrier impact the performance, but correctness is more important, isn't it ;-) Maybe we can  find any other lightweight barrier here? Cheers, Jia > Based on mbuf_autotest, the rte_panic will be invoked in seconds. > > PANIC in test_refcnt_iter(): > (lcore=0, iter=0): after 10s only 61 of 64 mbufs left free > 1: [./test(rte_dump_stack+0x38) [0x58d868]] > Aborted (core dumped) > > Cheers, > Jia >> >> >>> Konstantin >