From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <david.hunt@intel.com> Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 16B411396 for <dev@dpdk.org>; Mon, 13 Mar 2017 12:02:19 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP; 13 Mar 2017 04:02:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,158,1486454400"; d="scan'208";a="833959548" Received: from dhunt5-mobl.ger.corp.intel.com (HELO [10.237.221.69]) ([10.237.221.69]) by FMSMGA003.fm.intel.com with ESMTP; 13 Mar 2017 04:02:17 -0700 To: "Van Haaren, Harry" <harry.van.haaren@intel.com>, "Richardson, Bruce" <bruce.richardson@intel.com> References: <1488354455-142764-2-git-send-email-david.hunt@intel.com> <1488791433-186137-1-git-send-email-david.hunt@intel.com> <1488791433-186137-10-git-send-email-david.hunt@intel.com> <20170310162228.GB339712@bricha3-MOBL3.ger.corp.intel.com> <73b1521e-6517-d74c-8113-86a634f1a0ce@intel.com> <E923DB57A917B54B9182A2E928D00FA6129FB4C8@IRSMSX102.ger.corp.intel.com> Cc: "dev@dpdk.org" <dev@dpdk.org> From: "Hunt, David" <david.hunt@intel.com> Message-ID: <5df970e2-cb97-9267-e1b8-90d4b93a58db@intel.com> Date: Mon, 13 Mar 2017 11:02:17 +0000 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <E923DB57A917B54B9182A2E928D00FA6129FB4C8@IRSMSX102.ger.corp.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v9 09/18] lib: add symbol versioning to distributor X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 13 Mar 2017 11:02:20 -0000 On 13/3/2017 11:01 AM, Van Haaren, Harry wrote: >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hunt, David >> Subject: Re: [dpdk-dev] [PATCH v9 09/18] lib: add symbol versioning to distributor >> >> On 10/3/2017 4:22 PM, Bruce Richardson wrote: >>> On Mon, Mar 06, 2017 at 09:10:24AM +0000, David Hunt wrote: >>>> Also bumped up the ABI version number in the Makefile >>>> >>>> Signed-off-by: David Hunt <david.hunt@intel.com> >>>> --- >>>> lib/librte_distributor/Makefile | 2 +- >>>> lib/librte_distributor/rte_distributor.c | 57 +++++++++++--- >>>> lib/librte_distributor/rte_distributor_v1705.h | 89 ++++++++++++++++++++++ >>> A file named rte_distributor_v1705.h was added in patch 4, then deleted >>> in patch 7, and now added again here. Seems a lot of churn. >>> >>> /Bruce >>> >> The first introduction of this file is what will become the public >> header. For successful compilation, >> this cannot be called rte_distributor.h until the symbol versioning >> patch, at which stage I will >> rename the file, and introduce the symbol versioned header at the same >> time. In the next patch >> I'll rename this version of the files as rte_distributor_public.h to >> make this clearer. > > Suggestion to use rte_distributor_next.h instead of public? > Public doesn't indicate if its old or new, while next would make that clearer IMO :) Good call, will use "_next". Its clearer. Thanks, Dave.