From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david.hunt@intel.com>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id 98AFA1B193
 for <dev@dpdk.org>; Tue, 25 Sep 2018 15:47:22 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 25 Sep 2018 06:47:21 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.54,302,1534834800"; d="scan'208";a="86398225"
Received: from dhunt5-mobl2.ger.corp.intel.com (HELO [10.237.221.37])
 ([10.237.221.37])
 by orsmga003.jf.intel.com with ESMTP; 25 Sep 2018 06:47:20 -0700
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>, dev@dpdk.org
Cc: john.mcnamara@intel.com, stephen@networkplumber.org, lei.a.yao@intel.com, 
 bruce.richardson@intel.com
References: <20180912144930.50578-1-david.hunt@intel.com>
 <20180914135406.52190-1-david.hunt@intel.com>
 <20180914135406.52190-2-david.hunt@intel.com>
 <8c4533b1-6aed-96ee-c901-9241c34c2ff1@intel.com>
From: "Hunt, David" <david.hunt@intel.com>
Message-ID: <5e031658-7e2b-761b-9ca7-5fa059149695@intel.com>
Date: Tue, 25 Sep 2018 14:47:18 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <8c4533b1-6aed-96ee-c901-9241c34c2ff1@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Subject: Re: [dpdk-dev] [PATCH v3 1/8] examples/power: add checks around
 hypervisor
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Sep 2018 13:47:23 -0000



On 25/9/2018 10:20 AM, Burakov, Anatoly wrote:
> On 14-Sep-18 2:53 PM, David Hunt wrote:
>> Allow vm_power_manager to run without requiring qemu to be present
>> on the machine. This will be required for instances where the JSON
>> interface is used for commands and polices, without any VMs present.
>> A use case for this is a container enviromnent.
>>
>> Signed-off-by: David Hunt <david.hunt@intel.com>
>> ---
>
> <snip>
>
>> --- a/examples/vm_power_manager/channel_monitor.c
>> +++ b/examples/vm_power_manager/channel_monitor.c
>> @@ -66,7 +66,7 @@ static void
>>   core_share_status(int pNo)
>>   {
>>   -    int noVms, noVcpus, z, x, t;
>> +    int noVms = 0, noVcpus = 0, z, x, t;
>
> This looks like a unrelated change?
>
>>       get_all_vm(&noVms, &noVcpus);
>>
>
>
I'll move it to a separate commit in the next version.

Thanks,
Dave.