DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thinh Tran <thinhtr@linux.vnet.ibm.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Jerin Jacob <jerinjacobk@gmail.com>, dpdk-dev <dev@dpdk.org>,
	David Christensen <drc@linux.vnet.ibm.com>
Subject: Re: [dpdk-dev] [PATCH] rte_trace: fix build on PPC64
Date: Tue, 28 Apr 2020 10:26:48 -0500	[thread overview]
Message-ID: <5e260577-e4a2-9cfb-c45c-d6bc73788089@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAJFAV8ySsfc6Z_8OitEnDFRGFM+kjXDTY2h=4SxnLOvhUPgXPQ@mail.gmail.com>

I looked at it, but I have a simpler patch below that can resolve the 
conflict, including after removing previous patches in mlx4/mlx5

Thanks,
Thinh Tran

  diff --git a/lib/librte_eal/ppc/include/rte_memcpy.h 
b/lib/librte_eal/ppc/include/rte_memcpy.h
index 25311ba1d..abeede231 100644
--- a/lib/librte_eal/ppc/include/rte_memcpy.h
+++ b/lib/librte_eal/ppc/include/rte_memcpy.h
@@ -11,6 +11,10 @@
  /*To include altivec.h, GCC version must  >= 4.8 */
  #include <altivec.h>

+/* redefine as in stdbool.h */
+#undef bool
+#define bool _Bool
+
  #ifdef __cplusplus
  extern "C" {
  #endif

On 4/28/2020 10:04 AM, David Marchand wrote:
> On Tue, Apr 28, 2020 at 5:02 PM Thinh Tran <thinhtr@linux.vnet.ibm.com> wrote:
>>
>> Agreed, this is not rte_trace issue. Moving to rte_common.h does not
>> work neither, because altivec.h is included after and redefine bool
>> This conflict happens on PPC64, I'll create a different patch.
> 
> Please look at Ori patch.
> Thanks.
> 
> http://patchwork.dpdk.org/patch/69426/
> 

      reply	other threads:[~2020-04-28 15:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-27 21:58 Thinh Tran
2020-04-28  7:57 ` Jerin Jacob
2020-04-28  8:52   ` David Marchand
2020-04-28 15:01   ` Thinh Tran
2020-04-28 15:04     ` David Marchand
2020-04-28 15:26       ` Thinh Tran [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e260577-e4a2-9cfb-c45c-d6bc73788089@linux.vnet.ibm.com \
    --to=thinhtr@linux.vnet.ibm.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=drc@linux.vnet.ibm.com \
    --cc=jerinjacobk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).