From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id D81731B214 for ; Thu, 19 Oct 2017 14:51:56 +0200 (CEST) Received: by mail-wr0-f195.google.com with SMTP id o44so8200837wrf.11 for ; Thu, 19 Oct 2017 05:51:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=M6F98JH/x+wn7tgMBky9ElJ+KNPNycD4axu7lEhtI8o=; b=Bf2UxGF+thkKAJH/LDLuc63Maql9ZFe3O/yERuF6kLeFg5kuAz5T+EGEEDND+5e1sv uuWohLyQgJfzSQYbuel01O+v1PPioAQtRaZ7z9N8uM9JAsFCS0U8p90aurcl6/4N2N2x ES8e0YIS8d2rBF/g9rUyoMMTOVAS5ePMghULhB6yTabKNtgUTANd2zcIQ94j9iVV0aSX FvMIjyYC+S7JjH4ankHbH495jSjnnhrzQfhF+GidwfxGQIi80TataE5bE3Y/4Xzc/QpI GT+Rx2Q/ueFKEmsRyynmzKMX2NfLL2x4r83wynIuqR0jWt7Kq2lED+w7S5WVeQDM+y7v GT1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=M6F98JH/x+wn7tgMBky9ElJ+KNPNycD4axu7lEhtI8o=; b=SXOZZdaFVBR8sjQsD4XNadAbH631BFrCggxJ9IKPpIXtUYkDtRm18HQ9YvUV+afoPT GtBojNJJT9IsZT5SclIy0TYWndhhpKPyPeQLyOpHyaSo93I3m+Yjh5Puk3DPZu7U+YBo 11hJb4c2ecKP32hGZgA6+qth4/ZJI5qwDkwxYi6Dvgb4HfJ31V1FaF6cSkzY+4n8rw8Q ebkz/jTt9+odVh0xr88PzR2aKvGNsTYhqjAzK+JoEMrnB/1i55j07JMVvBMtNMw6LtxZ kLA6rYTMBhYGKx8lr+I8Fs+rdz0Gn6kEYAEcoO6FvGGpn7ejDnuJ9Uqkuse3CVu/lc4x qnQA== X-Gm-Message-State: AMCzsaX0ugfgMPo6+PCfUc0gCzTCP+OY+OpzmJtLEy8t7L9ggjPpb+sq lJF5QwVFNuyUTaBJMcPEKCQ4X14tXg== X-Google-Smtp-Source: ABhQp+TihzP4MazG/oHMindOes9QcInCNfqDOSCIrzAxYsevBF1FPbhqu1G1Hj+5wXu9AN/1YF/l6Q== X-Received: by 10.223.134.84 with SMTP id 20mr1669040wrw.60.1508417514285; Thu, 19 Oct 2017 05:51:54 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 69sm1024189wmp.11.2017.10.19.05.51.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Oct 2017 05:51:53 -0700 (PDT) From: Nelio Laranjeiro To: dev@dpdk.org Cc: Yongseok Koh , Adrien Mazarguil Date: Thu, 19 Oct 2017 14:51:33 +0200 Message-Id: <5e51330b777b5ed89ac189faaca5f7f70764bb95.1508417257.git.nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: References: In-Reply-To: References: Subject: [dpdk-dev] [PATCH 5/6] net/mlx5: fix mark action with drop action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Oct 2017 12:51:57 -0000 Marking a packet which will not be received by the NIC is useless, even if this action remains possible, it blocks the creation of the flow counter which embed a mark action to a drop queue to be created. Fixes: 31ba9997f11a ("net/mlx5: fully convert a flow to verbs in validate") Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 96a753e8d..13b78ce9b 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -786,6 +786,8 @@ priv_flow_convert_actions(struct priv *priv, goto exit_action_not_supported; } } + if (parser->drop && parser->mark) + parser->mark = 0; if (!parser->queues_n && !parser->drop) { rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_HANDLE, NULL, "no valid action"); -- 2.11.0