From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50B38A0561; Fri, 5 Mar 2021 07:12:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB5684068C; Fri, 5 Mar 2021 07:12:53 +0100 (CET) Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by mails.dpdk.org (Postfix) with ESMTP id 3553040147 for ; Fri, 5 Mar 2021 07:12:51 +0100 (CET) Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4DsHRx100HzjVK0; Fri, 5 Mar 2021 14:11:25 +0800 (CST) Received: from [10.78.49.194] (10.78.49.194) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.498.0; Fri, 5 Mar 2021 14:12:44 +0800 To: "Li, Xiaoyun" , "Yigit, Ferruh" CC: "dev@dpdk.org" , "linuxarm@openeuler.org" References: <1614905757-33791-1-git-send-email-oulijun@huawei.com> <1614905757-33791-3-git-send-email-oulijun@huawei.com> From: oulijun Message-ID: <5e524711-f3e3-36fc-c420-d7579607602c@huawei.com> Date: Fri, 5 Mar 2021 14:12:44 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.78.49.194] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH 2/3] app/testpmd: remove forwarding config from parsing Rx and Tx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" ÔÚ 2021/3/5 11:21, Li, Xiaoyun дµÀ: > Hi > >> -----Original Message----- >> From: dev On Behalf Of Lijun Ou >> Sent: Friday, March 5, 2021 08:56 >> To: Yigit, Ferruh >> Cc: dev@dpdk.org; linuxarm@openeuler.org >> Subject: [dpdk-dev] [PATCH 2/3] app/testpmd: remove forwarding config from >> parsing Rx and Tx >> >> From: Huisong Li >> >> The "fwd_config_setup()" function does release and apply for memory of >> forwarding flows, and re-establish these flows when rxq/txq or rxd/txd is >> changed. The function is also called by "start_packet_forwarding()" when user >> executes "start" cmd. >> All changes for rxq/txq or rxd/txd can be updated uniformly when this command >> is executed. Therefore, it is a little redundant in the "cmd_config_rx_tx_parsed" >> function. >> >> In addition, the forwarding flows under one TC is configured based on number >> of queues allocated to TC. And number of queues allocated to TC is updated >> after calling "rte_eth_dev_configure" >> again. If the number of queues is reduced after configuring the DCB, and then, >> release and apply for flow memory, and reinitialize the forwarding flows under >> the DCB mode based on the old TC information. As a result, null pointer may be >> accessed. > > The patch looks good to me. But in commit log, you mean forwarding streams, right? Flows will confuse to mean rte_flow. Yes. it is forwarding streams. > >> >> Like: >> set nbcore 4 >> port stop all >> port config 0 dcb vt off 4 pfc on >> port start all >> port stop all >> port config all rxq 8 >> port config all txq 8 >> >> At the moment, a segmentation fault occurs. >> >> Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") >> Cc: stable@dpdk.org >> >> Signed-off-by: Huisong Li >> Signed-off-by: Lijun Ou >> --- >> app/test-pmd/cmdline.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index >> 832ae70..8b0f7d5 100644 >> --- a/app/test-pmd/cmdline.c >> +++ b/app/test-pmd/cmdline.c >> @@ -1837,8 +1837,6 @@ cmd_config_rx_tx_parsed(void *parsed_result, >> return; >> } >> >> - fwd_config_setup(); >> - >> init_port_config(); >> >> cmd_reconfig_device_queue(RTE_PORT_ALL, 1, 1); >> -- >> 2.7.4 > > . >