From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA5A44404F; Wed, 12 Jun 2024 17:13:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 030BE42E51; Wed, 12 Jun 2024 17:05:09 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mails.dpdk.org (Postfix) with ESMTP id C915542D78 for ; Wed, 12 Jun 2024 17:05:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718204706; x=1749740706; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=TgwVA9FN3MfgjC7uSlFkMZS7cviWbG66AQleAPTka+Q=; b=b5N3l2Cgv/V/Z0+t2fxJvOE7jVLgXjf+AJJ0whIi503xPxCahk/C/ieL DyLPC3CfHTLLdr5VFi5c+R/d6egs+hD1xqZ1QqfgLh+iwBlWmQ5jWn1B+ fBkNycoe7jvSX/vLrMnqnJG1owwm72qLQDlxZ9bphePWjAODAsaBEIcft Jo4/Cr3QRINhi2ITcKIpnQwjnnoZNlWgoDJ/164+oiw8k4NuLGxyYBN4l s6w0eQRH4v/WN8BwhHuaCO7cqqhfj19uQM3HH9F8dJtndvQR5SieX7RCH MNfnUbMqfSW3jHQBd81uxzAfXQ4ToIOOJ6rzko3zIa6w1agXHGct+YMBu g==; X-CSE-ConnectionGUID: unu8zL6lR5SBp9sWQppRcQ== X-CSE-MsgGUID: M5aMoJm1ShO2zGe48AA2jQ== X-IronPort-AV: E=McAfee;i="6700,10204,11101"; a="32459542" X-IronPort-AV: E=Sophos;i="6.08,233,1712646000"; d="scan'208";a="32459542" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2024 08:04:49 -0700 X-CSE-ConnectionGUID: WpqR8YqdRgmSsvgC5oSO3A== X-CSE-MsgGUID: DdHZjcxwT9GR2R0HAsPnSA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,233,1712646000"; d="scan'208";a="39925371" Received: from silpixa00401119.ir.intel.com ([10.55.129.167]) by orviesa009.jf.intel.com with ESMTP; 12 Jun 2024 08:04:47 -0700 From: Anatoly Burakov To: dev@dpdk.org Cc: Ian Stokes , bruce.richardson@intel.com, Adrian Pielech Subject: [PATCH v2 056/148] net/ice/base: remove dead code from ice_get_ddp_pkg_state Date: Wed, 12 Jun 2024 16:00:50 +0100 Message-ID: <5e70920a2d53462318abb62e7d8db927b7f6ba90.1718204528.git.anatoly.burakov@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: <20240430154014.1026-1-ian.stokes@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Ian Stokes Removed "else" statement in ice_get_ddp_pkg_state() as it may never happen. Signed-off-by: Adrian Pielech Signed-off-by: Ian Stokes --- drivers/net/ice/base/ice_ddp.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ice/base/ice_ddp.c b/drivers/net/ice/base/ice_ddp.c index fcf6dc69e3..5a0cf4d54f 100644 --- a/drivers/net/ice/base/ice_ddp.c +++ b/drivers/net/ice/base/ice_ddp.c @@ -1205,11 +1205,8 @@ ice_get_ddp_pkg_state(struct ice_hw *hw, bool already_loaded) } else if (hw->active_pkg_ver.major != ICE_PKG_SUPP_VER_MAJ || hw->active_pkg_ver.minor != ICE_PKG_SUPP_VER_MNR) { return ICE_DDP_PKG_ALREADY_LOADED_NOT_SUPPORTED; - } else if (hw->active_pkg_ver.major == ICE_PKG_SUPP_VER_MAJ && - hw->active_pkg_ver.minor == ICE_PKG_SUPP_VER_MNR) { + } else { return ICE_DDP_PKG_COMPATIBLE_ALREADY_LOADED; - } else { - return ICE_DDP_PKG_ERR; } } -- 2.43.0