From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A04A0A09E4; Fri, 29 Jan 2021 09:46:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2609C2400FB; Fri, 29 Jan 2021 09:46:22 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id DB20940694 for ; Fri, 29 Jan 2021 09:46:19 +0100 (CET) IronPort-SDR: cNizUVXE75DupWDxAiB4ES3/6T3C5ldwUNqLs7bSHbWcYWfgvu6nc0rqjXNu/wKBp3oMYU4P4U QpYdUy2Ec/OA== X-IronPort-AV: E=McAfee;i="6000,8403,9878"; a="159561864" X-IronPort-AV: E=Sophos;i="5.79,385,1602572400"; d="scan'208";a="159561864" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2021 00:46:18 -0800 IronPort-SDR: isHOUFnegyJTzxLFgs2+Ov87nG+OF5C51NPqitskMwGwps2W3gVzgVXKwBK184VRfr3SUKaX0A mjagIIf5/V8w== X-IronPort-AV: E=Sophos;i="5.79,385,1602572400"; d="scan'208";a="389219252" Received: from mpkenny-mobl.ger.corp.intel.com (HELO [10.213.197.204]) ([10.213.197.204]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2021 00:46:15 -0800 To: oulijun , Thomas Monjalon Cc: arybchenko@solarflare.com, dev@dpdk.org, linuxarm@openeuler.org References: <1611150232-609-1-git-send-email-oulijun@huawei.com> <1611837805-42429-1-git-send-email-oulijun@huawei.com> <1611837805-42429-3-git-send-email-oulijun@huawei.com> <2843903.C3Glkg52S3@thomas> <117895e7-b00b-4f72-05ee-ced0d62d2aae@huawei.com> From: Ferruh Yigit Message-ID: <5e75c811-c3ef-486a-471b-eeabde28bd7b@intel.com> Date: Fri, 29 Jan 2021 08:46:10 +0000 MIME-Version: 1.0 In-Reply-To: <117895e7-b00b-4f72-05ee-ced0d62d2aae@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 2/5] net/hns3: add FEC feature for hns3.ini X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/29/2021 1:13 AM, oulijun wrote: > > > 在 2021/1/28 22:12, Thomas Monjalon 写道: >> 28/01/2021 13:43, Lijun Ou: >>> The hns3 PMD add FEC features implementation in 20.11. >>> Therefore, need to update the hns3.ini for supporting. >>> >>> Fixes: 9bf2ea8dbc65 ("net/hns3: support FEC") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Lijun Ou >>> --- >>>   doc/guides/nics/features/hns3.ini | 1 + >>>   1 file changed, 1 insertion(+) >>> >>> diff --git a/doc/guides/nics/features/hns3.ini >>> b/doc/guides/nics/features/hns3.ini >>> index a467396..4ea568c 100644 >>> --- a/doc/guides/nics/features/hns3.ini >>> +++ b/doc/guides/nics/features/hns3.ini >>> @@ -39,5 +39,6 @@ Stats per queue      = Y >>>   FW version           = Y >>>   Registers dump       = Y >>>   Multiprocess aware   = Y >>> +FEC             = Y >> >> Please don't use tabs but only spaces in such .ini file. >> > OK， I will fix it >> Can it be squashed with the commit adding the feature in default.ini? > Do you think patch[1/5] is merged into one ? I took ferruh.yigit's advice. > Both OK to me, according Thomas' suggestion 1/5, 2/5 & 3/5 can be merged.