From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EBD5BA0093; Fri, 23 Dec 2022 11:44:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D7DA740A7F; Fri, 23 Dec 2022 11:44:20 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by mails.dpdk.org (Postfix) with ESMTP id F3A3D40698 for ; Fri, 23 Dec 2022 11:44:18 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g62BDqsz72bVI7Vun+okqssHRmuh7XB8ALkum+ZOT0j96d0MI0ISYfOLFUChJcI8r2e3FRvs62HPgxo2/cFadrHn649MucSSUKvOx37+4UgZV8jRC05WYSdXgA8h9MLaVVHcG7HzWYOYW6fBirsZo6TvM3/E2EWFr37TjBjDkmbssbPndePZGp1/K3n5VaHpXE+Y6d7TK1vqefUUPHUHI0QklKBrBFON7/w8ok6j4V76vJ+/uL+4ThOs9EnWQN/gtyaipAqgtUgpLUybtPWkhoxRF+mqJNjlhIvc8qw0H/QWONItOFYTXuQc5LURaJwv6aWBPBZ9/Gk7N18SQ5JBEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wTyya504UZzG4tEnG9t+TAPbauLXWiGzJ69R9rMGK5E=; b=FaUr8/0BR1XJXrWbab9b+ZaBj0JMKtNrLn5MlbmXFyeLesdw847mowLWqX7WIn/pj57XviUAG2pMyQFLPWR2LvT5mx6GN/aHOARZfGdl31ptSLelWek4FzMKvHalLvBARvgFrBvq2K957+v1RYrQPWfxYrm99X4zhf4r524qnpwQF1DCHwpm+2zOkzvgac/vJqkt8NXR/FsikhDSEohb1thoJDYB0S3WfGOjSayf4s1/LDhVgiU/fxmSB2PrDAlu/E8Ebj5VflrSjZMoKzQlAVb8W4y6HoizYtfMxmJBC/mqqMwFkFlW9Al3McT5JcszEkkOeddUiDIe+5Fozow43w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wTyya504UZzG4tEnG9t+TAPbauLXWiGzJ69R9rMGK5E=; b=Ha2Q36aUBzpvzufYe3Qd9XMPwrpnb0Fw9VSvtJGgtP8u6i78ZUMd4bSrVzgpwelaV3R7Ydr2E5MKnUYvaK6bKG/ddXHEUp7+GecA0we+fEO3qHQ6EoMbVZym5YGyyFTxwU465WEXktMJJrLvvdDqjYC/1ssQqqr5uWzx6tF982o= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MW4PR12MB6974.namprd12.prod.outlook.com (2603:10b6:303:207::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.13; Fri, 23 Dec 2022 10:44:16 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a%8]) with mapi id 15.20.5924.016; Fri, 23 Dec 2022 10:44:16 +0000 Message-ID: <5e98e934-c955-6df8-4908-da9926cab407@amd.com> Date: Fri, 23 Dec 2022 10:44:12 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v1 1/2] net/axgbe: add multi-process support To: Jesna K E , dev@dpdk.org Cc: Selwin.Sebastian@amd.com References: <20221221025202.31733-1-jesna.k.e@amd.com> Content-Language: en-US From: Ferruh Yigit In-Reply-To: <20221221025202.31733-1-jesna.k.e@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0042.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:152::11) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MW4PR12MB6974:EE_ X-MS-Office365-Filtering-Correlation-Id: d6bf8064-4636-42dc-ca97-08dae4d2a390 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5/R9O+BE9Pn+75tFgWXqObZgT4kT+Fa1Q71kxPNCQPVokhAMZneAkVREC7YnqXxjJVMjbykJZh5CUOio1fFno6wEYb4eKxTvXeDUqXxDg/F03Phi/qgF1h6WlP6kc4L3F7rsIQKb0JBe2b6vEev7az5182vzs2UtfFq++AgHXNUjvOIEbKf4D0R5/E/aYddLd8hYocXT97QQyIDyG00JfBYwocECiCMWPVhxo4O30kwodDl/z/QOvPENOrq5O9iEBpSEj2fX03iyNPM/Ck8P4iIU19g/066IUh0U5xTm80EeJU6p2zTGY5IHhpBejeekoBnkP3Rl3AeQgdJUEbnpbRuzvTtl0Pdrq2fEOzQrldhWAw+oMg/ScnKKKdBu87Nqhkr4tYcvlha+WNBrRxQ60jxR8D93G34NN2kWrh/crcU1SlE37RgpO4f7JISbDtOTIxyZhZVmGe6bfHd/JJZoTwWkR8X3+KIzB0u16clm+Ha1L1zUBvGaf8oej4askr9vqEjiXpM9Sa7OAtJvuvwZVgdMnUoeuBYmbtyM5lpKCk8HI9kYJBNaT008LVy0IzA4r2SXx4+J3Kuu+vTomrN9FPggU6RmP1PkMXZP1/PjVXdzlm//4cYmFSi9Ook5ZuoBIekr9riLJ/a1sdhBzJu4o1iN2zB+P6akqVbY8RFgUjUg/OBp38VJ/6bftqdxzICvXqyY2r9svyR/yPDKZrs8LM+ao6+QiO7MbvYYKUNUIwM= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(366004)(376002)(396003)(136003)(346002)(451199015)(2906002)(8936002)(5660300002)(31686004)(4744005)(316002)(41300700001)(66476007)(66946007)(66556008)(4326008)(8676002)(36756003)(478600001)(6666004)(6486002)(38100700002)(6512007)(186003)(26005)(53546011)(6506007)(44832011)(86362001)(31696002)(2616005)(83380400001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dUFZdDhIbVduc2Q1QnVScFllZDh5a3dCVXByejBneERsbFpxWGpkQTZFTjk1?= =?utf-8?B?K2pkWjUrSGNYOCtzakswdjVHcXRIcjhhVWV4VUExd1VPNTNPNlg3Z1NqZEd1?= =?utf-8?B?eHZNVkVDYlZaOExoczdPandkaUFDYklyZUxwWS82a0FkRGZCekFGN3k4cHVJ?= =?utf-8?B?WWhaQVZ4Wm1lNEtYN3NjUk1ubzNLWjgycXhaZjhCK0YyNjFtTmFSMzZOcmI4?= =?utf-8?B?bk5xRVlLU2VzTmwwdlYzRHgwWkE4QTBDZlVsMnR5L1lwQVJHeTYzbVRqcGRR?= =?utf-8?B?YStxNXpGQ2hxc3Uvd09aUjI5Rnk5Qkt4YTZJQnBCUlpTUjlVWjJNMmw0Umdw?= =?utf-8?B?RGp3L0VFYnFhSy9TRVZ2aXhReS9tS0NQSWl2VFlCR3o2WmxycEwwM212dzBu?= =?utf-8?B?OUFxOHNjaFdjMTJ6NHp1cWozbGpsbUVxYUcrWHdzK3hyb0hXTE9rSGdGUHl6?= =?utf-8?B?MlpOdEpLd2c2N1JKSWs3Rnhyb1E0WFZKZGtuRWlQdEFSSm1mYWUxMEtRWGlN?= =?utf-8?B?N0wwSTlxT3hWUDdib055andSUCtuK1QrWE1hRlNISGpqRE15TVppSHEraHM2?= =?utf-8?B?Q21oVVFFbEdjbFpUejhBSnZVa25HMU1ReEZIbC9Dc0FFRlZ4a3E1Q2l6d0Rk?= =?utf-8?B?by9zb2NsSk5aeVIwYUlMVGgwaEpVZURiMThyMDZpempZdHRNYlkrOUQxMkJB?= =?utf-8?B?Zkh5c3Q3T2l4cVFubjA4dXVyeUl0NzQ5YWRxZmUxYUpwTGZ1UEhWQVNYdW5W?= =?utf-8?B?Mi9UVUs0YjZMelFOdTZGOG8wQkliQ3RiT08wUHM2R0h1cFdZQ3MzUWxnZG1q?= =?utf-8?B?d1JGNytPSXNoUzkxYUpRd3JSQlM4eHhveGJjbXV4MXNjRCtFSFRYb3FkVFZm?= =?utf-8?B?YTkyOVl6TEw3c3dZRko1QXFGNUZpU3V0WWZyN244N1Q2ZXhtR1MrQUoyTHhS?= =?utf-8?B?VEJYSTg2S3hlTGdtUCtHa21MN3FITEJHckRCOFBEb0ZLMmREcmlOc1MzSEUw?= =?utf-8?B?UnhnckZtL21BS01Cb21nQWVpOHkrRUlONDZncXVXOXJNWU4yR2NMQnBHcjNo?= =?utf-8?B?ZnRnaG1KYXdFcWxzbWhjS3Fqem5vOGo1OFA3VThVRWJWaGdwUWxYcGZGeStr?= =?utf-8?B?SzNjdnhXNkx3ZHk0NTdzUlBRUWVCZGR0ZXpuM3d1RDU0Z0N3aGFMRFRrNmdB?= =?utf-8?B?bGk4YTR5V0Jwa3pXZkV3VnhsaTRvaHQxTVhLN1g0bm9LQWVyK01DVkxHWkxp?= =?utf-8?B?WXZzMGRseDFlVGt5NWRjZUVwQkovL1h1S3NMN2RldVJDV09wQjlTUytEaEdI?= =?utf-8?B?SVRkVUFyR20wa2dSb0Q1aWxVNWwxc2lESHhNQ1ZwTmsvWVVBZHJLNUk0SVBN?= =?utf-8?B?VFZ4QVU2YU9UWnJqVEswQXlwdGdYbk1VVU43bU5MaXlWL2tBV2FaNmtCdTNm?= =?utf-8?B?WVpEbWZsMW50Q3Z3SXRHMVRqdVQrbnd2U0NOVmlGTEU0VS9lT3hsTTExRTN6?= =?utf-8?B?M1JFMUNiY29MRmpPbU1ES1VlTEREUlJmMEsyV2VySDZoalEwQlRIVFhGblhJ?= =?utf-8?B?MEhJWnNxTDlpaml4YkVWUWFseUZPVU5Gd05WdkZGSTFvYXZCQm1SQ1VHUFNa?= =?utf-8?B?SHlOS3YwSkFRNnNlQW5Nak9jcmN6QXlsUVhPMVZVU0sray93dnZLYzRvZi9G?= =?utf-8?B?WDFkNis3SFVqbUtLcmVMSmNycDAzbUZwbzAxKzhRM0JRMlVOamtGdnQwKyt5?= =?utf-8?B?dGNuZnRGMnJQbkVyZzdiVnVLajBKN242Zkl1anhET1V3azh3ZWZhaHFnMlFE?= =?utf-8?B?SmV4YTNaamEzZkUyVWk2b3lVTjBMbDVLTXBldjBreit5RTd4eXZKdy92bFpD?= =?utf-8?B?Ylh0RDhqNFI1VW4ySEFHMTFYdXZxVkpKeHNhT2VQWWlFaDNaYTNwVGJGbGJl?= =?utf-8?B?VURrRDFkRS95aW5mYktsWUk3T0pxSnlHeHNVbWZpWFh4Q2RhMjV1YXVrMEVS?= =?utf-8?B?b3ZCQmkyMlpyTmlSV1JiUzdSbHpSdUZzTjliRXBzaEhPeEN0OFQ0TEc2aXgy?= =?utf-8?B?ZEQyTFQ1MG5FaHFYaUxOZnhlNmRQM09VL1J1U3lhcDdnaitKYStzMjRacExz?= =?utf-8?Q?xhN0/o9zdqSgpx7d046wir8bv?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6bf8064-4636-42dc-ca97-08dae4d2a390 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Dec 2022 10:44:16.6973 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gI9athHaeE/9x/mhZz4T5AKiowEiuu4vZe9ijggg4yCq6z4ZPv+DyNjB7RK+/Coi X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6974 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/21/2022 2:52 AM, Jesna K E wrote: > +/* Takes ethdev as parameter > + * Used in dev_start by primary process and then > + * in dev_init by secondary process when attaching to an existing ethdev. > + */ > +void > +axgbe_set_tx_function(struct rte_eth_dev *dev) > +{ > + struct axgbe_port *pdata = dev->data->dev_private; > + struct axgbe_tx_queue *txq = dev->data->tx_queues[0]; > + > + if (pdata->multi_segs_tx) > + dev->tx_pkt_burst = &axgbe_xmit_pkts_seg; > +#ifdef RTE_ARCH_X86 > + if (!txq->vector_disable && > + rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_128) > + dev->tx_pkt_burst = &axgbe_xmit_pkts_vec; > +#else > + dev->tx_pkt_burst = &axgbe_xmit_pkts; > +#endif > +} 'txq' is used only for 'RTE_ARCH_X86', that is why it gives "unused variable" warning for it. Can you please declare 'txq' within 'RTE_ARCH_X86' macro?