From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65D6AA0C41; Thu, 30 Sep 2021 14:08:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E0164410E5; Thu, 30 Sep 2021 14:08:32 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id E67B34067E; Thu, 30 Sep 2021 14:08:30 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10122"; a="224826630" X-IronPort-AV: E=Sophos;i="5.85,336,1624345200"; d="scan'208";a="224826630" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2021 05:08:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,336,1624345200"; d="scan'208";a="487301002" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga008.jf.intel.com with ESMTP; 30 Sep 2021 05:08:29 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 30 Sep 2021 05:08:28 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 30 Sep 2021 05:08:28 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 30 Sep 2021 05:08:28 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 30 Sep 2021 05:08:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ooc4nXV1Yg0p0fjmF2pcLHruEaigvtxzEILFICGGenMkLqN2taYzlpOPMLUzXUanQbNBg8ZygYExMPqf80NqSDBeAZEmXmH8/jiLffqHz3sr8BOgXvRCDjTI+E6SJFWD1yGDinY3lCwJOpXzIFIyxcnRaYPYp64lP1oYUCcmbV8Nac9LA9Y/5n1bJszwCjhocj+CfVASLUY7vmDivB3cOaTvGH4gTSFOsyQy/kJ7tGza4CTJ/cQmVFPr6Fecsv0ogtRZEyOL+d7k3KaGmER5iQqmWbx4+rS65Q9EMBnSVZIAyUvOf2b5nipFmdhAHOxB2AezvQStdfBQFlNz4vO47A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=82EvQYcSUYR+Hrrwgcqbl7K1EvNTcZd/c1NpUGtUxqk=; b=L1drZdTL6cCxHXyZbtpu6ImkKYgFZw/8/qnPDNP1AGe6QX7WTvG/P0KMgIISBM9nfDk5fteHt13AZoXI6MNclY0IadEqwXSBGKknrjIgvDpciKc4Or25r3T/yu6lvfUrD4T48aUPUiGGiFn4wEFowvRHRC34iOMkoZNzoCLV+5YiBkTNZcNhoR2TzUx5PZHEvflD7/nhJzZwCzA3mcNdV/QUWy5yaal9sTBI4XCZXguxqLH21GEHIGHok4s6bmYuzEM25a+8vL2wN0f0cJpZf7F7HS7A/BkjjABBG98fwNdz32WiAeFPqmeTiPd3Jgm65qaDxWdJo2dWuDxb5kTPlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=82EvQYcSUYR+Hrrwgcqbl7K1EvNTcZd/c1NpUGtUxqk=; b=cRcrr1RgNYd7oeUhHCsNoxtjo7zyemXNsx/a1oRchfS8FvWGb6EK4N+BJ1wblINUQdBsaSO+HztnYP8vhbmXRCS7Ch1ILAw1Q8w5xFMPZx9kKOMnk6EdznRJReXukurjAmpNZ+3GOn/QGrl1Kk6FLtgcdduzs0aebH5WirqLT/I= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4838.namprd11.prod.outlook.com (2603:10b6:510:40::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13; Thu, 30 Sep 2021 12:08:26 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4544.021; Thu, 30 Sep 2021 12:08:26 +0000 To: Andrew Rybchenko , Thomas Monjalon CC: , Olivier Matz , Ivan Ilchenko , , Andy Moreton , Kuba Kozak References: <20210604144225.287678-1-andrew.rybchenko@oktetlabs.ru> <20210928120533.834334-1-andrew.rybchenko@oktetlabs.ru> <20210928120533.834334-2-andrew.rybchenko@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy Message-ID: <5e9f39eb-d859-0c4a-8eb7-1c9f494364a0@intel.com> Date: Thu, 30 Sep 2021 13:08:19 +0100 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6PR0601CA0036.eurprd06.prod.outlook.com (2603:10a6:4:17::22) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0601CA0036.eurprd06.prod.outlook.com (2603:10a6:4:17::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Thu, 30 Sep 2021 12:08:24 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 81404f3c-4f46-4490-1b63-08d9840b019f X-MS-TrafficTypeDiagnostic: PH0PR11MB4838: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1388; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wIHdYpRwvf/ZxDVscNj+1VqvFjU72U0hYxCUMlNsYAj6Ss8oj+PYxLwcZ05vYiK3cznTqhfHTgZNAbB9Pk4Eu/ZDo2Gjlo+iuW1A9MqA7J6/l6Xi4Ey0nJ0zqwvWjpeyytfqftSh8Q4KJBaLw4XvP3n4Nj+EuWmADw3UnxvsNnHXiBE7KVtvvb5kY6XDEPgzZDDZdMM9Xj1MDr7H+KFKnXE+7N4CWBUe/X3XnhTjA3ZIuyxeXbozt3bJXS/wPMCfcIfP7+a8/bmZUUsJTT6AxMpPjYKMxiLbtd97YjjanUwPMuPyH3JiSCB0jvCXB73shvl98+hlYGCrqxuJEAMA4TWbIvUjzkkTJFGaJfgHja1DN2nMDs+VblmyvWp5T5kg9Vk+77aXG+2je5N/l7tL13JUaK83V7vEYp6ZApDePSw5abPW1EoY2veJ0QLwyFKsO9Z125YlODfM0wna/YN5rTCXppZBRsVTThnCWoL6cKedrd44veAtDa8ejfjXbteV/K/CPbHCklt9TKhbf5swx3pYJb6ZsybUixRSfazqwK9/2X4zvxFNVlQe9pq6UdpQ2PFgRncwYZYxkT/CPDZigXLiZhWxYEjtXGkl46seoDrAyulX6ofv6EeD2xODms48yYD2fxe29vjwqp35ASrn/61qIDmzJyJGA+n1HkwTu0I20Zmq0iFYsSr/AsKbT/6YOD6LgfQ0bWCfexk6zjVAUg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(508600001)(44832011)(31696002)(16576012)(316002)(4326008)(2906002)(86362001)(54906003)(110136005)(8676002)(66476007)(186003)(8936002)(26005)(66946007)(956004)(6486002)(2616005)(66556008)(6666004)(83380400001)(31686004)(36756003)(38100700002)(53546011)(107886003)(5660300002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N0V0NmJwa2tNcmtuZndsMEt5aEUyZk8wK0xHdXVjLyt0ZGpiNkhvNGNSWEU4?= =?utf-8?B?QVhNT01ld0dzM1ZaeW1iVnlWZHlwMGNhd0dYZ1Q5WDBWUmdKaDEzOWJ2QVoz?= =?utf-8?B?alFPaWYxZ0x5Ly9wMllZMlZrelMvTHo4eEZ5NElrUEFmbmlTbHVpQ0pXQlNX?= =?utf-8?B?SEI3cnFlbnU5MElGNlNHM2JoSVRwSXExMWtlRGJVWHF0NmozVTBnUEMzbzBZ?= =?utf-8?B?VjNRckk0d0IvSllZUHJqYnBYMjdUWjhGdkdXVHdTMUMxdjhZTG5mb3NpYnRE?= =?utf-8?B?M1pQVU1rSEZXTzFpZDVPUGthejlnbytaMU1RNmFQSnhPWkpjOERZajhFS1JE?= =?utf-8?B?VGlEcWt6TjArR2ttTEJldTc2Z0FKOHBhdWdTRWZqYmhlYWZCaTBPQzg0NEJx?= =?utf-8?B?T2o4QVlqZTFDK0FnYTRhOW9uNElmbnBrWXMrMFdVcHNkWldjN0dKUXVndjhI?= =?utf-8?B?aDRDb1Z6M1I2WkhBZ2lJYURyQjB5Z1hBT3FzcEY2ckJpZWlFNFlpTEx4T2pp?= =?utf-8?B?bEsvMkFUZXo1ZGhSeVArcW5oK3ltbW9PWmI2L0gyTXR4RlE3VEs1a2dOOStY?= =?utf-8?B?d1JhY08yVVh3VW5xVnFieCtTUERqMnN3Yjd5Z3lzcVBtY0NaRGUxNmVEN2xu?= =?utf-8?B?WTg1MVBYeEdPN1g5aEg4b01uNDFrQXMyQWY5ekNOWmpvSGp3NS9GMXNhWlgr?= =?utf-8?B?bDVraGszODNLWVNWM3FSdGhqaHF3cTg5NjBIWllRc0QxK3VsZjZOTkhyTm9F?= =?utf-8?B?WjF6Smd5bFNnaDd5aTNueTNFVU92Si95a3l1aUcrU0wrMWhWZ0tTZGpNOFN0?= =?utf-8?B?eWIzdHNCVnppRGxUUXJxcjlxSm85WitHeVRodm8xZ0FzcERvUGdSQ0U5d2Fa?= =?utf-8?B?SHVuaGZWZlVESDkxUTVtU1lIMm9vSUZwclJXejlXa003M012L3QxaTZ6TjN4?= =?utf-8?B?eWdxV0ZmYWt2VldZejQySlhFQ1dnbkd6dEVwSnhiYmZHYkhUQ0hvNGdBbTkx?= =?utf-8?B?WUFTMFc4TVRac3UrTVdZbVI4c1g4eGFPdlQ5MEN4Z1ZRbXJmU214QTViRkRI?= =?utf-8?B?WnhpR3FxTHdrWjNNVmlSRTBsdFE5RVQ5Z2VhYytwRmN6TGJUYUV6VjBSbDN3?= =?utf-8?B?SW1xcGc0UW5nbVJPd0praEh3ZyttdUpyTVpFM0x3NFZwYkRMYktrbnRPc1BU?= =?utf-8?B?VnZrZEtucHBIQ3c1U3BNRGdSTmlQRmpuTjEzRUwwTE1TY0FiVFlIM2RxUEts?= =?utf-8?B?dVZUSEJwczVWSWlhVTFvR3pNTlE1cGJWN01RNlRmcS9mdEtuSjZpWWFoSEQv?= =?utf-8?B?QjFaWU40Q3NMVXhqeFlNYzZoMVBCQnZva0UreHZUd0FwUmV5YkJkMUUxRU5n?= =?utf-8?B?TVJSbEV3US9BbmdvWXVFbzQ3alU3Y1k5eDFSY1ZIM0owV011TllrQVZNZnVZ?= =?utf-8?B?SWNSY3kxVzdLN3NzVzIrejhVZ0pFYWZHb0ZBT1JFc0RkdGtSbS90aXAwMGZy?= =?utf-8?B?M3lIYkdyYnhYamJxWDRGb2VueTZRblZ5anNOTWZVY2l1dVBzaHNMT254bWFI?= =?utf-8?B?UDBwS0psY3BUQklNeTFmOVl1RDZkdUdOa0JnZlBCM1Z2TjB6anFLUHpMYXox?= =?utf-8?B?QWRJQ0JsT3VSZVBtNVpCZjl5Q2hTRW56U3laYnM1cEFxbXpVd09GcnlpbzQr?= =?utf-8?B?WDBMRlBheHVUWU90ZURJOGpiZkVZazRNV0pwVnZPMkI5dWZNekE3Tk5YdVZR?= =?utf-8?Q?nXks7VWzOF1uyKY/rTwRmFahbBbMmCHeeIc5QVU?= X-MS-Exchange-CrossTenant-Network-Message-Id: 81404f3c-4f46-4490-1b63-08d9840b019f X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2021 12:08:25.8965 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sLEnD0SMdHQWCxeAfuUflZS26zgdrBxCrk7Exe7NNWuH7If75GC9jwFon+QWXVa9NouvgLMbFNGR/R3WV0ZgXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4838 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v5 2/2] ethdev: fix docs of drivers callbacks getting xstats by IDs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/29/2021 12:54 PM, Andrew Rybchenko wrote: > On 9/29/21 11:44 AM, Ferruh Yigit wrote: >> On 9/28/2021 5:53 PM, Andrew Rybchenko wrote: >>> On 9/28/21 7:50 PM, Ferruh Yigit wrote: >>>> On 9/28/2021 1:05 PM, Andrew Rybchenko wrote: >>>>> From: Ivan Ilchenko >>>>> >>>>> Update xstats by IDs callbacks documentation in accordance with >>>>> ethdev usage of these callbacks. Document valid combinations of >>>>> input arguments to make driver implementation simpler. >>>>> >>>>> Fixes: 79c913a42f0 ("ethdev: retrieve xstats by ID") >>>>> Cc: stable@dpdk.org >>>>> >>>>> Signed-off-by: Ivan Ilchenko >>>>> Signed-off-by: Andrew Rybchenko >>>>> Reviewed-by: Andy Moreton >>>>> --- >>>>> lib/ethdev/ethdev_driver.h | 42 ++++++++++++++++++++++++++++++++++++-- >>>>> 1 file changed, 40 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/lib/ethdev/ethdev_driver.h b/lib/ethdev/ethdev_driver.h >>>>> index 40e474aa7e..c89eefcc42 100644 >>>>> --- a/lib/ethdev/ethdev_driver.h >>>>> +++ b/lib/ethdev/ethdev_driver.h >>>>> @@ -187,11 +187,28 @@ typedef int (*eth_xstats_get_t)(struct rte_eth_dev *dev, >>>>> struct rte_eth_xstat *stats, unsigned int n); >>>>> /**< @internal Get extended stats of an Ethernet device. */ >>>>> >>>>> +/** >>>>> + * @internal >>>>> + * Get extended stats of an Ethernet device. >>>>> + * >>>>> + * @param dev >>>>> + * ethdev handle of port. >>>>> + * @param ids >>>>> + * IDs array to retrieve specific statistics. Must not be NULL. >>>>> + * @param values >>>>> + * A pointer to a table to be filled with device statistics values. >>>>> + * Must not be NULL. >>>>> + * @param n >>>>> + * Element count in @p ids and @p values. >>>>> + * >>>>> + * @return >>>>> + * - A number of filled in stats. >>>>> + * - A negative value on error. >>>>> + */ >>>>> typedef int (*eth_xstats_get_by_id_t)(struct rte_eth_dev *dev, >>>>> const uint64_t *ids, >>>>> uint64_t *values, >>>>> unsigned int n); >>>>> -/**< @internal Get extended stats of an Ethernet device. */ >>>>> >>>>> /** >>>>> * @internal >>>>> @@ -218,10 +235,31 @@ typedef int (*eth_xstats_get_names_t)(struct rte_eth_dev *dev, >>>>> struct rte_eth_xstat_name *xstats_names, unsigned int size); >>>>> /**< @internal Get names of extended stats of an Ethernet device. */ >>>>> >>>>> +/** >>>>> + * @internal >>>>> + * Get names of extended stats of an Ethernet device. >>>>> + * For name count, set @p xstats_names and @p ids to NULL. >>>> >>>> Why limiting this behavior to 'xstats_get_names_by_id'? >>>> >>>> Internally 'xstats_get_names_by_id' is used to get the count, but I think this >>>> is not intentionally selected, just one of the xstats_*_by_id dev_ops used. >>>> >>>> I think it is confusing to have this support for one of the '_by_id' dev_ops but >>>> not for other. Why not require both to support returning 'count'? >>> >>> Simply because it is dead code. There is no point to require >>> from driver to have dead code. >>> >> >> Let me step back a little, both ethdev APIs can be used to return xstats count >> by providing 'values/names' & 'ids' pointers as NULL and 'size' as 0: >> 'rte_eth_xstats_get_names_by_id()' >> 'rte_eth_xstats_get_by_id()' >> >> But internally both APIs use 'xstats_get_names_by_id' dev_ops to get the count, >> as said above I believe this selection is done unintentionally. >> >> >> I am for below two options: >> >> a) Internally use 'xstats_get_names' || 'xstats_get' dev_ops to get the xstats >> count, and doesn't support getting xstats count for both '_by_id' dev_ops, this >> simplifies driver code. As far as I remember I suggested this before, still I >> prefer this one. >> >> b) If we will support getting xstats count from '_by_id' dev_ops, I think both >> should support it, to not make it more complex to figure out which one support >> what. As sample both 'xstats_get_names' and 'xstats_get' supports getting xstats >> count, not just one. >> > > In (b) do you suggest to change ethdev to use xstats_get_by_id > driver op if users asks for a number of xstats using > rte_eth_xstats_get_by_id()? It will complicate ethdev and > will complicate drivers. Just for the symmetry? > Not just for symmetry, but simplify the logic. Both dev_ops are very similar and they are having different behavior with same parameters is confusing. If you want to simplify the drivers why not go with option (a)? Option (a) also doesn't change external API, and has only minor change in the ethdev layer. > The patch does not change external API, does not change etcdev > bahaviour. It just clarify requirements on driver ops to > allow to check less in all drivers and support less cases > in all drivers. > It is not clarifying the requirements of dev_ops, but changing it. Previously there was nothing saying only one of the '_by_id' dev_ops should support returning element count. > If we make a one more step back, frankly speaking I think we > have too many functions to retrieve statistics. I can > understand from ethdev API point of view taking API stability > into account etc. But why do we have so many complicated > driver callbacks? > > First of all I'd like to do one more cleanup: > change eth_xstats_get_names_by_id_t prototype to > have ids before xstats_names. > I.e. eth_xstats_get_by_id_t(dev, ids, values, size) > eth_xstats_get_names_by_id_t(dev, ids, names, size) > +1 > Second, merge eth_xstats_get_names_t and eth_xstats_get_names_by_id_t > callbacks to keep > name of the first, but prototype from the second. > The reason is equal functionality if ids==NULL, > shorter name of the first and optional ids (i.e. no > reason to mention optional parameter in name). > Drivers which do not implement by_id_t, > but implement eth_xstats_get_names_t, will simply > return ENOTSUP if ids!=NULL. > No objection, _by_id() version is already superset of the other. > The case of values ops is more complicated, > however since: > > 2834 * There is an assumption that 'xstat_names' and 'xstats' arrays > are matched > 2835 * by array index: > 2836 * xstats_names[i].name => xstats[i].value > 2837 * > 2838 * And the array index is same with id field of 'struct rte_eth_xstat': > 2839 * xstats[i].id == i > 2840 * > 2841 * This assumption makes key-value pair matching less flexible but > simpler. > > we can switch to eth_xstats_get_by_id_t only callback as > well and fill in stats->id equal to index on ethdev layer. When ids != NULL, the index from 'ids' can be used, isn't it. > However, it will require extra buffer for > uint64_t *values and copying in the rte_eth_xstats_get() > implementation. So, I doubt in this case. > Overall merging xstats _by_id APIs doesn't look bad idea, but since it will require change in applications, I am not really sure if benefit worth the trouble it brings to users. > In fact, it is sad that we still do not move forward > in accordance with Thomas presentation made 2 years ago. > In my experience things don't move forward without proper plan (who, what, when).