From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6993A0C43; Mon, 18 Oct 2021 10:56:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8E4FA40141; Mon, 18 Oct 2021 10:56:23 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 92A9A4003C for ; Mon, 18 Oct 2021 10:56:22 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 31F5D7F504; Mon, 18 Oct 2021 11:56:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 31F5D7F504 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1634547382; bh=2Ri61BKyi1V3yJtXK0le1giepH61laXOJ93CejqUgg0=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=QatQTWtvovZh+6H+BJTIL6oa6idU8eSI1HFkTGmjcuKRvF/5NFIpNGW011Gkof2mQ BaAu+fRJUKiH4khiRXdvqV7jZzH1ZzI0gbFE76wW7v3qR7Gi/CUC7dJPu+jmoe0Qtw 1E34d04E0LoFAU/48MRRH9WGXlscW8p1T5hdO2po= To: Dmitry Kozlyuk , dev@dpdk.org Cc: Ori Kam , Thomas Monjalon , Ferruh Yigit References: <20211005005216.2427489-1-dkozlyuk@nvidia.com> <20211015161822.3099818-1-dkozlyuk@nvidia.com> <20211015161822.3099818-2-dkozlyuk@nvidia.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <5ec7101f-169e-cbd0-87bb-810b7476c7d0@oktetlabs.ru> Date: Mon, 18 Oct 2021 11:56:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211015161822.3099818-2-dkozlyuk@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/5] ethdev: add capability to keep flow rules on restart X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/15/21 7:18 PM, Dmitry Kozlyuk wrote: > Currently, it is not specified what happens to the flow rules when > the device is stopped, possibly reconfigured, then started. > If flow rules were kept, it could be convenient for application > developers, because they wouldn't need to save and restore them. > However, due to the number of flows and possible creation rate it is > impractical to save all flow rules in DPDK layer. This means that flow > rules persistence really depends on whether PMD and HW can implement it > efficiently. It can also be limited by the rule item and action types, > and its attributes transfer bit, which together comprise the rule kind. > > Add a device capability bit for PMDs that can keep at least some > of the flow rules across restart. Without this capability behavior > is still unspecified, which is now explicitly stated. > Declare that the application can test for persitence of flow rules > of a particular kind by attempting to create a rule of that kind > when the device is stopped and checking for the specific error. stopped -> configured but not yet started > This is logical because if the PMD can to create the flow rule can to -> can > when the device is not started and use it after the start happens, > it is natural that it can move its internal flow rule object > to the same state when the device is stopped and restore the state > when the device is started. > > If the device is being reconfigured in a way that is incompatible with > existing flow rules, PMD is required to report an error. > This is mandatory, because flow API does not supply users with > capabilities, so this is the only way for a user to learn that > configuration is invalid. For example, if queue count changes and the > action of a flow rule specifies queues that are going away, the user > must update or remove the flow rule before removing the queues. > > Signed-off-by: Dmitry Kozlyuk > --- > doc/guides/prog_guide/rte_flow.rst | 27 +++++++++++++++++++++++++++ > lib/ethdev/rte_ethdev.h | 7 +++++++ > lib/ethdev/rte_flow.h | 1 + > 3 files changed, 35 insertions(+) > > diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst > index 2b42d5ec8c..b0ced4209b 100644 > --- a/doc/guides/prog_guide/rte_flow.rst > +++ b/doc/guides/prog_guide/rte_flow.rst > @@ -87,6 +87,33 @@ To avoid resource leaks on the PMD side, handles must be explicitly > destroyed by the application before releasing associated resources such as > queues and ports. > > +By default it is unspecified if the flow rules persist after the device stop. or can be created before the first device start > +If ``RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP`` is not advertised, > +then rules must be explicitly flushed before stopping the device > +if the application needs to ensure they are removed. > +If it is advertised, this means the PMD can keep at least some rules > +across the device stop and start with possible reconfiguration in between. > +However, it may be only supported for some kinds of rules. > +The kind is a combination of the following rule properties: > + > +- the sequence of item types; > +- the sequence of action types; > +- the value of the transfer attribute. > + > +To test if a particular kind of rules is kept, the application must try > +to create a valid rule of that kind when the device is stopped > +(after it has been configured or started previously). > +If it succeeds, all rules of the same kind are kept at the device stop. > +If it fails with an error of type ``RTE_FLOW_ERROR_TYPE_STATE``, > +rules of this kind are flushed when the device is stopped. > +Rules of a kept kind that are created when the device is stopped, including > +the rules created for the test, will be kept after the device is started. It must be defined what application should expect for not tested rule kinds. For me about check sounds extremely complicated and hardly doable. Yes, some applications know kinds of rule it would like to create, but some, like OvS, do not. Please, correct me if I'm wrong. OvS knows which types of actions and even possible combinations of actions (harder, but still possible) it would like to install. But all possible combinations of items together with all possible combinations of actions could be very-very big. May be I still misunderstand the above idea. > +Some configuration changes may be incompatible with existing rules. > +In this case ``rte_eth_dev_configure()``, ``rte_eth_rx/tx_queue_setup()``, > +and/or ``rte_eth_dev_start()`` will fail with a log message from the PMD that > +should be similar to the one that would be emitted by ``rte_flow_create()`` > +if an attempt was made to create the offending rule with the new configuration. > + > The following sections cover: > > - **Attributes** (represented by ``struct rte_flow_attr``): properties of a > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > index 6d80514ba7..a0b388bb25 100644 > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -90,6 +90,11 @@ > * - flow director filtering mode (but not filtering rules) > * - NIC queue statistics mappings > * > + * The following configuration may be retained or not > + * depending on the device capabilities: > + * > + * - flow rules > + * > * Any other configuration will not be stored and will need to be re-entered > * before a call to rte_eth_dev_start(). > * > @@ -1445,6 +1450,8 @@ struct rte_eth_conf { > #define RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP 0x00000001 > /** Device supports Tx queue setup after device started. */ > #define RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP 0x00000002 > +/** Device supports keeping flow rules across restart. */ > +#define RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP 0x00000004 > /**@}*/ > > /* > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h > index a89945061a..aa0182d021 100644 > --- a/lib/ethdev/rte_flow.h > +++ b/lib/ethdev/rte_flow.h > @@ -3344,6 +3344,7 @@ enum rte_flow_error_type { > RTE_FLOW_ERROR_TYPE_ACTION_NUM, /**< Number of actions. */ > RTE_FLOW_ERROR_TYPE_ACTION_CONF, /**< Action configuration. */ > RTE_FLOW_ERROR_TYPE_ACTION, /**< Specific action. */ > + RTE_FLOW_ERROR_TYPE_STATE, /**< Current device state. */ > }; > > /** >