From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC06CA0C43; Mon, 15 Nov 2021 11:23:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 505C740E25; Mon, 15 Nov 2021 11:23:55 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id EF6AD40141 for ; Mon, 15 Nov 2021 11:23:52 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10168"; a="214139323" X-IronPort-AV: E=Sophos;i="5.87,236,1631602800"; d="scan'208";a="214139323" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2021 02:23:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,236,1631602800"; d="scan'208";a="505861661" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga008.jf.intel.com with ESMTP; 15 Nov 2021 02:23:51 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 15 Nov 2021 02:23:51 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 15 Nov 2021 02:23:50 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 15 Nov 2021 02:23:50 -0800 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.48) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 15 Nov 2021 02:23:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P6P38zGRa6zM8ozUjsRUOrDqIMF5X4tGxgfYoroO3aeXdVSzUFA4MGjK9wfQlvVSBksxX3Z1v3ELFkg8AdQnVYMG2kJ0yHtg9LsWyvOfeA2c/kzLeMJUgHb/qoGme6OTbL063sfzwD9sz3YJ1oSd8yLlO3aAqVTY1fiV2jTUOQ8fkfYQKUwibHwDI9GjQYMFZwJjA+5+xpHFR8NUBfwUY9LwuFi3Fj+CP1nrnggcZpLI0Bu5yJ0j3FGDvaLKqUnk5IJxYn/q6z9VUVpykw7jt+RpWkSdC1ni5iRrJAaFVskSs6gXt1Flh++Go9t4X8l0sqNugXm6oH81u7EKWGex/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sSunYw3y59PK5IDHO64JKvzDxsj0yX9HEuac1CrmGqU=; b=oZFhE7ZEphb9UXZbSLonK91mKFtRlVyF85oNbK072MpqU84Llvh1ecmBN/t2sU/GiWfzkYbu6rhXaUDD+kLsJY/asdJTMAGn9v6/WQp+JMf8uQVflu9PrZfcXJcYCFL/xDeHePHp/fqPHLM+KOA8S+OmEwInN8Q3xAiPKS8Mme72lEK+Zfa16RwtJct8qV2YA3ac7zYaRm7vywG/2EEOW22+fs9DQwn+yfaoi9Oi23gNK4bIqaERc0p6xTPqkWekeUnoAX7vd32qohyhh2KIKckXznHGy6DBliSJTcpunZm6Ur/6gtKPPbn0j1pvSyUyNzoVcxxKAJTb004KJFV1Gg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sSunYw3y59PK5IDHO64JKvzDxsj0yX9HEuac1CrmGqU=; b=VCGDwwuwEUWq5IXgrEgd4nTEF15Kl3Z6+Wf1K4VVN8KT/ATHejq/XazkjraSezkc6BSqzyvWYRe3Y8FhjsFfM88TgJOCYjf93dBDEr7wUhJBt38r6uoyCePVMHpNTSyDsk/Db4SOKMhR7HHnQPLtSzRrsst8sH33dWB3Q8YVDUU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5046.namprd11.prod.outlook.com (2603:10b6:510:3b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.25; Mon, 15 Nov 2021 10:23:48 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c%5]) with mapi id 15.20.4690.027; Mon, 15 Nov 2021 10:23:48 +0000 Message-ID: <5eea58ba-a5f6-76f2-f6fa-c3ceace62937@intel.com> Date: Mon, 15 Nov 2021 10:23:43 +0000 Content-Language: en-US From: Ferruh Yigit To: Apeksha Gupta , , CC: , , References: <20211109113432.11876-6-apeksha.gupta@nxp.com> <20211110074829.16654-1-apeksha.gupta@nxp.com> <20211110074829.16654-4-apeksha.gupta@nxp.com> Subject: Re: [PATCH v9 3/5] net/enetfec: support queue configuration X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB3PR08CA0027.eurprd08.prod.outlook.com (2603:10a6:8::40) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB3PR08CA0027.eurprd08.prod.outlook.com (2603:10a6:8::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.26 via Frontend Transport; Mon, 15 Nov 2021 10:23:47 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e75a496d-6da8-4359-283d-08d9a8220310 X-MS-TrafficTypeDiagnostic: PH0PR11MB5046: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3H1LSxvJws8b2p6Yb4EZ95XsYauhUWCU0wNzx3Fw2fPU9TbJrSG1asLW2a1C3uqHg1Y21fT53aeEzT90bCTefNPhUrV4kBBlm1tUNz0kQBsSWJpj9346m3AfK9m+bLD4reZsJpl3myaJjCVTNUU6gKLfyXw7ORFBrcMNNnQled58QNobfyrPA6IupRJdnl1Ym9Fr3BvXzdvKKNAJO/uIjI5hdUN2rKS/kdgePN4lE5c89QfC+KVYD/pkE+3fYc8vUjKChhVuc/uFvbcqyvWl0ZdiZadjArj65/AzfgsipmL76ercbAwMQUmm540kxC4A2YKWjgu1iTBkBKbgELpXW+58X+6gfPw/MFjLeSlZltDUSr4YHXIcIB4YkUcYXQW1HATlP/8whlbIfB3XI6T+c1vqjJc+3FjqjZiaVdaPFK3FowyjMkbFydaYOU8960ElBz+v7v0ZOvoVu7agoduU2YqfW/QqvvRur65JcIfiZpGCYKUbjpzGzxeHOWLA0AT0bFqp7iIyjX0uvZtMIQg39gcCcg1IlHp6t7GIHw6SPao251myF1pmesOYKNgGlX8lfKm69KKxK08pcumnjvv+IMTeVaQXEE54YH/dltzS58D3yptWBZzZI8JWXGSCRN281eRm11jOQKdU7k5PTKgWDloV3UqVWf3Ld+QxNfnaiFWoOtu7AEsheUWlzlitOq0yp03WE4cUGlIObK3dD2lrnQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(84040400005)(186003)(2906002)(8936002)(66946007)(6486002)(38100700002)(36756003)(5660300002)(956004)(66476007)(66556008)(6666004)(316002)(2616005)(4326008)(44832011)(508600001)(83380400001)(31686004)(16576012)(8676002)(31696002)(53546011)(86362001)(26005)(82960400001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b1o5bmZpRzJkOTRwcU5vcVZBZTJVL2ZIOXpubE1YVzhGZ29RU01ueWdtVjJI?= =?utf-8?B?dHJLenNjTk1NR3dvc3dNaFNPaWdzZDdicXFZKzBIV1NVWFRMd3R0TnB3RVVo?= =?utf-8?B?NjUxZmp4WXBlODVTd1Nta0MyQTNML3VqZEN5K0pxNDFsSlpOMEtBSSt2OVZ4?= =?utf-8?B?NXZKN0J5Um9jTVdNbjBWZjhBSitRVzhUY1RSMmxVQ0xvb2IrNXdSa0tSdEtH?= =?utf-8?B?YVFhWlJMTnlWTUJuWUZwTG9Eb3NjbC9NblByRUh0cS9zNlBuY3hwWUU0bW1O?= =?utf-8?B?dTJwZEcyNVI3N3gvajhNV3dxeXVMMFllUGFkeXFIVVg2Q3JwSTE1SCtYNXZq?= =?utf-8?B?dW9aQjJtSjE3a3JnQTg1L0dMVnp0eit6L0JGWElDaERpZGJLMXBmZXo3bmd5?= =?utf-8?B?dWJPKy9lZ0ZXVmpxdFZmS1hocmprUDJra0NGQlNYNW1rUTRsRkFKMHdKbzZ4?= =?utf-8?B?VmoxejRDcGpTamRGejNhZzdDOHZ2TFczcFdkM0ExMEVoZWtIdmY2YzdPRGJi?= =?utf-8?B?V2M0L0VRcmtKcmtzYmx0OGZ6SXJEcVRVd3Q4NnpWMEFkT290UGFUSDMveHRS?= =?utf-8?B?cHF5YlNzUTc3WjcrWlEwQTBhUXlZb0F5L0pXc1ZBZ08zWlJSVTlhSzVNZ2VQ?= =?utf-8?B?N3dLdHFVTzBRVnBPQysyQkxWUytkcWtaRGhvcjJiZnRkckl4akdtUTJncUt5?= =?utf-8?B?R0R2VEkvNGlWZFpqeTBMdmdZMkZId01GWVk4S2FBOXVFUk95TWpudWxzdVRy?= =?utf-8?B?NHBqZ01qNTl6WUxvbjBwaDhxMjllRXk0Z3phamRJem44ZFZnSGw1Z3l4TVVl?= =?utf-8?B?L3Uyc3ZDdkVDUUUyT2RrS2M5U0FoWXVrMklvTU9UWGpaMGUvdzNwbno3cWNs?= =?utf-8?B?Uy9RL1c0MUwzcUtITmxxVDVUS2hlRGlPdWdPT2EvVVpjeU5YWlRCU2svUW95?= =?utf-8?B?TElpdTFMbENDQmhxRHdQUy9zS1M1SWpYTStjRDhQbjBQbS9OSE1Sa01Bcmt2?= =?utf-8?B?aGVYd3hUbi8yenNydXM1eXlEQTBrbDJlMVIrbDQ1cEpBODRHYldDZ3RiQUVx?= =?utf-8?B?RzNDb2VQUUo2LzRaSVpiZTdVekw0SUg5VnBEUmxkQ0VJWG9oeFI3VnRYbjJ2?= =?utf-8?B?Tm1LanRmYmlTMCtGYjhyQlRGM1UwRkducWtzTTNqVE1QR0dEc2VIcFpteDB3?= =?utf-8?B?aG94SUN6bVV4SnkrMUlsRGdiWHdON2laNFRVWXUyRVFrQzAveStSSmJxRlRR?= =?utf-8?B?YUI5cTdYeFYyU2RNQ2syd1Z2UEIzUGx5OURUNEluMVJGdldMMFljRlJubHp3?= =?utf-8?B?SiswWEIwS0R4b1JmWFQyN0I1di9UaEJRK2hoTXlHVzdSTmNVSEN6VTg1Wmp6?= =?utf-8?B?VFpndW9LSksvbHdMSjNWUW5qMWM3dnNRQXRCS2lNaGNnLzRJSU5WbUlid0tU?= =?utf-8?B?aXZabW1ZMEwwWmFkUVdMakh5UjJYN3RBT2h3ZG1KRG1KeHlNYTFXV3NGMHQy?= =?utf-8?B?VGcrQ2FyVlg0MElZYTdmczM3RWhWQUlaT3g1bDV3eXY5VE14NDg3aHp4aW0v?= =?utf-8?B?QzhlRzc5VkIreU5WalE3MlIwM0c1SHNHbWJpekpScVp3ZHp6WGF5ZnBTa3p6?= =?utf-8?B?bkRvaHIvK0ZheEJTSndqVXhzZWZHU1VjN0RNaU52bUJwckJBUUNtWnZxS082?= =?utf-8?B?RlRNQy9QK1lYYWU2bHVNa2VIR0V1RE1weU1iVXgxNnkrbkExbUlSNExFUFBR?= =?utf-8?B?L0d6c1pZQ0lpYVZ1cVYrWDRZSERaWVk5anhiZWlsSkhIdmZHT1NTWUpkazdh?= =?utf-8?B?SldwOXd2Z2JCeHF6b2xycEFNVEJwZFVtNWJHamU3Ulh0VDYwUU8xREZDNHMy?= =?utf-8?B?N3VSajhjZGxQUG1qRXFKSHZOZGhRK2htTVRPeDJWUlRmTytoZVhOSTF2T21F?= =?utf-8?B?QnJub29lQUQxendpaGdSV2ViaWRHS1BZZXh0V1JxQTB5SVhNdUpqWWd5cmdE?= =?utf-8?B?VUJSb2pTMkxhRHphV0dubkV5cVFDYWJEL2s1M0dVZnlBbFJaTUVBY3JhTk5M?= =?utf-8?B?QWVNcmxUeWZJSGdBMWdEVi84am1wZHNXdGMzU2JxQzBXWE4xYXdnUXFMclFi?= =?utf-8?B?U0NBZEhaZE1LMm5SbmNHNGt2R05idU1RYXJQUFVKM09jNCtmWHlLQVdBVUJn?= =?utf-8?Q?oqIJMsCM2Y888zHQ45nzmK4=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: e75a496d-6da8-4359-283d-08d9a8220310 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2021 10:23:48.5660 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: O1K+GyPIgxvXuaWRL3KDfdQ3V4OqeewBU4gkCq8p5GCrW39YavxMf9oCj5SavVovFFi5mBR6EB6Ln9XfZch/zA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5046 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/15/2021 10:06 AM, Ferruh Yigit wrote: > On 11/10/2021 1:54 PM, Ferruh Yigit wrote: >> On 11/10/2021 7:48 AM, Apeksha Gupta wrote: >>> This patch adds Rx/Tx queue configuration setup operations. >>> On packet reception the respective BD Ring status bit is set >>> which is then used for packet processing. >>> >>> Signed-off-by: Sachin Saxena >>> Signed-off-by: Apeksha Gupta >> >> <...> >> >>> + >>> +    rte_write32(rte_cpu_to_le_32(fep->bd_addr_p_t[queue_idx]), >> >> Isn't 'fep->bd_addr_p_t[]' a 64-bit value? >> >> <...> >> >>> + >>> +    rte_write32(rte_cpu_to_le_32(fep->bd_addr_p_r[queue_idx]), >> >> Isn't 'fep->bd_addr_p_r[]' a 64-bit address, why doing endianness operation >> only on 32-bit and writing only 32-bit of it to register? > > Hi Apeksha, > > Above comments seems not addressed in v10 & v11, unfortunately this keep happening > in this set. > My bad, sorry. The variables seems updated as 'uint32_t' in the v10 & v11. So I am not sure about the reason of the below build error, can you help to understand it. > Above lines are causing a build error for gcc12, can you please check: > ../drivers/net/enetfec/enet_ethdev.c:482:9: error: array subscript 1 is above array bounds of ‘uint32_t[1]’ {aka ‘unsigned int[1]’} [-Werror=array-bounds] >   482 |         rte_write32(rte_cpu_to_le_32(fep->bd_addr_p_r[queue_idx]), >       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >   483 |                 (uint8_t *)fep->hw_baseaddr_v + ENETFEC_RD_START(queue_idx)); >       |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > In file included from ../drivers/net/enetfec/enet_ethdev.c:18: > ../drivers/net/enetfec/enet_ethdev.h:114:33: note: while referencing ‘bd_addr_p_r’ >   114 |         uint32_t                bd_addr_p_r[ENETFEC_MAX_Q]; >       |                                 ^~~~~~~~~~~ > ../drivers/net/enetfec/enet_ethdev.c:482:9: error: array subscript 2 is above array bounds of ‘uint32_t[1]’ {aka ‘unsigned int[1]’} [-Werror=array-bounds] >   482 |         rte_write32(rte_cpu_to_le_32(fep->bd_addr_p_r[queue_idx]), >       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >   483 |                 (uint8_t *)fep->hw_baseaddr_v + ENETFEC_RD_START(queue_idx)); >       |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > In file included from ../drivers/net/enetfec/enet_ethdev.c:18: > ../drivers/net/enetfec/enet_ethdev.h:114:33: note: while referencing ‘bd_addr_p_r’ >   114 |         uint32_t                bd_addr_p_r[ENETFEC_MAX_Q]; >       |                                 ^~~~~~~~~~~ > >