From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E8C0A0C43; Mon, 18 Oct 2021 13:16:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4E78A40142; Mon, 18 Oct 2021 13:16:12 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 7812E40141 for ; Mon, 18 Oct 2021 13:16:10 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10140"; a="228174382" X-IronPort-AV: E=Sophos;i="5.85,381,1624345200"; d="scan'208";a="228174382" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2021 04:16:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,381,1624345200"; d="scan'208";a="444016734" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga003.jf.intel.com with ESMTP; 18 Oct 2021 04:16:09 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 18 Oct 2021 04:16:09 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 18 Oct 2021 04:16:09 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 18 Oct 2021 04:16:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f2JzZW/vI15DutmEn0zt/n5u3h3wI2VgnJoNfg6CGrAAP72eYP7/avEogEs5sGO3L+pOAdClEh21Ff1HTSz7evtRnMKTTYTP57tfwXgpEQ47Yfks2Q/FZLXUlwqm2BOMcGN3TKtoX9JimT9ib5l3w76OlJ+jHt8axCGXlpJ1QuL7P8aVDDdJ+o53T0W2NbKTBbVTloJyon5hoKQg7laitmxJucjpT7mTnK8SIAeLqLm4PUjCC0BbsJzgUVvjYPktVK0aGdybYtIO9Ql0yZGxFWZKmiV/XsTfJo+3OuLWdQCWtC8S3cyde0CaXAo3+F29IZ7yCrjUSrpDOcOY3m2CkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9TiLAWZ4oZPp+rjPQJO2NQyS+FsoE4K5SxymqKXKmkw=; b=gzVt14JXW/+xbWKSn9bTazggxtfKLPanxuBkopJp0vKj2Aex/BtFAAlLeoDd1YsW404G8pizM5d2GDpD9OGIakiZF4n2PUmuVFi3o5mNdfdYJFfpwRSIpfxuPfoXO1Vy1eTolEEFsTsUqks7rB/8hPOZXQTjRNDGSah1GG//PZGzi5hS8vdv18XHONLZgXBE2cOmv1OM+FjR3I553VbB/4aMmfBlv0m9tQoX++8wcgGiSlzPOlAPnOllvwPHIPOAKtYzXYL0fddEY1Pogh4gQwTIRHx6+vO853jHpVNUwnIYGByXcyHx5Tft0zrLNHOpmeXx8KUY3ojw0vsJotnBGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9TiLAWZ4oZPp+rjPQJO2NQyS+FsoE4K5SxymqKXKmkw=; b=VmWUCaddkKlTq1rkpwTVF8a+myHifE4fef9FA6i9xtrPZO5R46EJVZRn3Npv5INMrO8/gDYHAZVLoBOPLjJcqN7KN95sNLTivwKfCimm4LV9RUqN8Jcr6E73EVjl/w4is//59EDEfgu9PApvCuR+C2sd8bAKR4FtL0q9OXUEyjw= Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4870.namprd11.prod.outlook.com (2603:10b6:510:34::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Mon, 18 Oct 2021 11:16:08 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021 11:16:08 +0000 Message-ID: <5f0c9b9e-6c15-eaaa-b015-1a88286c17fc@intel.com> Date: Mon, 18 Oct 2021 12:16:01 +0100 Content-Language: en-US To: David Marchand CC: John Daley , Hyong Youb Kim , Andrew Rybchenko , dev References: <20211015102819.4101559-1-ferruh.yigit@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR07CA0179.eurprd07.prod.outlook.com (2603:10a6:6:43::33) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR07CA0179.eurprd07.prod.outlook.com (2603:10a6:6:43::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.10 via Frontend Transport; Mon, 18 Oct 2021 11:16:06 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 50fedc5a-0a08-40b4-e22c-08d99228aebb X-MS-TrafficTypeDiagnostic: PH0PR11MB4870: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1uvy1VPFM3jVFD3EqgoDqQyRuHdjoNJUNapRxMpIjo9GR2Yevds9UJiUGabl8xTsKjpRXu1W1TnuEjianVh1AY95OjXz0gaBwuxK7C7eonlpHWU1oP7bzdYQtadcvMAQLZPThf1oxo6fZq/AJVN9gyqPLnkV44lxqmbC2sCfqBEGYnt3PpTgTRD+VVnDcVq/y6bcSVj+QsrSzXJGTgOd023zDtgWv2Rd0YJ43Et2MIzgQSY3nnMlErXg5w8vuMfltml22BnzDDOA11vggBNrX2of4/L7M2XHItcwxD7vPsIlLAMxR7UhTDV8DZJEQo3zqj/FsAmYcNzizyVLPd82NSo1YX51n7KUEOWqgGRI5ZhvwWvR4Bw3gogKSqocqVNP2qgPUt+1gkqpfsuGELERlL/Gk1J8s3KHmLMLrvzKWY5pPpPrBwHN84pqkdgh9ayN4iSDdN7aaMz+f7ygBISEerjL+pWfnpGe3gDa41E1UIKm7onK0kaZAoWbaxomYrcBdQ8IwBli7V5kdtRrotNU6dSURBme51HisOQciHf3ypaJJqOrYLc5QCTZm/BH8Ryk4hdu4NzZJGjYJV99+fg0XgxDMfdXaeexF8kf7bRO/nQEN14D5uyrbSR8E6IPKHKnsmtgQk87OUh4HT9Qn7Rv4GQUOBhIqfmK2JwVhZWnhcxcjKH3M42jY45wFdqvAKhB9Sb2HiD9WVzjOCz11+zS6Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(31686004)(66476007)(66556008)(508600001)(54906003)(5660300002)(82960400001)(16576012)(38100700002)(6486002)(26005)(86362001)(8936002)(6666004)(186003)(66946007)(316002)(36756003)(2906002)(8676002)(4326008)(2616005)(31696002)(956004)(53546011)(44832011)(6916009)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZnlXQ3E1SEpSTWNTSlAxcSs0WlhkbmdGSU10ZkI2SlpxRTEzK3hLUmpyZFBo?= =?utf-8?B?M1p3TXc0YXd5Nm5MRzVTU3lBdStqKzZOZTBpdlRIbFJOZU9VNmNvVFVjLzBv?= =?utf-8?B?WkdWMWJYNGRIa2Z1dFFRTmQ1T0Z2dlhrVTZJS1ppdjV0RkxkZ0ExMmhyYTNT?= =?utf-8?B?Ri82R3YzeXZ0U0MxT2tHKzZ1UlcxRnhnSndlL1NwT1NmeUEybU1CL3V0dWN3?= =?utf-8?B?OU5RbHlXaUFQT1JHY2RxTkorQ2tRSGVDVUJmY0EzTmdyblB0L3pUNWV6eXRY?= =?utf-8?B?eHh0b21zMTZWNm1Edk9CMEovNGQ0NFkvQ08yb29PVkNORDRndVVoM2Qybk9T?= =?utf-8?B?SUkrTEN5dHBGWkpVV2JzSlJXOFlqdXRrRmIyMFZuSkxleWlFMXp4cmg0MHpW?= =?utf-8?B?MG5JTjdiZDdMYStjcHR6TEVsNzJFNjY1S21ZTEIzcGdlNUdxdGpjcDZGU1Fs?= =?utf-8?B?azQzL2hPQ1FUR3pBejZEb2UzUHF1bmRWb01ZMWJ2MDI0ZU9JS3owZVF2Rkdq?= =?utf-8?B?RlBkZC9xT1JaOTltY3h4ZkFuTHVMREROaHE4UmVBeXJSL0dKZS9Jam4vMFdR?= =?utf-8?B?M3ZIbktJK3hzSEl4dUgvdmxrRlZFYm5ONWtXOUVyVXVoaDAzRmVZVDNVK3VM?= =?utf-8?B?cjNSN1FZdG1FM2Y2UkRBL0NpVC9JRVhmT1hUWFl0YmhPUjhpS2NzYkhQZ3Mx?= =?utf-8?B?T2wzVkJPSVh4M1VLUnpTV1VmNUtIYjdibklLeHg4RTlweFliL2x5WDAxK3ll?= =?utf-8?B?N1RtT2N5NFRRc01KN3dSVE15dmN5ZkNxTjhXc1B4WXdFT3E4bUNweDZLeHdl?= =?utf-8?B?TkpubDNiLzVubFpPQUU2Tk5qWHM3Sk1yTEhaQ0g1Ym01THJLYm5FUGNMbTN6?= =?utf-8?B?bXdKbVhXQXNVVDFCUzhZc0Z0WDM3V0NWUUhIRU4vd2V2NkFsMm9zRHdWbzRL?= =?utf-8?B?NHpSeitIRDNacXNQY1phUmdoTWpMT3ZQTjN3L1BlZUxqOVZUUkY5Sm5hZjFV?= =?utf-8?B?elpUdGlOTFdqdC82UDdkWEluamlNY2M2b1dFUzRBM2ZjbjNMNk5SdHk5Sm9U?= =?utf-8?B?TlBzVlI2bm5oU2R1OUl3YVhpUGU5NnlXemdxRk9sSHJuNHZxOHVxbDlyamRM?= =?utf-8?B?eWVwSzNpczNxL1pIbkFQVFFGcUZ0WThHU2V2a2dtbm5sYWNtUUd4OFc3SGcv?= =?utf-8?B?MzdoN1NQcUZPTjlIMUxWSzYvOXlLd05yUWJrc015c3UwYXlTdHhhajVLckdM?= =?utf-8?B?K2xIK09UR0xIM0RsRDJKdVByNkxDNkpmbVpFcEwvUlAwUmNKa1R6TnZkUmg3?= =?utf-8?B?VDNBbXZDODVyc2dJZEc1NU10UnRvV05YY3VVQkpsSmdieS8xUktMZFNFaUV0?= =?utf-8?B?d2UrdzkwZk83VFZYQzZJOElXbjFGcDdTQjlhUk1lckVZMkhrc1hSdTU0RjNI?= =?utf-8?B?ZnF5NzRLdmx4M3RtZzFEcFBPZG44Q3NZUzErMmNsVUlNdGF3cWVoaXVxalNC?= =?utf-8?B?WTRIU1BjOVRSV2pISkZDT25MUzJwODZpbU1aZFVtVU5mTGxFVXJheGtGZ21L?= =?utf-8?B?azQxNGI4emJFZDFvZ2h0OTdhd3VOcXRJUFdGdGNzbjJYSE1uOTA3THNhMEp1?= =?utf-8?B?UFVONi80ODZuZUk5bGtwOHhERW1JWkIwaC8wOXJjSUdYanR5WVUvZWtKajJC?= =?utf-8?B?QUhWZXRSem5LRDVqRzVyS1RoSDByYTdPVzlzM3IvejdDUE1JTHdBSmt3MHFi?= =?utf-8?Q?/MiLukkuQKALvB47v7jKInG2fGRxQm6za3X7eB0?= X-MS-Exchange-Transport-Forked: True X-MS-Exchange-CrossTenant-Network-Message-Id: 50fedc5a-0a08-40b4-e22c-08d99228aebb X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 11:16:08.0438 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9Y2vlifB76ABPkl7gLOw+3alHsCM4Tecm9yDx3+11oG7nSB8WcZedJIJ9TNxOPpKDzwdB+HowEvFRfAMn4ySEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4870 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/enic: fix build with GCC 7.5 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/15/2021 12:16 PM, David Marchand wrote: > On Fri, Oct 15, 2021 at 12:28 PM Ferruh Yigit wrote: >> >> Build error: >> ../drivers/net/enic/enic_fm_flow.c: In function 'enic_fm_flow_parse': >> ../drivers/net/enic/enic_fm_flow.c:1467:24: >> error: 'dev' may be used uninitialized in this function >> [-Werror=maybe-uninitialized] >> struct rte_eth_dev *dev; >> ^~~ >> ../drivers/net/enic/enic_fm_flow.c:1580:24: >> error: 'dev' may be used uninitialized in this function >> [-Werror=maybe-uninitialized] >> struct rte_eth_dev *dev; >> ^~~ >> ../drivers/net/enic/enic_fm_flow.c:1599:24: >> error: 'dev' may be used uninitialized in this function >> [-Werror=maybe-uninitialized] >> struct rte_eth_dev *dev; >> ^~~ >> >> Build error looks like false positive, but to silence the compiler >> initializing the pointer with NULL. > > enic_fm_check_transfer_dst() contains branches where dev is not set > and those branches return rte_flow_error_set return value. > dev is dereferenced later based on this return value == 0. > > So the compiler probably thinks that rte_flow_error_set may return 0. > rte_flow_error_set is outside of compiler "view" at the moment it > compiles enic_fm_flow.c, so the compiler making the assumption this > function can return 0 is being prudent from my pov. > > >> >> Fixes: 7968917ccf64 ("net/enic: support meta flow actions to overrule destinations") >> >> Reported-by: David Marchand >> Signed-off-by: Ferruh Yigit > > Your fix looks good in any case. > > Reviewed-by: David Marchand > Applied to dpdk-next-net/main, thanks.