From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Huang, Wei" <wei.huang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
"Xu, Rosen" <rosen.xu@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
"Zhang, Tianfei" <tianfei.zhang@intel.com>,
Ray Kinsella <mdr@ashroe.eu>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v11 1/4] raw/ifpga: add fpga rsu function
Date: Mon, 25 Jan 2021 10:01:11 +0000 [thread overview]
Message-ID: <5f1aa155-64c4-2922-b76d-31130e22ed66@intel.com> (raw)
In-Reply-To: <DM6PR11MB3530A7EB3D5DA315CD70E7C7EFA00@DM6PR11MB3530.namprd11.prod.outlook.com>
On 1/22/2021 2:18 AM, Huang, Wei wrote:
<Please do not top post, your comment moved below>
>>
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>> Sent: Friday, January 22, 2021 00:30
>> To: Huang, Wei <wei.huang@intel.com>; dev@dpdk.org; Xu, Rosen <rosen.xu@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
>> Cc: stable@dpdk.org; Zhang, Tianfei <tianfei.zhang@intel.com>; Ray Kinsella <mdr@ashroe.eu>
>> Subject: Re: [dpdk-stable] [PATCH v11 1/4] raw/ifpga: add fpga rsu function
>>
>> On 1/21/2021 6:03 AM, Wei Huang wrote:
>>> RSU (Remote System Update) depends on secure manager which may be
>>> different on various implementations, so a new secure manager device
>>> is implemented for adapting such difference.
>>> There are three major functions added:
>>> 1. ifpga_rawdev_update_flash() updates flash with specific image file.
>>> 2. ifpga_rawdev_stop_flash_update() aborts flash update process.
>>> 3. ifpga_rawdev_reload() reloads FPGA from updated flash.
>>>
>>> Signed-off-by: Wei Huang <wei.huang@intel.com>
>>> Acked-by: Tianfei Zhang <tianfei.zhang@intel.com>
>>> Acked-by: Rosen Xu <rosen.xu@intel.com>
>>
>> <...>
>>
>>> @@ -76,4 +76,9 @@ int
>>> ifpga_unregister_msix_irq(enum ifpga_irq_type type,
>>> int vec_start, rte_intr_callback_fn handler, void *arg);
>>>
>>> +int ifpga_rawdev_update_flash(struct rte_rawdev *dev, const char *image,
>>> +uint64_t *status);
>>> +int ifpga_rawdev_stop_flash_update(struct rte_rawdev *dev, int
>>> +force); int ifpga_rawdev_reload(struct rte_rawdev *dev, int type, int
>>> +page);
>>> +
>>> #endif /* _IFPGA_RAWDEV_H_ */
>>>
>>
>> Hi Wei,
>>
>> Please help me understand the rawdev, who should be calling the above newly added functions?
>>
>
> Hi Ferruh,
>
> Cyborg is an OpenStack project that aims to provide a general purpose
management framework for acceleration resources (i.e. various types of
accelerators such as GPU, FPGA, NP, ODP, DPDK/SPDK and so on).
>
> To update the FPGA flash is one of requirements from Cyborg. Originally there
are no such interfaces, so I added them.
>
> These interfaces use rte_rawdev to identify which FPGA to access, they will
be called in opae_update_flash(),
> opae_cancel_flash_update() and opae_reboot_device() in ifpga_opae_api.c .
>
> These opae_xxx function use PCI address to identify FPGA instead of
rte_rawdev, so the caller has no need to know the existence of rte_rawdev.
> In fact, Cyborg is Python application, these opae_xxx functions will be
eventually wrapped in a Python module for Cyborg to call.
>
Thanks for clarification, I see what you are doing, but still I think these APIs
are not belong to a driver, they look like more application level.
@Wei, @Rosen, what do you think to keep only generic raw/ipfga APIs in the
driver and move all 'ifpga_opae_api.c/h' to the sample application?
In that case raw/ifpga APIs still can get the port_id as parameter, and the
'opae' layer in the sample can do the conversion?
next prev parent reply other threads:[~2021-01-25 10:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 6:03 [dpdk-dev] [PATCH v11 0/4] raw/ifpga: add extra OPAE APIs Wei Huang
2021-01-21 6:03 ` [dpdk-dev] [PATCH v11 1/4] raw/ifpga: add fpga rsu function Wei Huang
2021-01-21 16:30 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2021-01-22 2:18 ` Huang, Wei
2021-01-25 10:01 ` Ferruh Yigit [this message]
2021-01-25 10:33 ` Xu, Rosen
2021-01-26 1:16 ` Huang, Wei
2021-01-21 6:03 ` [dpdk-dev] [PATCH v11 2/4] raw/ifpga: add fpga property get function Wei Huang
2021-01-21 6:03 ` [dpdk-dev] [PATCH v11 3/4] raw/ifpga: add OPAE API for OpenStack Cyborg Wei Huang
2021-01-21 16:29 ` Ferruh Yigit
2021-01-22 2:43 ` Huang, Wei
2021-01-25 10:07 ` Ferruh Yigit
2021-01-21 16:30 ` Ferruh Yigit
2021-01-22 3:16 ` Huang, Wei
2021-01-21 16:33 ` Ferruh Yigit
2021-01-22 3:25 ` Huang, Wei
2021-01-21 6:03 ` [dpdk-dev] [PATCH v11 4/4] examples/ifpga: add example for opae ifpga API Wei Huang
2021-01-21 16:49 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2021-01-22 3:52 ` Huang, Wei
2021-01-21 7:08 ` [dpdk-dev] [PATCH v11 0/4] raw/ifpga: add extra OPAE APIs Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f1aa155-64c4-2922-b76d-31130e22ed66@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=mdr@ashroe.eu \
--cc=qi.z.zhang@intel.com \
--cc=rosen.xu@intel.com \
--cc=stable@dpdk.org \
--cc=tianfei.zhang@intel.com \
--cc=wei.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).