From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5DFCA0C46; Mon, 27 Sep 2021 18:21:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BD817410E2; Mon, 27 Sep 2021 18:21:24 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 8AF78410DD for ; Mon, 27 Sep 2021 18:21:22 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10120"; a="310057831" X-IronPort-AV: E=Sophos;i="5.85,326,1624345200"; d="scan'208";a="310057831" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2021 09:19:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,326,1624345200"; d="scan'208";a="486196788" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga008.jf.intel.com with ESMTP; 27 Sep 2021 09:19:35 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 27 Sep 2021 09:19:35 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 27 Sep 2021 09:19:35 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.171) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 27 Sep 2021 09:19:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ISyBhzXFxdC+wNI5c+x9xEECK0v9RoZC3J2aJIBMx46zB7RkujV3ekFkd6FnjFq6lf5VMuGAYFu5Zss3IWk7Dy0Efm4MV4GZ+s4kJZHd79s1LNppVY2ItdnYDWXqiDZPn6t+ftD/hwQGhcDKAZxxst/cH1GzwbfBTuI91BANqDYj/SNu7ffGwY4SOzq21/l4gkBx3sJyhKB4pz0OwSegIj0RvTiqb0nSnCpTJTjaEtu+1NI+AIPxMZbXB+Ic5H8T5OBLwZTn/6NcidXrL5Ac5Rd53juQZDM3bLOmbb2Jd0egoRngEPflhJxEKaRopV5ljJh5V3sI6lYthfrat1RzPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=SIrdSSrJrR+taXtjNbsW/oBycweVOAQVejCh8k9+tmA=; b=l7eaU9SR62jMgKYYuCNU7sulmmDjgga/qE5sPVU67WIEjWN7gg960+sBWWZr03MxXF51zpers8AIULI8cgfZGViGzN7c8wUthMxxu1hr3hCHGUPLoD7riH0/j+aND7yK/y6VUhlLEyz8MA9nz/w0pCohSB5QRIbUta/krA546NRC792NoH46XM6b0U9+ymoEXSWMrgCMezkeFVani54VgOAW5764X+s2zKkB9bVZyS6lZySyaiWjkMUd3RNzL2BH2+aSpm3RX687XXYR1HioiDtpAGCxHNkHDebgwmu8okwuotIs0b3yj5A4Ttq3VpWDWM+L2gwBw+m6sE10bSEMhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SIrdSSrJrR+taXtjNbsW/oBycweVOAQVejCh8k9+tmA=; b=jVMfo1cA1mRPbXUgFBkFglyeuiu47nQFGQdXd5rHQ4pSJfrQz1mIGIBFYF1DY0hV+DHbOo8hwwysBcC+o7ssfTc5jgE2YcUJbKF45QzveegwZ7PI7sF9N7ejwxtfmFnn3eF79FYGgWBdYhvlcowW7a668l2tg24xPgL7iammw/Q= Authentication-Results: broadcom.com; dkim=none (message not signed) header.d=none;broadcom.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4823.namprd11.prod.outlook.com (2603:10b6:510:43::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.15; Mon, 27 Sep 2021 16:19:34 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4544.021; Mon, 27 Sep 2021 16:19:34 +0000 To: Chengwen Feng , , CC: , Jingjing Wu , "Kalesh Anakkur Purayil" , Ajit Khaparde References: <1627281811-45185-1-git-send-email-fengchengwen@huawei.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <5f36c0d0-3bce-ff70-d355-269686cad41a@intel.com> Date: Mon, 27 Sep 2021 17:19:27 +0100 In-Reply-To: <1627281811-45185-1-git-send-email-fengchengwen@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU2PR04CA0340.eurprd04.prod.outlook.com (2603:10a6:10:2b4::12) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0340.eurprd04.prod.outlook.com (2603:10a6:10:2b4::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.14 via Frontend Transport; Mon, 27 Sep 2021 16:19:32 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d7f5af3f-f9b7-481b-b00a-08d981d297ce X-MS-TrafficTypeDiagnostic: PH0PR11MB4823: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LoOp1IllKmsApChet3CqNQANVTrrz4dlPCGoStsEI2jdP+NaobocG2CQPgazp0dQ7jfS64Liuh0gDUK1BqwyxYcsFLUU/NvMUHRqTMEH/xcrIt/eKCMvSsxhWaAUVxO5H1pYl52+SZFgjz3GQv5IiPGixZldUZb9vEhMelPYMuZrG2g98lSp2VSqBGvbAlUJUXIuO21NvOnqpMRk9uD2Bu/yXFhSWIAypHieF0OWVvz5MFSqNmEZ25OQdBwBGJwQXfsJURTDNTCiAbB4cTy34VuShzKCBfc+UNs2J9dRYc5X3Exh7XBYScG2Ejh6opFTNYNHkPQAeaVOXJXCqjqDXNZ6uOKB+WB+AOByfivDSKOdh0L6l9VC6vFmje5halHr8EAEB3ghWj/xz0sCuGeJSC61Q+glJzxghIbTHs0n4LdGphBmoHTVL8HLSJDywgs9eVpHZiMyxqlR7aMRlSzVXGsGucUSI+5flrlTWHm6QVp+gSl7T2yZxs98+QZVOK6tVVLJS7cUvL6Ba1f8v6gQVgR89r7PEex7u5+7dkmGmya2cGldfQhSISc0pgAq9eFGbY4sQgYJBrNufhRDC52m7u/lZFBtJBb2n69sM5tYE8xDX5AankUEir8BqEboLqu3G4jbYpbcWqv3oXWDdxuU59XUAQScWowQZ5eDAJ+zGS0lzUOWFP8Fqq5WZGDkqTx8MdYhvdXgLjZ7W5aUePAltw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(508600001)(4326008)(6486002)(36756003)(38100700002)(83380400001)(26005)(31686004)(16576012)(66946007)(186003)(8936002)(31696002)(54906003)(2616005)(44832011)(66476007)(8676002)(53546011)(5660300002)(2906002)(956004)(86362001)(6666004)(316002)(66556008)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUczc3VnaHVjUlpod3NNbEJ5M243Z3JYL2YxOEY5dHFiYnl3czNsRlArc2N0?= =?utf-8?B?czYzaW80Tko4c1NhYnZnU0UzMnorb0w3ODdMUUZaMzZKSmdDWjlnSzJUdEpQ?= =?utf-8?B?VWtDc3NrNjYyeUlvSmtNaGEyT3RJWnRsVkc5VjM3d2FBOEpVeUtpN2tEeDBu?= =?utf-8?B?UytNdHFrK0hZNGJSTGczY0FST0xHMWtvY01vRmlPQWhJSStPWnlmanM1SXp0?= =?utf-8?B?U1Rka0w4SEt5Vm5JMTFjSDVyYXNzRkc0WGYyWEZRRmtkOFROUlN5RWh6M3ZY?= =?utf-8?B?NVZRNGEzOFF1bkZzUFBZZjBkN09iNmY2d3h0WENnOWRNeGlKUWVpTUFkV0Vk?= =?utf-8?B?ZHc5UnJKcUt3bDY1dnZ5ZTRVVlNGNmRyTDIyMVJQNEVIbGFjSTg3MEU2Szcv?= =?utf-8?B?QnQ4eTVMbTk1YjVHclFrZlRucGZORzdPUHdIcnByVnpjcVhRNTI4UTErbHpM?= =?utf-8?B?RGQ0Z1g1NXQrcDVtZE4rTG9IWXQ3K3BNSS9FRUlnMXlZUHhUZGs1TFRUV0xE?= =?utf-8?B?ZWc0M0lycENyUWhiK2tXVTcvUlhhNFQ0RGI5Ymh1UVVLbk5BZ3UrMCswV1Nt?= =?utf-8?B?L1hXdEJadzhUR3R5QXZ3c0kzL0lscHNCVVNtUEpsendaNEozaENOVkkzUTRW?= =?utf-8?B?WFRpMmh5YTlROUZuUGJaM2JmbE9IWnNNczdGWkdCSDR1OXN1dEJFcUNBSlcv?= =?utf-8?B?M1hTK1NCQlpsbG9vSk1OOURaejF6OVN3dTlDNk1WeUdmUVoveVFnci8remFq?= =?utf-8?B?WTV4cmI3NFlSUDdUQVY2SVZjM0NhWlhrcnhZbHhTMkUrcUtwb0cza21Zd1F3?= =?utf-8?B?RTZRUC8xazR4dTJvdEF0clhyak9aY3V3SGswblhnNys0aGFyb0JkSlZkNFZt?= =?utf-8?B?TEpoWE96Y1VBM29KZG5tNEVFbG1TK0FHTm03UGlQMUh4cFpzWVM5VktINVFy?= =?utf-8?B?QURRSlEyUFJweGM4R1RXazNBSGkxWTJremN2OENQRkxFM25ybnFCSERuYlN4?= =?utf-8?B?aml5OVIvYll1OVlkdUFIOXpYSFVHaXFOaHRCcjU0YzRyMFZKdklnZjYzalpZ?= =?utf-8?B?Z2ZNZTRiamtaVVZObll0S3g3Ti96QVBsNFMwaUZRYk5nWUszbElDZGI5Mlpa?= =?utf-8?B?OERKTWxjVm91NDhwRVZOVzZHU1BvTkpTSXViVHRVakwrTnZVck5pVVlsQ0RK?= =?utf-8?B?RGpraDkxS2Q4Nyt1OUkxK01nZkthMHVNanR3bzFWNDM2eVZseWQyWkNveWhp?= =?utf-8?B?OWtVa3JtajFHUk5wNm5IVkl1OVp4eFY3aFhvZGhWSlZMSGxBNHEvcVl2S05j?= =?utf-8?B?V2xNTkhtSnB2RkFBZ2haYmFRb3Y3SG1mVDArTy9na1Z5Q29zWUNUeURCSnRX?= =?utf-8?B?Rm1MQXBzUldKcFhnUW4xWGNlZUhXU2FZeVpaUCtObTUzczhoRjVIWlR5Snlr?= =?utf-8?B?MlpUMGVvVzhubTltVm5LUloxdHdBL2Zza3A5cW45WVZVRkl0UXZQYmdoNFZT?= =?utf-8?B?bGcrZGIvSXA5MHNhNHRyOFFESEVLRndZS0lRU05oK25ZWnloQlV1enpKVWFF?= =?utf-8?B?emVQWExaMWYvVURKcWRnZWQ4MTM3eHMrZ0w5OFU3UmoySWxjNU9xd0c5azVE?= =?utf-8?B?aXB6NEs4MkwvWEovTWx3bXF3eTRjdjl1RHRwVUxvTzZ4d3ptQlVSd1dxTEtC?= =?utf-8?B?eHE2Y3VRZXhsTkRWcjBUR3htdXVObkl2R2QvZnQrZmlJdFBtSytJQkEydGxy?= =?utf-8?Q?L+i4rVpFwjz6JuSJpEKFNllh3NNDh/84JJrt3td?= X-MS-Exchange-CrossTenant-Network-Message-Id: d7f5af3f-f9b7-481b-b00a-08d981d297ce X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2021 16:19:34.2613 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FeyoUDwBwgq7r+HJwAzoLUL8ipa1oi37sEgSa/RoO4aPNGSM4GmyrJ8TW59XQoaHCqe4t5v9Eds//cTxN1eh9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4823 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] ethdev: modify comment of INTR RESET event X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/26/2021 7:43 AM, Chengwen Feng wrote: > According to the definition of rte_eth_dev_reset(), the > RTE_ETH_EVENT_INTR_RESET event could also use when PF resets. > Can you please highlight the part in the 'rte_eth_dev_reset()' definition related to the RESET event usage for PF? > This patch modifies the comment of RTE_ETH_EVENT_INTR_RESET event, so > that it could use in all resets. > The original intention seems as the comment mentions, please check related commits [1]. As far as I can get from below comments, usecase is, - PF sends reset command to VFs (driver internal command) - VF sends RESET event to application, to request reset to be performed by application. So event is more like a reset request from driver to application. Overall it is OK to extend the usage of the RESET event to PF, if there is a usecase for it. What is your usecase? And should we extend comment (API documentation) a little more to clarify when this even should be sent and what application should do when event received, what do you think? btw, cc'ed Ajit & Kales, as far as I remember in the past they suggest a recover event, maybe relevant with this discussion. [1] Commit ae19955e7c86 ("i40evf: support reporting PF reset") Commit 514302ff6e00 ("ethdev: add NIC reset operation") > Signed-off-by: Chengwen Feng > --- > lib/ethdev/rte_ethdev.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > index d2b27c3..e6646a6 100644 > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -3499,8 +3499,7 @@ enum rte_eth_event_type { > RTE_ETH_EVENT_INTR_LSC, /**< lsc interrupt event */ > RTE_ETH_EVENT_QUEUE_STATE, > /**< queue state event (enabled/disabled) */ > - RTE_ETH_EVENT_INTR_RESET, > - /**< reset interrupt event, sent to VF on PF reset */ > + RTE_ETH_EVENT_INTR_RESET, /**< reset interrupt event */ > RTE_ETH_EVENT_VF_MBOX, /**< message from the VF received by PF */ > RTE_ETH_EVENT_MACSEC, /**< MACsec offload related event */ > RTE_ETH_EVENT_INTR_RMV, /**< device removal event */ >