From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC3B7A0524; Tue, 20 Apr 2021 03:11:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 81A7A41549; Tue, 20 Apr 2021 03:11:40 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id CF66E41448 for ; Tue, 20 Apr 2021 03:11:38 +0200 (CEST) IronPort-SDR: bIjss9LGrFIOAkMdmjuI1l3pTj0seaMb9hbT03j+T5cqJUbRGoljE0djFwd6ocIdwER9ZWfG8u qdoRnKKB4xnA== X-IronPort-AV: E=McAfee;i="6200,9189,9959"; a="195537947" X-IronPort-AV: E=Sophos;i="5.82,235,1613462400"; d="scan'208";a="195537947" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2021 18:11:37 -0700 IronPort-SDR: YIAecmttNrt99LNV3VnCeu+i62MnQjTyZ2GVrJR97y42z9+V+bSzPTuiaK2JPWgi2c39gLB+ro X+EFELbUKbTA== X-IronPort-AV: E=Sophos;i="5.82,235,1613462400"; d="scan'208";a="452329657" Received: from agrady-mobl.ger.corp.intel.com (HELO [10.213.224.96]) ([10.213.224.96]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2021 18:11:35 -0700 To: Thomas Monjalon , nipun.gupta@nxp.com Cc: dev@dpdk.org, arybchenko@solarflare.com, hemant.agrawal@nxp.com, sachin.saxena@nxp.com, rohit.raj@nxp.com, jerinjacobk@gmail.com, stephen@networkplumber.org, asafp@nvidia.com References: <20200831075333.10135-1-nipun.gupta@nxp.com> <20201015132343.4050-1-nipun.gupta@nxp.com> <4c3aeb4a-262e-6959-25cc-320bfa490774@intel.com> <7134832.kB0gn7W8D5@thomas> From: Ferruh Yigit X-User: ferruhy Message-ID: <5f4912cf-f7fc-8ff0-ae47-3020187b998b@intel.com> Date: Tue, 20 Apr 2021 02:11:31 +0100 MIME-Version: 1.0 In-Reply-To: <7134832.kB0gn7W8D5@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/3 v4] ethdev: add Rx offload to drop error packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/18/2021 8:37 PM, Thomas Monjalon wrote: > 18/02/2021 21:32, Ferruh Yigit: >> On 10/15/2020 2:23 PM, nipun.gupta@nxp.com wrote: >>> From: Nipun Gupta >>> >>> This change adds a Rx offload capability and configuration to >>> enable hardware to drop the packets in case of any error in the >>> packets such as L3 checksum error or L4 checksum. >>> >>> Signed-off-by: Nipun Gupta >>> Signed-off-by: Rohit Raj >>> Reviewed-by: Asaf Penso >>> --- >> >> This feature touches many main parts, >> - new config item for 'rte_eth_dev_configure()' >> - a new offload flag >> - new capability reporting for 'rte_eth_dev_info_get()' >> >> The feature doesn't look very mainstream to touch all these main parts and add >> complexity to them, which will affect almost all users. >> >> And has some inconsistencies, like configuration is done via config struct, but >> capability is returned as bit-wise. >> Or I think config option taken into account only if offload is requested has a >> chance to confuse people in both app and driver end. >> >> What do you think having two specific APIs to get_capabilities and set drop config? >> The responsibility of those APIs will be clear and narrowed down, which makes it >> harder to make it wrong. > > I agree. In general, it is better adding new functions > instead of adding everything in rte_eth_dev_configure(). > The set is stale, rejecting it, please send a new version if required.