From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 2380A1E20 for ; Tue, 11 Apr 2017 10:39:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491899976; x=1523435976; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=5UHDci6W6dtVeNwG2El68R3fxgk6xbdlT9gtlYCQj3Y=; b=mJbmevz0HyYZPQ0kdFH8/F4tWpkRbxT7Ie5qg1VrYqfwByjq/d2Tm7Fu 13tm90HpYjHZkUf8m7UWKsy3D1J2PA==; Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Apr 2017 01:39:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,184,1488873600"; d="scan'208";a="1133866571" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by fmsmga001.fm.intel.com with ESMTP; 11 Apr 2017 01:39:13 -0700 To: Thomas Monjalon , Hemant Agrawal Cc: Olivier MATZ , dev@dpdk.org, shreyansh.jain@nxp.com References: <1489754838-1455-2-git-send-email-hemant.agrawal@nxp.com> <20170410215847.704092d2@neon> <9977cf0c-e1cf-b235-e199-c5242daa75c2@nxp.com> <21940728.tivBTtkBCF@xps13> From: Ferruh Yigit Message-ID: <5f4fe240-8f17-0d4f-04b7-a8dd04b2c16e@intel.com> Date: Tue, 11 Apr 2017 09:39:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <21940728.tivBTtkBCF@xps13> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] mempool/dpaa2: add DPAA2 hardware offloaded mempool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Apr 2017 08:39:36 -0000 On 4/11/2017 8:50 AM, Thomas Monjalon wrote: > 2017-04-11 11:28, Hemant Agrawal: >> On 4/11/2017 1:28 AM, Olivier MATZ wrote: >>> Hemant Agrawal wrote: >>>> --- a/drivers/bus/Makefile >>>> +++ b/drivers/bus/Makefile >>>> @@ -33,6 +33,10 @@ include $(RTE_SDK)/mk/rte.vars.mk >>>> >>>> core-libs := librte_eal librte_mbuf librte_mempool librte_ring librte_ether >>>> >>>> +ifeq ($(CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL),y) >>>> +CONFIG_RTE_LIBRTE_FSLMC_BUS = $(CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL) >>>> +endif >>>> + >>>> DIRS-$(CONFIG_RTE_LIBRTE_FSLMC_BUS) += fslmc >>>> DEPDIRS-fslmc = ${core-libs} >>>> >>> >>> What's the purpose of this? >>> Not sure we are allowed to modify the configs in the Makefiles. >> >> DPAA2_MEMPOOL will not work without the DPAA2 mempool hw instance >> detected on FSLMC_BUS. >> So, it is required that if you are enabling DPAA2_MEMPOOL, FSLMC_BUS is >> to be enabled. >> >> Currently the config structure do not provide such dependency definitions. >> >> This was done based on the suggestions on the initial patches from >> Ferruh and Jerin. > > Please do not do that. > We do not change the configuration in the back of the user. > This kind of dependency should be managed in the configuration step > which do not exist yet. > > You can use $(error) to stop the compilation instead. As Hemant mentioned, this was my suggestion. There is a configuration dependency here, that we don't have a way to resolve in dpdk. If one of the end leaf selected, it makes sense to me to auto select dependent pieces. Thanks, ferruh