From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ori Kam <orika@mellanox.com>, Jack Min <jackmin@mellanox.com>,
Slava Ovsiienko <viacheslavo@mellanox.com>,
Thomas Monjalon <thomas@monjalon.net>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Andrew Rybchenko <arybchenko@solarflare.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: fix expand RSS flows
Date: Thu, 7 Nov 2019 17:02:43 +0000 [thread overview]
Message-ID: <5f5150bf-1688-61f9-4d75-e0e372b4d67e@intel.com> (raw)
In-Reply-To: <AM4PR05MB3425FD5AD62782F7F0630A2CDB790@AM4PR05MB3425.eurprd05.prod.outlook.com>
On 11/6/2019 10:12 AM, Ori Kam wrote:
>
>
>> -----Original Message-----
>> From: Xiaoyu Min <jackmin@mellanox.com>
>> Sent: Tuesday, November 5, 2019 3:43 PM
>> To: Ori Kam <orika@mellanox.com>; Slava Ovsiienko
>> <viacheslavo@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>;
>> Adrien Mazarguil <adrien.mazarguil@6wind.com>; Ferruh Yigit
>> <ferruh.yigit@intel.com>; Andrew Rybchenko <arybchenko@solarflare.com>
>> Cc: dev@dpdk.org; stable@dpdk.org
>> Subject: [PATCH v2] ethdev: fix expand RSS flows
>>
>> rte_flow_expand_rss expands rte_flow item list based on the RSS
>> types. In another word, some additional rules are added if the user
>> specified items are not complete enough according to the RSS type,
>> for example:
>>
>> ... pattern eth / end actions rss type tcp end ...
>>
>> User only provides item eth but want to do RSS on tcp traffic.
>> The pattern is not complete enough to filter TCP traffic only.
>> This will be a problem for some HWs.
>> So some PMDs use rte_flow_expand_rss to expand above user provided
>> flow to:
>>
>> ... pattern eth / end actions rss types tcp
>> ... pattern eth / ipv4 / tcp / end actions rss types tcp ...
>> ... pattern eth / ipv6 / tcp / end actions rss types tcp ...
>>
>> in order to filter TCP traffic only and do RSS correctly.
>>
>> However the current expansion cannot handle pattern as below, which
>> provides ethertype or ip next proto instead of providing an item:
>>
>> ... pattern eth type is 0x86DD / end actions rss types tcp ...
>>
>> rte_flow_expand_rss will expand above flow to:
>>
>> ... pattern eth type is 0x86DD / ipv4 / tcp end ...
>>
>> which has conflicting values: 0x86DD vs. ipv4 and some HWs will refuse
>> to create flow.
>>
>> This patch will fix above by checking the last item's spec and to
>> expand RSS flows correctly.
>>
>> Currently only support to complete item list based on ether type or ip
>> next proto.
>>
>> Fixes: 4ed05fcd441b ("ethdev: add flow API to expand RSS flows")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Xiaoyu Min <jackmin@mellanox.com>
>> ---
>> v2:
>> * more clear commit message
>> ---
>
> Acked-by: Ori Kam <orika@mellanox.com>
>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2019-11-07 17:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 9:16 [dpdk-dev] [PATCH] ethdev: expand RSS flows based on last item spec Xiaoyu Min
2019-11-05 10:11 ` Thomas Monjalon
2019-11-05 12:08 ` Jack Min
2019-11-05 13:42 ` [dpdk-dev] [PATCH v2] ethdev: fix expand RSS flows Xiaoyu Min
2019-11-06 10:12 ` Ori Kam
2019-11-07 17:02 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f5150bf-1688-61f9-4d75-e0e372b4d67e@intel.com \
--to=ferruh.yigit@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=jackmin@mellanox.com \
--cc=orika@mellanox.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).