From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ADBC5A0540; Thu, 7 Jul 2022 13:30:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6BF2740A7B; Thu, 7 Jul 2022 13:30:52 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7C732406B4 for ; Thu, 7 Jul 2022 13:30:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657193450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IrTOBRnzXyBZvKdJXVfvWNjPZgtxOKD7TgyKn5yzpCg=; b=NHmFR8DojVdHACWz4oP4cHvny6sPab2f7QpDMBbU6iWawy+NuIOV+0JdkDt+Ty4a/AxLcH 2uv0IyuYGteJEqNPH4J/asXn2iZMOLSptOa/+FRoYqdr8KAxv8G1Hl2KMdRI3FdvlHOb5w 0wCcR6ftS4D0DjQXJZ9s8x0BhKAAYDA= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-448-2tdq0ujKPO2IyhEzkgNh9Q-1; Thu, 07 Jul 2022 07:30:43 -0400 X-MC-Unique: 2tdq0ujKPO2IyhEzkgNh9Q-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 588C73801F57; Thu, 7 Jul 2022 11:30:43 +0000 (UTC) Received: from [10.39.208.34] (unknown [10.39.208.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 22EE62EF99; Thu, 7 Jul 2022 11:30:42 +0000 (UTC) Message-ID: <5f6441be-4ab3-7a0d-483d-432a8a519919@redhat.com> Date: Thu, 7 Jul 2022 13:30:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] vhost: fix unnecessary dirty page logging To: "Xia, Chenbo" , "Ding, Xuan" Cc: "dev@dpdk.org" , "Hu, Jiayu" , "He, Xingguang" , "Yang, YvonneX" , "Jiang, Cheng1" References: <20220707065513.66458-1-xuan.ding@intel.com> From: Maxime Coquelin In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/7/22 11:51, Xia, Chenbo wrote: >> -----Original Message----- >> From: Ding, Xuan >> Sent: Thursday, July 7, 2022 2:55 PM >> To: maxime.coquelin@redhat.com; Xia, Chenbo >> Cc: dev@dpdk.org; Hu, Jiayu ; He, Xingguang >> ; Yang, YvonneX ; Jiang, >> Cheng1 ; Ding, Xuan >> Subject: [PATCH] vhost: fix unnecessary dirty page logging >> >> From: Xuan Ding >> >> The dirty page logging is only required in vhost enqueue direction for >> live migration. This patch removes the unnecessary dirty page logging >> in vhost dequeue direction. Otherwise, it will result in a performance >> drop. Some if-else judgements are also optimized to improve performance. >> >> Fixes: 6d823bb302c7 ("vhost: prepare sync for descriptor to mbuf >> refactoring") >> Fixes: b6eee3e83402 ("vhost: fix sync dequeue offload") >> >> Signed-off-by: Xuan Ding >> --- > > Reviewed-by: Chenbo Xia > > Although it's late in release, we can consider to merge this as I see it impacts > the performance by 5%: > http://inbox.dpdk.org/dev/BYAPR11MB2711F13CDA2B0A4535A6591EFE839@BYAPR11MB2711.namprd11.prod.outlook.com/T/#t Yes, I raised we need it in -rc4 at today's Release status meeting. I'll review it today. > But also, it will be good to know the performance issue is solved by sharing the > test results. Yes, Intel performance results would be appreciated. > Thanks, > Chenbo > Thanks, Maxime