From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D3C4A00BE; Mon, 28 Oct 2019 16:51:22 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E6AC31BF1F; Mon, 28 Oct 2019 16:51:20 +0100 (CET) Received: from dispatchb-us1.ppe-hosted.com (dispatchb-us1.ppe-hosted.com [148.163.129.53]) by dpdk.org (Postfix) with ESMTP id 29CE81BF08 for ; Mon, 28 Oct 2019 16:51:19 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us5.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 5EF928000A9; Mon, 28 Oct 2019 15:51:16 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 28 Oct 2019 15:50:59 +0000 To: Pavan Nikhilesh Bhagavatula , "ferruh.yigit@intel.com" , Jerin Jacob Kollanukkaran , Ajit Khaparde , "Somnath Kotur" , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Wenzhuo Lu , John Daley , Hyong Youb Kim , Qi Zhang , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Beilei Xing , Jingjing Wu , Qiming Yang , Konstantin Ananyev , Shijith Thotton , Srisivasubramanian Srinivasan , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Alejandro Lucero , Nithin Kumar Dabilpuram , Kiran Kumar Kokkilagadda , Rasesh Mody , Shahed Shaikh , Maciej Czekaj , Yong Wang CC: "dev@dpdk.org" References: From: Andrew Rybchenko Message-ID: <5f737ca6-1c4d-b2a2-edf2-00233bedc14b@solarflare.com> Date: Mon, 28 Oct 2019 18:50:54 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-25006.003 X-TM-AS-Result: No-12.523200-8.000000-10 X-TMASE-MatchedRID: vEvJ7Rh1lGgeimh1YYHcKKfOxh7hvX71iKQhvNyRXGHk1kyQDpEj8IP+ YDa/Dhu96dlqnF4gOVm0TL1wHXdwVZsyCEgzfA2XSvQm6xqmCPJp4xorO9dSme1VpmGiDxtcyJN a6DYLgM0FMvc3zLJP149CL1e45ag4cj8zE1EjtST1xv2JHBkcHz+7olaZ5ixYH1bhq4z+yfSlzb GAkBjouhEOP59EuENNUjyunbdUqJCRyUXgTydza2Y+xOrx57jW1K3bse3FjTtKDy5+nmfdPtgSk KeGM5sE4EXw14zmtrJu9+bdF2jJf3VVlWlpBwvrNyh9G6pvCVIA+JHhu0IR5kYza41dGqxSUS0x EYUYNYO/O3/cZ0v9uhBOjhpJCQarSSOWVJeuO1A5f9Xw/xqKXZwhktVkBBrQ/Fe+8oSUYKOrusV Ry4an8SAHAopEd76vE/i+7fu5owk83vCinuvOf2FpFJnU5YxR0i9PNDQOpdkjYXKlfV8e6w== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--12.523200-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-25006.003 X-MDID: 1572277877-DijoGmXOIuBT Subject: Re: [dpdk-dev] [PATCH v13 3/6] drivers/net: update Rx RSS hash offload capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/25/19 7:10 PM, Pavan Nikhilesh Bhagavatula wrote: >> On 10/25/19 5:33 PM, pbhagavatula@marvell.com wrote: >>> From: Pavan Nikhilesh >>> >>> Add DEV_RX_OFFLOAD_RSS_HASH flag for all PMDs that support RSS >> hash >>> delivery. >>> >>> Signed-off-by: Pavan Nikhilesh >>> Reviewed-by: Andrew Rybchenko >>> Reviewed-by: Hemant Agrawal >>> Acked-by: Jerin Jacob >>> Acked-by: Ajit Khaparde >> [snip] >> >>> diff --git a/drivers/net/bnxt/bnxt_ethdev.c >> b/drivers/net/bnxt/bnxt_ethdev.c >>> index e7ec99e15..d4f8cc92a 100644 >>> --- a/drivers/net/bnxt/bnxt_ethdev.c >>> +++ b/drivers/net/bnxt/bnxt_ethdev.c >>> @@ -117,7 +117,8 @@ static const struct rte_pci_id >> bnxt_pci_id_map[] = { >>> DEV_RX_OFFLOAD_KEEP_CRC | \ >>> DEV_RX_OFFLOAD_VLAN_EXTEND | >> \ >>> DEV_RX_OFFLOAD_TCP_LRO | \ >>> - DEV_RX_OFFLOAD_SCATTER) >>> + DEV_RX_OFFLOAD_SCATTER | \ >>> + DEV_RX_OFFLOAD_RSS_HASH) >>> >>> static int bnxt_vlan_offload_set_op(struct rte_eth_dev *dev, int >> mask); >>> static void bnxt_print_link_info(struct rte_eth_dev *eth_dev); >>> @@ -681,6 +682,12 @@ static int bnxt_dev_configure_op(struct >> rte_eth_dev *eth_dev) >>> bp->rx_cp_nr_rings = bp->rx_nr_rings; >>> bp->tx_cp_nr_rings = bp->tx_nr_rings; >>> >>> + if (!(rx_offloads & DEV_RX_OFFLOAD_RSS_HASH)) { >>> + PMD_DRV_LOG(INFO, "RX_OFFLOAD_RSS_HASH >> cannot be disabled\n"); >> >> Shouldn't logging be done from rte_eth_dev_configure()? >> I.e. a generic function which is called after dev_configure callback and >> take a look at dev_conf->rx_mode.offloads and >> dev->data->dev_conf.rxmode.offloads and for each bit which differs >> log message using rte_eth_dev_rx_offload_name(). >> Same for Tx while we are on the page. I.e. two more patch just before >> this one. >> > Just to be clear this log would effect all offloads which can't be disabled for > a give PMD. I think it is perfectly fine and it is my goal in fact. Thanks, Andrew.