From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC274A0C46; Tue, 31 Aug 2021 17:57:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D653A40141; Tue, 31 Aug 2021 17:57:36 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 176654013F; Tue, 31 Aug 2021 17:57:33 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10093"; a="279516599" X-IronPort-AV: E=Sophos;i="5.84,366,1620716400"; d="scan'208";a="279516599" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2021 08:57:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,366,1620716400"; d="scan'208";a="427519187" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga006.jf.intel.com with ESMTP; 31 Aug 2021 08:57:28 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 31 Aug 2021 08:57:28 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Tue, 31 Aug 2021 08:57:27 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Tue, 31 Aug 2021 08:57:27 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Tue, 31 Aug 2021 08:57:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mIEdTIvmTJZgucl3DBEmSEDgk6mZw8Vb29J+jI3ZzHbddY/LfiibT9yLgZ/f8zy82hf5LNbmvbLjezSbKyzrhZQ0SJm8bTTGKUP8uRLyDX/KoLcVTb6tzTBpuM/qcmPjZCQ64oq+Y3J6Zbsz1GeGH4cGO4gWbXdY5WCAKhr8S+gzp2l5xiDzvKx5LWguuDOqhRhi7qbGvWaluM5cw/GySABgWVTwDHfkB5arbjIxEVtMMTc/wMZCxvEvM6ZIE2DbfgOBP4iR+sVy7NqOdgoVHj/LjjB+rNiPzLEUl/Bmx4zCXmbJrzzshFWj3Di30mM6C5590bcTfh3KyNp5MokgkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Rv9+aodKyldKqkAPR/aJqKWLP7eVQuOHudkaGYNkOt8=; b=LKvgFhJqj4CxW6brQGleTWt904LCkIiSYBRioxEJmITBGQfj5LXXx98ah+wmBEHKf94sR9U7rZZMYGg4WXL5+D3Z9ARfKmoJnUI26CKOxWPb7jGBgV6vBihNIrTf9VxZl8IiUMSDNNReX0tIG1Yxmgny/VX1+cWmL/8LG1ZP8S0grt/rVpJgDvcd6nx9F5e58N3Sfy/utRKs+7jyltqsfOdCZXCiNocHCaZT0++LOIr4hYJyxoyMZXsPKMGJ1IJVkYFKNerhsGb1wnLwTKTao+2hZABfvUkrlrYYA2BdxvyXtMPmsz7/CKkWrCMBbbahjEckdA86HwjLEwzfudaJyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Rv9+aodKyldKqkAPR/aJqKWLP7eVQuOHudkaGYNkOt8=; b=zGgH19jxbzoxthE2w3p2u8Z2U1LqzYQQnyjKNYeOltBcJmRPtfxoidhvz86k96ZQHSDtbIhUrpS7REqjkGh8nd2FDp1aWho89B/9Ke9ZGyyGfaTyRdGz32SiGk8Yde9kX6xH3fikv+gmOFVl/e2YC/Zu2rTRYKLMRde7EGJRR7A= Authentication-Results: corigine.com; dkim=none (message not signed) header.d=none;corigine.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5078.namprd11.prod.outlook.com (2603:10b6:510:3e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Tue, 31 Aug 2021 15:57:27 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%4]) with mapi id 15.20.4457.024; Tue, 31 Aug 2021 15:57:26 +0000 To: , CC: , Simon Horman References: <20210823075921.97168-1-heinrich.kuhn@corigine.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <5f9c47ae-e0a6-4bb8-4889-0b1d75611318@intel.com> Date: Tue, 31 Aug 2021 16:57:21 +0100 In-Reply-To: <20210823075921.97168-1-heinrich.kuhn@corigine.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2P251CA0020.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::29) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.206] (37.228.236.146) by DU2P251CA0020.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.22 via Frontend Transport; Tue, 31 Aug 2021 15:57:25 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4a10690c-b0d4-4a96-7329-08d96c980791 X-MS-TrafficTypeDiagnostic: PH0PR11MB5078: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BLU1CV30ec21uhCZhidl1oPeZxvzcAl9BtBM8WFsiMz0nfvzDJEk0J5cXoU9kgMRiYXIdTzznRS+jkSOq/jZnGmun2dm115qy1bn5NW8sRwV0UWyJFfQzHiMUREfcheUagnUIAC1yLAZxUipczmVU9LINSBr7CHIxF3dQfvGWda7F0D6wYeL5NFM/yMbCLhuLVveWNNc+o57G21JoPbDfACFQt0n0mJX5BQYvoubmobBs1kUejVWTbSixnIac7OrJnpEvimqbdZI4oem/dOuX57vDxrMBfArXJwnsnPXpK5ssqLps9dOs6FZN1yyI194ePwvs4gKnatXV26gw035CXEGoWphGEyv1ZmH3/CUZpDHUmtWCd85kweV8bnonVUWomHIvsP1k5EMg1bB80ZRKF77uVJY4i3q7P9mJZM9BvTsDq6wpwmO2Lp9GwFRMABE7ZwMZ7aTvOq4vnmwtknRLKIbhU9Ch6U7Or2gfRvHvfxR655erZNssqlR7JkQcw5w+pwpGAwPoVsqK2Shsc9+1lOpnOjAyYauBcw5GF58VX2Xw271H5y/DbTj/kLAFeei4JmTdISC7PrrrpooHJrijw1lH+1BjLbS4624bioWr9TjdAGs71H7DqXuNO3KVSoW8fxMKKsY8vasIfWqfGY+5/6vlK+Lagy9zzW/ACmGHE6dNgIrqhYLidIbbV2CKfRzaZ8tNDyMTdcqaOKM38ApRg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(366004)(376002)(346002)(39860400002)(86362001)(8676002)(31686004)(186003)(26005)(53546011)(66476007)(4326008)(478600001)(31696002)(316002)(36756003)(2616005)(5660300002)(8936002)(2906002)(66556008)(44832011)(956004)(6666004)(6486002)(16576012)(38100700002)(66946007)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OU0vRXQ4eVpzanRBRHlmSmhWakhXQVFUd3BIRkVlZitOSkpNckQzSXIwZGNj?= =?utf-8?B?ZWlhOTJiWld5WEN5cElKbU5FakVNbjRMWUlrbVRab1pRNUI3N2MyZlRJTmgw?= =?utf-8?B?SXJVVnFEclZTQmltNXROaUh0VkJCZ3ZVcU5LNHUwVStEeG10UHY5TkpJUnQy?= =?utf-8?B?SHNoZzhuOUNtL09uYjRydVdzSTJ2aElYVE4wTDNKOTd3VWxUWktsbVNXWFZP?= =?utf-8?B?OVJQejdmVkh4OE1OZkVSYzAva0FQQ284N2crS2NsR3Q0aUxIKzVWWkpqRlNP?= =?utf-8?B?WEpzamZqMEMyNVhhMTVXcHhIeHlyUlkweWJQRVF1eC9IbGkyYTZIN0kxc3Qx?= =?utf-8?B?Y2MwbUYyVnFIdzREWDU3QnJqeTZETGlEQXRHRnI0aTdTZFBUZlVZZEFSdkNE?= =?utf-8?B?SzhzT0NycTBzRWtaTG9YQ2tRUXdFNUpiR0xMcG01ZFVjSjRlZVg5bktuU0Nz?= =?utf-8?B?SldNb09FK3pmUlJYQWd1eTNpd1Rhd3NETWxQdWxJTXlkTzJKbHFtdjMwTVBo?= =?utf-8?B?NUgxL3QxZFdLdmpvU28wSVREYzgrZzBpNXpSamVVYWRUNUtQb3YwdmhaMHRL?= =?utf-8?B?WFBSZTk0V25nTWUxNHdJS1VtWmZpRmdyM2JORXcxSFkxMHB5bVc1MjRwb292?= =?utf-8?B?TGpLSWV6TUx5U282N2pNWmRMU3VhbHZQQXJydXQ0WDE0aGZ4dndSRk5UUGlt?= =?utf-8?B?OWgwZXNSNzdlM0w1b1BUNmxadTl6d3ZVQlNTNVBTcTF3emwrdDlsL0ZMcWtw?= =?utf-8?B?N0lLenpQNnZmSVpaZ0ZRb1F6b3pkZy9ObGxmbk1KSlZ0SnJ6Q1hST2FLZHlB?= =?utf-8?B?d3ZEemNucjR2dWRiTW41K3YxZlUvTkZnclJuMWtjSVh0TjJPSmdJQXhNMFRC?= =?utf-8?B?VStHTlFtemd6clAzRzFydXh5ZXA0TjNmVWdydEVxNGJ1ZGVFNGlxM1BRVlBh?= =?utf-8?B?eHA0K3RrOUw3Z2Z2SU9LOENSdS9sZXNvR3lRRWdwQXRIc1BwTlJkcW1UTXlp?= =?utf-8?B?d2tZM3NQSkNvcVNINS90SjdEa21GMDV5Y2JXaVpTdldlK1FFdHpQY0FOamxW?= =?utf-8?B?L2RrbXozTFoxcm1SaW1QbVBkNjZ5cWptOHBCZHNxVlcxUE5teDY5cys2c1lH?= =?utf-8?B?L1BPc2MxSUlqN01VU1VlNDhUMHprV1Q2Um1NcitLN29Ob3d0ZXBOcDZXTzA4?= =?utf-8?B?M09FcnFPWW84WkdtZXQ4NnU2OUJpanl5RlJkTG02VnZMaDlueUowY1loSUtV?= =?utf-8?B?UytYZk9WSW9BcFVIZUdaRDVnSHBadmk1YVg3VzhQU1l2TjRORTJld1c2aC8w?= =?utf-8?B?K25iTEdWSSsrTU5BM3picUJqOG5QcUtJMTdTQW92OUNuMlJkdWVHQWx2ZEFr?= =?utf-8?B?NTBoc3NIV0xhUFc4Uk41Q294YldFRTBYMkx0VGJScVRwUjFmWEhPeU56bkc0?= =?utf-8?B?YkZkOGYyMEdrVUU5dkM2SjBEVTUyYVh4UDdkNjZreUgza3k3RDNRa0dCWWh3?= =?utf-8?B?K1p0bkFYSXM4a0VvZ3MyVWZUbHdkdTlKbCtvT1doWEJLaDZtVy9CV3ZFRG9o?= =?utf-8?B?T2ZNVVlkVTVnN0Y3ZFNkYTQ1bEprcUZJWVRMb1lpODRMekUrY3VEdkVhY3g3?= =?utf-8?B?bWxiK004Qlc3cE5Hc3pFU1ZBSEU4WWFnc3JTaHpkWEJzdVROUzRCNmFJVk50?= =?utf-8?B?aUZRbkd1N0pyaXVjM3JtdXdrckFPWE5jOEdnREw2RzNCNzl6YUNZSzIzazFT?= =?utf-8?Q?8vBW7VnMYD/OMpHt/qR7bvxZe9bdV4NBrcqhTIy?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4a10690c-b0d4-4a96-7329-08d96c980791 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2021 15:57:26.8642 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LbHzFn1EzgwXWer3q4w3N8j7Bf2U1wBT55+oI0Nd4Dlhs6eFDN+OUb087MgqSpqgyqqjM/xBtfZH3tk4BLtFHA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5078 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/nfp: fix minimum descriptor sizes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/23/2021 8:59 AM, heinrich.kuhn@corigine.com wrote: > From: Heinrich Kuhn > > The NFP4000/6000 supports a minimum of 256 Tx/Rx descriptors and not 64. > Before this patch when a DPDK application configured < 256 Tx > descriptors the hardware read/write pointers would be unmasked and not > wrapped at the expected size of the ring. The PMD logic to determine the > amount of free space in the Tx ring is incompatible with the unmasked > hwqueue pointers and this will result in the PMD not updating the > read pointer at all.The knock-on effect is that under high load the > PMD will potentially re-use a Tx descriptor before the hw has had a > chance to process that particular descriptor. This issue can manifest as > a DMA error when the hardware tries to perform a DMA with info from a > partially populated descriptor. > > Fixes: defb9a5dd156 ("nfp: introduce driver initialization") > Cc: stable@dpdk.org > > Signed-off-by: Heinrich Kuhn > Signed-off-by: Simon Horman Applied to dpdk-next-net/main, thanks.