From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36D27A0C4C; Thu, 2 Sep 2021 18:14:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1EA7F4003E; Thu, 2 Sep 2021 18:14:50 +0200 (CEST) Received: from mail-108-mta78.mxroute.com (mail-108-mta78.mxroute.com [136.175.108.78]) by mails.dpdk.org (Postfix) with ESMTP id 146124003C for ; Thu, 2 Sep 2021 18:14:48 +0200 (CEST) Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta78.mxroute.com (ZoneMTA) with ESMTPSA id 17ba74a859000074ba.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Thu, 02 Sep 2021 16:14:44 +0000 X-Zone-Loop: fb4cbe6a4d46f5dd1f11974a04c94617256c38e1fbea X-Originating-IP: [149.28.56.236] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=EV/njYZZzQ8z9E6oaEo8EPzhP2tYFJ0VZtVrtFLslHI=; b=UWQvNSgNNnjq1gCX17LifKEyab kXUUH89b5JqeqwZErBGjG/+38aLrd2obL0WtDdF5VQe/cq2ASTTzKYOnea3H7s5M2hTJ+4+kINqVm 97cpOLdW/eQru95QzGoY7W9tIo4X1qI9XZi8x3ehK21lrPgN8pr3nfD4PRvpEkXneI8VeD6bObQNg 0brnbC+9a5Zx4ItSQ94mCZAVJu7wJl5XFzy+juDkWD+4ZxYUkkJCKuFBqFg2PQkX3t+pVIycPRuSn kTOsArRHZya6B6UHiGNuL0XUulpoXgmTjEze3P3VZeDI5ucdiw5e/o3/l8GiEuWK+vaoy0Wsy5jkf S+00lCzQ==; To: Ivan Malov , dev@dpdk.org Cc: Andrew Rybchenko , Thomas Monjalon , Ferruh Yigit References: <20210902142359.28138-1-ivan.malov@oktetlabs.ru> <20210902142359.28138-2-ivan.malov@oktetlabs.ru> From: "Kinsella, Ray" Message-ID: <5fd3da7b-9c7b-569e-6711-fb58d1d77762@ashroe.eu> Date: Thu, 2 Sep 2021 17:14:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210902142359.28138-2-ivan.malov@oktetlabs.ru> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH 1/5] ethdev: add API to negotiate support for Rx meta information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 02/09/2021 15:23, Ivan Malov wrote: > Per-packet meta information (flag, mark and the likes) might > be expensive to deliver in terms of small packet performance. > If the features are not enabled by default, enabling them at > short notice (for example, when a flow rule with action MARK > gets created) without traffic disruption may not be possible. > > Letting applications request delivery of Rx meta information > during initialisation can solve the said problem efficiently. > > Technically, that could be accomplished by defining new bits > in DEV_RX_OFFLOAD namespace, but the ability to extract meta > data cannot be considered an offload on its own. For example, > Rx checksumming is an offload, while mark delivery is not as > it needs an external party, a flow rule with action MARK, to > hold the value and trigger mark insertion in the first place. > > With this in mind, add a means to let applications negotiate > adapter support for the very delivery of Rx meta information. > > Signed-off-by: Ivan Malov > Reviewed-by: Andrew Rybchenko > --- > lib/ethdev/ethdev_driver.h | 19 +++++++++++ > lib/ethdev/rte_ethdev.c | 25 +++++++++++++++ > lib/ethdev/rte_ethdev.h | 66 ++++++++++++++++++++++++++++++++++++++ > lib/ethdev/version.map | 3 ++ > 4 files changed, 113 insertions(+) > Acked-by: Ray Kinsella