From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 04BC9A034F; Thu, 14 May 2020 19:47:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2BAD31DA3B; Thu, 14 May 2020 19:47:01 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id BC7E61DA39 for <dev@dpdk.org>; Thu, 14 May 2020 19:46:59 +0200 (CEST) IronPort-SDR: OGFajqy+cXT5z2Q0jthrscSIBcJFrAfYR0Nj9A1ho7hTlicGmLJ5hx1RuvXZwfG9emUNtWqQ7O +e13o8F+ETaQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2020 10:46:58 -0700 IronPort-SDR: 6XB2C+hw9YS5mHhHuZxPS0vrKKVWYmh1sh3PlESDHDfvJaF/iIz6WGWJV+GuX/ryfBily1e38m d1VKJqFz9jeA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,392,1583222400"; d="scan'208";a="307174659" Received: from rmenon-mobl.amr.corp.intel.com (HELO [10.212.42.115]) ([10.212.42.115]) by FMSMGA003.fm.intel.com with ESMTP; 14 May 2020 10:46:57 -0700 To: Thomas Monjalon <thomas@monjalon.net>, Pallavi Kadam <pallavi.kadam@intel.com> Cc: dev@dpdk.org, dmitry.kozliuk@gmail.com References: <20200513225341.7620-1-pallavi.kadam@intel.com> <2114758.o7ts2hSHzF@thomas> From: Ranjit Menon <ranjit.menon@intel.com> Message-ID: <5ffd3dfe-f8d9-b251-c419-3ea1b239f34d@intel.com> Date: Thu, 14 May 2020 10:46:54 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <2114758.o7ts2hSHzF@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal: fix warnings on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 5/14/2020 1:02 AM, Thomas Monjalon wrote: > 14/05/2020 00:53, Pallavi Kadam: >> This patch fixes bunch of warnings when compiling on Windows >> such as the use of an unsafe string function (strerror), >> [-Wunused-const-variable] in getopt.c and >> [-Wunused-variable], [-Wunused-function] in eal_common_options.c >> >> Signed-off-by: Ranjit Menon <ranjit.menon@intel.com> >> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com> >> Tested-by: Pallavi Kadam <pallavi.kadam@intel.com> >> --- >> +#ifndef RTE_EXEC_ENV_WINDOWS >> static int >> eal_plugindir_init(const char *path) > > Why disabling the plugin mechanism? > Can we make it working instead? > The function that is calling eal_plugindir_init() has already been #ifndef-ed out for Windows compilation. So, this function will never be called on Windows and was the cause of multiple compilation warnings. Best to keep it disabled until we can have this implemented and working on Windows > PS: When sending patches for Windows, please Cc > the official Windows maintainers and Dmitry Kozliuk. > > Yes. Will do. ranjit m.