From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5235443C35; Thu, 29 Feb 2024 10:52:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CBA0C402BB; Thu, 29 Feb 2024 10:52:31 +0100 (CET) Received: from fhigh2-smtp.messagingengine.com (fhigh2-smtp.messagingengine.com [103.168.172.153]) by mails.dpdk.org (Postfix) with ESMTP id 40492402B4 for ; Thu, 29 Feb 2024 10:52:30 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 85A0E114009B; Thu, 29 Feb 2024 04:52:29 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 29 Feb 2024 04:52:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1709200349; x=1709286749; bh=UnNJ72sYL+XijkPHiI7MGynUmSsn29C3EXbRnp/nL4M=; b= x/ABmT4apsy0pKJejJx1HjVJaDhUhPWjp+fehaDkK3p1fNarCuXz8bo3QH1N0j+v kZ0XvELwtKfKF9HNUFxQQnPKr3cBU53qVcBGsMituqp7sR1ETtq6NjBK1uqLKSKo oRq52MzvCs3jftY2lRtmi51q1mootcnWwVmUh+WrDYW9igEMebOACGHGW213AQsY qTTs+u9himM5Ma3PPWEgYY2RhwSeuAwLOBapqCJA9sVg5/RG5W/sKLE8No8ZQvUX gXgOaJONhERqgUOltL2IL88tUodZGVI/THjlu/TLWMVB3V902YkY+/8d6oBntM6Z Xi0kBxnAQqQqExJN5csCkA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1709200349; x= 1709286749; bh=UnNJ72sYL+XijkPHiI7MGynUmSsn29C3EXbRnp/nL4M=; b=B Tsu9zrEpSh9EOPicj4PhZs+wMJYwajvq3lLjjvU3LESQSZoiSFbnlSXOvRxo8Nxw LnmsVJ9hRyDqNl8i6LgRJF5I/FPEgsd1doA2xPCTF4ST9q897WAlG8VJqMpOL7t/ ysl7BCGXyzeV9qWM797BF+RDRtL8w5tqZhGojw9IvnHvjVZheYFBlGOKMe28qncm ImEi+LzYuWL8FX0nFTpDkd4IGph2HgnuApZU2q4NC9HCp9cMTlJZKP5axdlRUKCv u2gT5vrhOrrDbQSzNegpMtErFq8udLrv3xHmKYhMkgkV9CbCUf1JrZdYhSboHXjm vLzUWwfxvgytPOqWZyHIQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrgeelgddtlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepjeejffffgfffkeefffelgfekleetjeffleeludeghfehleffteeh veduffdugfdvnecuffhomhgrihhnpeguphgukhdrohhrghenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhn rdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 29 Feb 2024 04:52:27 -0500 (EST) From: Thomas Monjalon To: ferruh.yigit@amd.com, Jie Hai Cc: dev@dpdk.org, lihuisong@huawei.com, fengchengwen@huawei.com, liuyonglong@huawei.com, huangdengdui@huawei.com Subject: Re: [PATCH v4 1/7] ethdev: support report register names and filter Date: Thu, 29 Feb 2024 10:52:25 +0100 Message-ID: <6000520.alqRGMn8q6@thomas> In-Reply-To: <20240226030739.3775514-2-haijie1@huawei.com> References: <20231214015650.3738578-1-haijie1@huawei.com> <20240226030739.3775514-1-haijie1@huawei.com> <20240226030739.3775514-2-haijie1@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 26/02/2024 04:07, Jie Hai: > This patch adds "filter" and "names" fields to "rte_dev_reg_info" > structure. Names of registers in data fields can be reported and > the registers can be filtered by their names. > > The new API rte_eth_dev_get_reg_info_ext() is added to support > reporting names and filtering by names. And the original API > rte_eth_dev_get_reg_info() does not use the name and filter fields. > A local variable is used in rte_eth_dev_get_reg_info for > compatibility. If the drivers does not report the names, set them > to "offset_XXX". Isn't it possible to implement filtering in the original function? What would it break? > @@ -20,6 +25,12 @@ struct rte_dev_reg_info { > uint32_t length; /**< Number of registers to fetch */ > uint32_t width; /**< Size of device register */ > uint32_t version; /**< Device version */ > + /** > + * Filter for target subset of registers. > + * This field could affects register selection for data/length/names. > + */ > + const char *filter; > + struct rte_eth_reg_name *names; /**< Registers name saver */ > }; I suppose this is an ABI break? Confirmed: http://mails.dpdk.org/archives/test-report/2024-February/587314.html