From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 50E7FA499
 for <dev@dpdk.org>; Tue, 17 Apr 2018 22:18:25 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id B9A1320DE6;
 Tue, 17 Apr 2018 16:18:24 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Tue, 17 Apr 2018 16:18:24 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=YYr+ZUVFbWMwZYgUXuWlnNlmh9
 107LelqjXrl8+d0Oo=; b=S/PSDZirtjMZNA0H0mRE7tyzKYZWSRSZt4jWtzVbmA
 ZIm/TGmJpTWtcdE5zqFYngehocLgYTeQznY3bXGkGxedcCv8vPbTfdPPTUTkPkGG
 m8L2IXNTuINWML8s2I62/AHAd9/H+LYV1178Am08zMtT9KKdum8DWCNz4pXwb07R
 g=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=YYr+ZU
 VFbWMwZYgUXuWlnNlmh9107LelqjXrl8+d0Oo=; b=ATejLKyH0AFZGrdOrtCdrL
 W3WjcuWXan09gJQUC5d0vw9K8iL1SxPxnaeCuaz/8YeGu3WHS5SjUOVbtxUmP+9J
 XiLjS+aJbYrlo1wWtC/eGzc3e9x5GUyJG/+W9+CetFHXvRZ6RB0WdD2AilXW9ONQ
 eq7DeIMiXa3iM2TlAr0xPkpbI1ttZ8MVo5Kc9JkeVi15qGRlPwqxg20sS7t/aDKL
 fguaBzCR0yU3xBbxBcX3hE4I283AHlGni6rSUGk4e9gSJJXH0TZ+6z915HwlgnSF
 4maOQ5iCFm7QAGSWmZeDH6U/rR5YwHeqbbZCPX3I2DXKTaE0qmDaHyvxVeKQNubQ
 ==
X-ME-Sender: <xms:kFbWWqzvXVXKizHCmBM_b1Xx1YNUQSOEgFDDYhW16vE6c8biRgLQwQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 1116EE4120;
 Tue, 17 Apr 2018 16:18:23 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
Date: Tue, 17 Apr 2018 22:18:22 +0200
Message-ID: <6000733.QRpK3ykViv@xps>
In-Reply-To: <20180416150525.2817-7-adrien.mazarguil@6wind.com>
References: <20180410162022.9101-1-adrien.mazarguil@6wind.com>
 <20180416150525.2817-1-adrien.mazarguil@6wind.com>
 <20180416150525.2817-7-adrien.mazarguil@6wind.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v4 06/16] ethdev: remove C99 flexible arrays
	from flow API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Apr 2018 20:18:25 -0000

16/04/2018 18:22, Adrien Mazarguil:
> This patch replaces C99-style flexible arrays in struct rte_flow_action_rss
> and struct rte_flow_item_raw with standard pointers to the same data.
> 
> They proved difficult to use in the field (e.g. no possibility of static
> initialization) and unsuitable for C++ applications.
> 
> Affected PMDs and examples are updated accordingly.
> 
> This breaks ABI compatibility for the following public functions:
> 
> - rte_flow_copy()
> - rte_flow_create()
> - rte_flow_query()
> - rte_flow_validate()
> 
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> ---
>  app/test-pmd/cmdline_flow.c        | 117 +++++++++++++++++---------------
>  app/test-pmd/config.c              |  25 ++++---
>  doc/guides/prog_guide/rte_flow.rst |  18 ++---
>  drivers/net/mlx4/mlx4_flow.c       |  22 +++---
>  drivers/net/mlx5/mlx5_flow.c       |  20 +++---
>  examples/ipsec-secgw/ipsec.c       |  17 ++---
>  lib/librte_ether/rte_flow.c        |  25 ++++---
>  lib/librte_ether/rte_flow.h        |   8 ++-
>  8 files changed, 135 insertions(+), 117 deletions(-)

There are almost as much insertions as deletions.
So it's probably not a bad move.

Acked-by: Thomas Monjalon <thomas@monjalon.net>