From: Thomas Monjalon <thomas@monjalon.net>
To: Akhil Goyal <gakhil@marvell.com>
Cc: dev@dpdk.org, Ray Kinsella <mdr@ashroe.eu>,
Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
Anoob Joseph <anoobj@marvell.com>,
Abhinandan Gujjar <abhinandan.gujjar@intel.com>,
Ankur Dwivedi <adwivedi@marvell.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Aaron Conole <aconole@redhat.com>, dpdklab <dpdklab@iol.unh.edu>,
Lincoln Lavoie <lylavoie@iol.unh.edu>,
Shijith Thotton <sthotton@marvell.com>,
David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/2] drivers: add octeontx crypto adapter framework
Date: Wed, 21 Jul 2021 11:44:20 +0200 [thread overview]
Message-ID: <6005170.NIlMa9dU7d@thomas> (raw)
In-Reply-To: <CAJFAV8wv3GroHnz=2qZ+sUMNoSnfuWxcsr3s6vrOWjhbi224eQ@mail.gmail.com>
20/07/2021 14:14, David Marchand:
> On Tue, Jul 20, 2021 at 1:59 PM Akhil Goyal <gakhil@marvell.com> wrote:
> >
> > Hi David,
> > >
> > > > > deps += ['common_octeontx', 'mempool_octeontx', 'bus_vdev',
> > > > 'net_octeontx']
> > > > > +deps += ['crypto_octeontx']
> > > >
> > > > This extra dependency resulted in disabling the event/octeontx driver
> > > > in FreeBSD, since crypto/octeontx only builds on Linux.
> > > > Removing hw support triggers a ABI failure for FreeBSD.
> > > >
> > > >
> > > > - This had been reported by UNH CI:
> > > > http://mails.dpdk.org/archives/test-report/2021-June/200637.html
> > > > It seems the result has been ignored but it should have at least
> > > > raised some discussion.
> > > >
> > > This was highlighted to CI ML
> > > http://patches.dpdk.org/project/dpdk/patch/0686a7c3fb3a22e37378a8545b
> > > c37bce04f4c391.1624481225.git.sthotton@marvell.com/
> > >
> > > but I think I missed to take the follow up with Brandon and applied the patch
> > > as it did not look an issue to me as octeon drivers are not currently built on
> > > FreeBSD.
> > > Not sure why event driver is getting built there.
> > >
> > > >
> > > > - I asked UNH to stop testing FreeBSD abi for now, waiting to get the
> > > > main branch fixed.
> > > >
> > > > I don't have the time to look at this, please can you work on it?
> > > >
> > > > Several options:
> > > > * crypto/octeontx is made so that it compiles on FreeBSD,
> > > > * the abi check is extended to have exceptions per OS,
> > > > * the FreeBSD abi reference is regenerated at UNH not to have those
> > > > drivers in it (not sure it is doable),
> > >
> > > Thanks for the suggestions, we are working on it to resolve this as soon as
> > > possible.
> > > We may need to add exception in ABI checking so that it does not shout if a
> > > PMD
> > > is not compiled.
> > Can we have below change? Will it work to disable compilation of
> > event/octeontx2 for FreeBSD? I believe this was done by mistake earlier
> > as all other octeontx2 drivers are compiled off on platforms other than Linux.
> >
> > diff --git a/drivers/event/octeontx2/meson.build b/drivers/event/octeontx2/meson.build
> > index 96ebb1f2e7..1ebc51f73f 100644
> > --- a/drivers/event/octeontx2/meson.build
> > +++ b/drivers/event/octeontx2/meson.build
> > @@ -2,7 +2,7 @@
> > # Copyright(C) 2019 Marvell International Ltd.
> > #
> >
> > -if not dpdk_conf.get('RTE_ARCH_64')
> > +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
> > build = false
> > reason = 'only supported on 64-bit'
> > subdir_done()
>
> I did not suggest this possibility.
> That's the same as for other octeon drivers, such change has been
> deferred to 21.11.
> https://patches.dpdk.org/project/dpdk/list/?series=15885
>
> >
> > Or of this does not work, then we would need to add exception in ABI checking.
> > Any suggestions how to do this?
>
> Sorry, no good idea from me.
We would need to revert the change breaking the ABI test.
But I don't understand why it seems passing in recent CI runs?
next prev parent reply other threads:[~2021-07-21 9:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 16:48 [dpdk-dev] [PATCH 0/2] OCTEONTX crypto adapter support Shijith Thotton
2021-06-22 16:48 ` [dpdk-dev] [PATCH 1/2] drivers: add octeontx crypto adapter framework Shijith Thotton
2021-06-22 16:48 ` [dpdk-dev] [PATCH 2/2] drivers: add octeontx crypto adapter data path Shijith Thotton
2021-07-06 20:20 ` Akhil Goyal
2021-06-23 20:53 ` [dpdk-dev] [PATCH v2 0/2] OCTEONTX crypto adapter support Shijith Thotton
2021-06-23 20:53 ` [dpdk-dev] [PATCH v2 1/2] drivers: add octeontx crypto adapter framework Shijith Thotton
2021-07-06 20:14 ` Akhil Goyal
2021-07-15 14:21 ` David Marchand
2021-07-16 8:39 ` [dpdk-dev] [EXT] " Akhil Goyal
2021-07-20 11:58 ` Akhil Goyal
2021-07-20 12:14 ` David Marchand
2021-07-21 9:44 ` Thomas Monjalon [this message]
2021-07-21 15:11 ` Brandon Lo
2021-07-22 7:45 ` Akhil Goyal
2021-07-22 9:06 ` [dpdk-dev] [PATCH] crypto/octeontx: enable build on non Linux OS Shijith Thotton
2021-07-22 9:17 ` Akhil Goyal
2021-07-22 19:06 ` Thomas Monjalon
2021-07-22 19:08 ` Thomas Monjalon
2021-07-22 20:20 ` Brandon Lo
2021-07-22 20:32 ` Thomas Monjalon
2021-06-23 20:53 ` [dpdk-dev] [PATCH v2 2/2] drivers: add octeontx crypto adapter data path Shijith Thotton
2021-06-30 8:54 ` Akhil Goyal
2021-06-30 16:23 ` [dpdk-dev] [dpdk-ci] " Brandon Lo
2021-07-07 9:28 ` [dpdk-dev] [PATCH v2 0/2] OCTEONTX crypto adapter support Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6005170.NIlMa9dU7d@thomas \
--to=thomas@monjalon.net \
--cc=abhinandan.gujjar@intel.com \
--cc=aconole@redhat.com \
--cc=adwivedi@marvell.com \
--cc=anoobj@marvell.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dpdklab@iol.unh.edu \
--cc=gakhil@marvell.com \
--cc=jerinj@marvell.com \
--cc=lylavoie@iol.unh.edu \
--cc=mdr@ashroe.eu \
--cc=pbhagavatula@marvell.com \
--cc=sthotton@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).