From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 7EBBAA0C50;
Wed, 21 Jul 2021 11:44:12 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 157494014E;
Wed, 21 Jul 2021 11:44:12 +0200 (CEST)
Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com
[66.111.4.221]) by mails.dpdk.org (Postfix) with ESMTP id BE9C840143
for <dev@dpdk.org>; Wed, 21 Jul 2021 11:44:10 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailnew.nyi.internal (Postfix) with ESMTP id 2385E580A7D;
Wed, 21 Jul 2021 05:44:10 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute1.internal (MEProxy); Wed, 21 Jul 2021 05:44:10 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm1; bh=
nFYpFNC2bmgJyqYx4mh1ru7XZlgDwRZWd4QUJL65nvU=; b=rGqUVCxBOWWsk/PG
tGDNRv/VBs7LWJgBohBeQ4bwNxuDR4Peg3Y0C+fdjOJCRdEYuKzOhPRa6DOJ2QzV
eMOIH1ydBw5GBZLHv2GB4kELfYOfd86uPjqQl8Gwp20MQlrKaH+ccq2DdlxH2wdK
rnGmbYD2Qb3ftL6tN1WGYqefLrxynHBfnb3yLqyC6idtO90Y+StGHoHZwE5/eueX
Dn0QXqgJeq+vC2yZElnFeG0hcutUkXS4KP4zqG89OodQmomBDrOaWR4+nQ1IcGtr
WtFPwXjKAFN06rX2kp9lodB0V/ySCOzy0cf7fIFsXetzWDxPf4ByWICQt7M1sHI/
JZcXVg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm3; bh=nFYpFNC2bmgJyqYx4mh1ru7XZlgDwRZWd4QUJL65n
vU=; b=f0w22wCzKdwFoB+uKvTSw95EYdBhuoMr5tIDLZR8opKZK7ZVhgnIiL1DM
Nrn8WcSjCqK+LCPSzRHs0fSFbjT1caJmjg6m8metEysH2b2OPD9Z7K//z59Y5ek8
mSx4GxrJC+Ougs7IkHMAWK6AiO7BDqoJQwHOrRD8EJhIx/ngxAr3Zj1bH6kJK/+a
K4rCqT97U/OGqGojztbQ53FTUBZyBgRhdM0DF5N6PpXR2jSBOJ+b3vpyQqHK+dTg
cSABFbscU4Rvwjgw9yagpS+HB1mbPDTZbQyBxDI/9N5gpbW8XncIjWB2zT9tIDCM
H9vGoJ64HXmMP/XRGzO9avZubX2EQ==
X-ME-Sender: <xms:aez3YNS__p9j9qBs1V1gMjWYrNlQXLf_xiPiU7zvp74f_eXiNl_yNQ>
<xme:aez3YGxBNvcOFc1Lc-E3VZE3ZmIBbEaT_0yvlLADlYCLP5p7atdiCByEpl0wJf_vS
4erYh78xvjkTx6slw>
X-ME-Received: <xmr:aez3YC070e_J7GgI0cDbWACvhonV0WDVn1Sx6udrDo1FBtQpuZD70iM2D2SZ9iPqxB1eJDJRqLXUdSu-UgSoFRVnxA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrfeeggddukecutefuodetggdotefrodftvf
curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf
frrghtthgvrhhnpeffvdffjeeuteelfeeileduudeugfetjeelveefkeejfeeigeehteff
vdekfeegudenucffohhmrghinhepughpughkrdhorhhgnecuvehluhhsthgvrhfuihiivg
eptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdr
nhgvth
X-ME-Proxy: <xmx:aez3YFAMoO8A9Pdls-RcNLKZGdPtZDLBX41zHT_AnDIoIeU39DSkkw>
<xmx:aez3YGjiOMgiJplBAjxA3SC815bU-QxopWiZHjg2AAPpLzDY-171zQ>
<xmx:aez3YJpyaMQcX6X8BtFASlpJPbslngTvAGhfkWI4COlx7FydJMsG6Q>
<xmx:auz3YNpfyJuY2oHVgltXkijcmTnMbO5aQjwZYnGCLaitWHxKJlAQpQ>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
21 Jul 2021 05:44:07 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Akhil Goyal <gakhil@marvell.com>
Cc: dev@dpdk.org, Ray Kinsella <mdr@ashroe.eu>,
Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
Anoob Joseph <anoobj@marvell.com>,
Abhinandan Gujjar <abhinandan.gujjar@intel.com>,
Ankur Dwivedi <adwivedi@marvell.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Aaron Conole <aconole@redhat.com>, dpdklab <dpdklab@iol.unh.edu>,
Lincoln Lavoie <lylavoie@iol.unh.edu>, Shijith Thotton <sthotton@marvell.com>,
David Marchand <david.marchand@redhat.com>
Date: Wed, 21 Jul 2021 11:44:20 +0200
Message-ID: <6005170.NIlMa9dU7d@thomas>
In-Reply-To: <CAJFAV8wv3GroHnz=2qZ+sUMNoSnfuWxcsr3s6vrOWjhbi224eQ@mail.gmail.com>
References: <cover.1624379833.git.sthotton@marvell.com>
<CO6PR18MB4484ECDA4E22895BA65B64C2D8E29@CO6PR18MB4484.namprd18.prod.outlook.com>
<CAJFAV8wv3GroHnz=2qZ+sUMNoSnfuWxcsr3s6vrOWjhbi224eQ@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/2] drivers: add octeontx
crypto adapter framework
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
20/07/2021 14:14, David Marchand:
> On Tue, Jul 20, 2021 at 1:59 PM Akhil Goyal <gakhil@marvell.com> wrote:
> >
> > Hi David,
> > >
> > > > > deps += ['common_octeontx', 'mempool_octeontx', 'bus_vdev',
> > > > 'net_octeontx']
> > > > > +deps += ['crypto_octeontx']
> > > >
> > > > This extra dependency resulted in disabling the event/octeontx driver
> > > > in FreeBSD, since crypto/octeontx only builds on Linux.
> > > > Removing hw support triggers a ABI failure for FreeBSD.
> > > >
> > > >
> > > > - This had been reported by UNH CI:
> > > > http://mails.dpdk.org/archives/test-report/2021-June/200637.html
> > > > It seems the result has been ignored but it should have at least
> > > > raised some discussion.
> > > >
> > > This was highlighted to CI ML
> > > http://patches.dpdk.org/project/dpdk/patch/0686a7c3fb3a22e37378a8545b
> > > c37bce04f4c391.1624481225.git.sthotton@marvell.com/
> > >
> > > but I think I missed to take the follow up with Brandon and applied the patch
> > > as it did not look an issue to me as octeon drivers are not currently built on
> > > FreeBSD.
> > > Not sure why event driver is getting built there.
> > >
> > > >
> > > > - I asked UNH to stop testing FreeBSD abi for now, waiting to get the
> > > > main branch fixed.
> > > >
> > > > I don't have the time to look at this, please can you work on it?
> > > >
> > > > Several options:
> > > > * crypto/octeontx is made so that it compiles on FreeBSD,
> > > > * the abi check is extended to have exceptions per OS,
> > > > * the FreeBSD abi reference is regenerated at UNH not to have those
> > > > drivers in it (not sure it is doable),
> > >
> > > Thanks for the suggestions, we are working on it to resolve this as soon as
> > > possible.
> > > We may need to add exception in ABI checking so that it does not shout if a
> > > PMD
> > > is not compiled.
> > Can we have below change? Will it work to disable compilation of
> > event/octeontx2 for FreeBSD? I believe this was done by mistake earlier
> > as all other octeontx2 drivers are compiled off on platforms other than Linux.
> >
> > diff --git a/drivers/event/octeontx2/meson.build b/drivers/event/octeontx2/meson.build
> > index 96ebb1f2e7..1ebc51f73f 100644
> > --- a/drivers/event/octeontx2/meson.build
> > +++ b/drivers/event/octeontx2/meson.build
> > @@ -2,7 +2,7 @@
> > # Copyright(C) 2019 Marvell International Ltd.
> > #
> >
> > -if not dpdk_conf.get('RTE_ARCH_64')
> > +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
> > build = false
> > reason = 'only supported on 64-bit'
> > subdir_done()
>
> I did not suggest this possibility.
> That's the same as for other octeon drivers, such change has been
> deferred to 21.11.
> https://patches.dpdk.org/project/dpdk/list/?series=15885
>
> >
> > Or of this does not work, then we would need to add exception in ABI checking.
> > Any suggestions how to do this?
>
> Sorry, no good idea from me.
We would need to revert the change breaking the ABI test.
But I don't understand why it seems passing in recent CI runs?