From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50C05A00C5; Thu, 7 May 2020 12:17:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0C5FD1DA9C; Thu, 7 May 2020 12:17:00 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 4E4661DA9A for ; Thu, 7 May 2020 12:16:57 +0200 (CEST) IronPort-SDR: XckxHQOdnTae2qxlCvJklvOeZzLD80Ja0rpkR6RWtSSXiOcmuM9OGFYiemEORwznjlJeDG7liU cM+TFJKdXZIg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2020 03:16:56 -0700 IronPort-SDR: Gd1tslA6zMZqv3ibRMfaThI2M8YUZankistJRHt5iOcFafMnCIRXps0+x3+v7lWR73fSv8hhfX V7/lxFAFvgWg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,363,1583222400"; d="scan'208";a="250051191" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga007.fm.intel.com with ESMTP; 07 May 2020 03:16:56 -0700 Received: from hasmsx601.ger.corp.intel.com (10.184.107.141) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 May 2020 03:16:56 -0700 Received: from hasmsx603.ger.corp.intel.com (10.184.107.143) by HASMSX601.ger.corp.intel.com (10.184.107.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 7 May 2020 13:16:53 +0300 Received: from hasmsx603.ger.corp.intel.com ([10.184.107.143]) by HASMSX603.ger.corp.intel.com ([10.184.107.143]) with mapi id 15.01.1713.004; Thu, 7 May 2020 13:16:53 +0300 From: "Stojaczyk, Dariusz" To: "Richardson, Bruce" CC: "dev@dpdk.org" Thread-Topic: [PATCH] build: don't parse build configs of explicitly disabled drivers Thread-Index: AQHWA0/Vw1H7cnVRWkOgcLsB1NLez6hg/AcAgDuuDkA= Date: Thu, 7 May 2020 10:16:53 +0000 Message-ID: <601ee8a91beb4fe7a9b9b0a686db034a@intel.com> References: <20200326092259.33957-1-dariusz.stojaczyk@intel.com> <20200330135238.GB132@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20200330135238.GB132@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action x-originating-ip: [163.33.253.164] Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] build: don't parse build configs of explicitly disabled drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Bruce Richardson > Sent: Monday, March 30, 2020 3:53 PM > To: Stojaczyk, Dariusz > Cc: dev@dpdk.org > Subject: Re: [PATCH] build: don't parse build configs of explicitly disab= led > drivers >=20 > [SNIP] > > Looking at this code and the meson docs again, I think this block and > previous can be simplified by using the array "contains()" method to avoi= d > the loop. >=20 > if disabled_drivers.contains(drv_path) > build =3D false > reson =3D '....' > else > # pull in driver ... > subdir(drv_path) > endif >=20 > Regards, > /Bruce Oops, I haven't seen that mail. Sorry! I just pushed v2. D.