From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 5EFC52A6C for ; Wed, 29 Jun 2016 13:25:40 +0200 (CEST) Received: by mail-wm0-f49.google.com with SMTP id 187so32892620wmz.1 for ; Wed, 29 Jun 2016 04:25:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=AoM60Z10ToPLzUSU5YqWBVNyeJp4SqfJRj3Oky8wn9Q=; b=aPACxx1oiuSy/IGcG9TufrTeeOtUZSeVMcgKP21dxfDSSnFcmkK0fvyXfnCkwFr7UH ny3sAeXVX4I0UbEJhKRGdp2Yk6DcIwsMwUmb1psU0Jb8SZiGrSYlN7wAGUdRL9dSeTPe IaNAS2IJDPH9rC8HqX8048o4K+Hn2aM+BzbTC0nbFr1S7G7icajTpQ537h/huvYX1KHJ RgN6L2zpgEDtbGZZS5aE+HuWek0y4Y0Og/0FK4ABQacJ6KNj1Ul/5Q73elij4uLhpn4j RddHeXFsylwRGSTbgsxU+tpUFK1wgosi0KP/52HvOlKWqiA/SzU/kJ9gK9xdzKmMEW9b F17w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=AoM60Z10ToPLzUSU5YqWBVNyeJp4SqfJRj3Oky8wn9Q=; b=KkQEoZ7ikVORvxBnuxeBry+IkRDjbRVTG1OIywpj1pInUopWIGTj2ESYDyyepMxahb jnmOymiOtvQ6aXD5fDhKFOXSj1WMhvEk7JdwsNDmPPsxlyRsLfpNMKnTXKSDa0V14XSp gr/92oCGQmTe13Yuj4D3iIMGJV9LOfHGl5cV+OGSMbgZXubMim2ONuJUuuS5SwpUtxEh 0cCHeth2b1L+7upk09LNuctSO4Op7aSVms1atX5One9NtrimqngLPZMkhjSaorHbhK+b f39EDEuUDn7cPqjGEUXdHS26VrvGWS11cAZsCo5ABVYkyl/Wk+B+s6xtYNf/n+0u3iON NkZw== X-Gm-Message-State: ALyK8tIkQdmeiHrrAEhOg3uwV5B46PsnKXzeVjUXf9GZczNvatBahOPBBbcFiJ1Pgf3TwMnq X-Received: by 10.28.154.214 with SMTP id c205mr21810243wme.9.1467199540193; Wed, 29 Jun 2016 04:25:40 -0700 (PDT) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id g10sm3222122wjl.25.2016.06.29.04.25.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Jun 2016 04:25:39 -0700 (PDT) From: Thomas Monjalon To: Jerin Jacob Cc: dev@dpdk.org, bruce.richardson@intel.com, jianbo.liu@linaro.org, huawei.xie@intel.com, yuanhan.liu@linux.intel.com Date: Wed, 29 Jun 2016 13:25:35 +0200 Message-ID: <6020070.DOjM99b0E6@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160629111848.GA5301@localhost.localdomain> References: <1467028448-8914-1-git-send-email-jerin.jacob@caviumnetworks.com> <3436400.asiby3BQPB@xps13> <20160629111848.GA5301@localhost.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/4] virtio: introduce RTE_LIBRTE_VIRTIO_INC_VECTOR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jun 2016 11:25:40 -0000 2016-06-29 16:48, Jerin Jacob: > On Mon, Jun 27, 2016 at 04:59:42PM +0200, Thomas Monjalon wrote: > > 2016-06-27 20:18, Jerin Jacob: > > > On Mon, Jun 27, 2016 at 04:19:57PM +0200, Thomas Monjalon wrote: > > > > 2016-06-27 17:24, Jerin Jacob: > > > > > --- a/config/common_base > > > > > +++ b/config/common_base > > > > > @@ -267,6 +267,7 @@ CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_RX=n > > > > > CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_TX=n > > > > > CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DRIVER=n > > > > > CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DUMP=n > > > > > +CONFIG_RTE_LIBRTE_VIRTIO_INC_VECTOR=y > > > > > > > > I don't remember what means INC_VECTOR? > > > > Why a config option is needed for vector implementations? > > > > > > I thought of adding additional configuration option(INC_VECTOR) _apart_ from > > > cpu flag based scheme in the patch because even though if a given platform > > > has cpu instruction support, in some platforms scalar version may > > > perform well wrt vector version(based on instruction latency, emulation required or not > > > etc). So a top level flag INC_VECTOR, can override the vector selection > > > for a given platform if required. > > > > Isn't it a runtime driver option needed to disable vector virtio? > > > > > Regarding INC_VECTOR(INC in vector configuration name, I have no idea, I > > > followed the existing flags) > > > $ grep "INC_VECTOR" config/common_base > > > CONFIG_RTE_IXGBE_INC_VECTOR=y > > > CONFIG_RTE_LIBRTE_I40E_INC_VECTOR=y > > > CONFIG_RTE_LIBRTE_FM10K_INC_VECTOR=y > > > > If the flag is really needed I would suggest VIRTIO_VECTOR. > > OK I will change to VIRTIO_VECTOR I would prefer a runtime option.