From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8205E41CB3; Thu, 16 Feb 2023 18:05:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6012B40F18; Thu, 16 Feb 2023 18:05:46 +0100 (CET) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2080.outbound.protection.outlook.com [40.107.95.80]) by mails.dpdk.org (Postfix) with ESMTP id 2E1AB40EE3 for ; Thu, 16 Feb 2023 18:05:45 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YtevQnXLaXR0VZXpS00nnCC8H8+fCQmFoA81LnxDV2OqCxXRvEMabXCBxnrpYl6kZYqSzFLZZTtC8v0ejIyraUlNHzyGGSyj8fJ1mN0L7n/t/NJkIBACK30Ik+RkpRT//0NVV024owoMX8NldA1r/Vw9OQy4WbyZx5l6UEoepEPtRkuiVgFKSrmVVYpYqJfV6W8ctkBuoBMyIJY6MMZwuG9f2X+0TAL6eGeuxQQRcxyUJA+loq38XBXvg15sc+56a6DYmRVrYE3FnzSnDv/asHAaaF/mtzMWfLnU/KfN0a/GgsFGYEtBnAJmWn+WqHicpobxlQ+o/aC/GDU00TfT/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S6XrQkgV8YL15wucPaWz94ln4HRNXmty+OCg8smMd8k=; b=BkwCQyNVVcVG2dY+BhG4L4qgvvrF06SorXiVPV7yNSj+5neZFlOlLxK4HDrhY2Q3li1sAFKK1saUQiNcBJGmk9aS86tRV4bN+sM1Cr2V9aZ74eagZ4Lyzr/fsuCJQ+TC8hKYJZeh8F87PTVefXR0/JDOct5hAkHP0E+y+fiLPklxMVSyut45iPsI3Q/4ZgwZWPGDFut/nRD588JiT6R0vAuYMoGZI6TZuyWWWiowKWoCJH/IRdEH94qcD60i0quBMFvpPgxKRfuHeeMSzu5jr7tgjcyQlISg2ZdQ0/RRwyzZKBwnpxid4TrDYwr3ce8REdatgPuqQ2vGG5OpKd46cA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S6XrQkgV8YL15wucPaWz94ln4HRNXmty+OCg8smMd8k=; b=ChTxUNv8bZVpOmFfVS2cJSrB3dTRXprhoBvWP3adTeKc6/ySHTTAWbyHUVjdbkXeT5FszjEAhoW3MYTK3FmlHd4lZH3pZTiMp5Zizt6CtkrHuRk82uKFPOT3lDjFX5ZE4WpSwUWZYBVdDnwLqUGaH2BZS00HztK1QxE3EYjeuVw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB8056.namprd12.prod.outlook.com (2603:10b6:510:269::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Thu, 16 Feb 2023 17:05:43 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%7]) with mapi id 15.20.6111.013; Thu, 16 Feb 2023 17:05:43 +0000 Message-ID: <60234089-2b1e-28a6-4f5f-2b72a3fb847d@amd.com> Date: Thu, 16 Feb 2023 17:05:36 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Long Wu References: <20230216071514.29418-1-chaoyong.he@corigine.com> <20230216083231.4721-1-chaoyong.he@corigine.com> <20230216083231.4721-3-chaoyong.he@corigine.com> From: Ferruh Yigit Subject: Re: [PATCH v2 2/2] app/testpmd: add support for bonding port's LACP negotiation In-Reply-To: <20230216083231.4721-3-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P302CA0009.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:2c2::17) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB8056:EE_ X-MS-Office365-Filtering-Correlation-Id: f0230c43-890e-4b54-451d-08db104009a0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ThoL5mPprTn1XqlywlOlNqPS3U76cg312tPDfMYy83MjwB81fxQANmUPPzJVaRCzD6+m13qjkihULnS0VbhGzoOhznf7VExh5lnoKIKvaAVafDkSGUXxhcAsPT6pGnXBp1vLEh9MveJEFOLvsoVl9LZjnU/Tnnf27G2DR+15j54LORoQQEh34Gg3JSMdoDqH/3IbvrRC89rp+OoHirLWAb8ubyK9N4fkQh8mdgETtlpoN51doaLseTV4mmiEEsprDThyh12iviB6h01A0cuQMxhRP1oyldHcqQuGGOPq1yB/H+QWoF9HaybuVKJsjwFIIVzgaJurZekKBACLTURIgWdA46xugkmYesu5FuRS2DW1pa+O0IxW0kD3AAqY75geVcLcLgKOh+y/5ez71waLtX1ormfKZahgxruuCxVfiKNDQAq4M3ntkDlkk/lrAMphfFGTf3fnTDBuNyxN9yQt1iYGt5hz0CcleYvsFpOf/XSWVdm+Pr/u+m5JqkVcyLC3AOKASJW2jspsLYIDnz6NuVzf/hMiXoIWMXfZkdvdGEHpAomv1DUwU8PFAp4GBJLv18gm0dgFt9VTrGCJRzF7BkQ+cf0J1VKFXla00PW80r3Us8Ebcmvqwp/5KlPWN52z3TWgjP5d3UwEXFRoWsoOAuGU3daxLlm/CjGynWYJzjBnsWB8fCHDxUWUpw6YOThcqKAiSNAlg/ZpKhGEMc6R1MLGTPf1aKlG4tQtfTnpa/w= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(396003)(346002)(136003)(376002)(39860400002)(366004)(451199018)(8936002)(41300700001)(83380400001)(66574015)(6486002)(31696002)(186003)(86362001)(478600001)(26005)(6512007)(6666004)(53546011)(6506007)(2616005)(36756003)(4326008)(66946007)(66476007)(38100700002)(8676002)(66556008)(316002)(44832011)(31686004)(2906002)(5660300002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bVhaWnZSVzdWQmlzM1RLK3BTcmFtRDNkZ2Y4eEJUSFhtaXVKWXZIV1I2Y001?= =?utf-8?B?YSs1UUV4UXlSWjE3ek82eFhGdlJBZDU5Rm1IMVlmTDE3Zk8rWDZ2WjFiR0Jx?= =?utf-8?B?c04yeXRpQ05qTXhrVlNmNU5aT2hmRHFKMGpsV0lZY3BCaWVtaGFpT1c2T1Rw?= =?utf-8?B?OWJjY0QvK1dQNUNEek9CQWxhVmhxeDNMOVROb09ZNlY5UDdpK01hbjFXRDFX?= =?utf-8?B?Q0xZazVOY0RmSjRvazBOdjE0cGgxOHhVZzdJUitteTYrdUIzZHFVMWt1cGE0?= =?utf-8?B?a0QzUDkrZTFabjE2RW5CanpvUnNlNDgzTU56UGdVUkUya3JCZHVMYy8wb0kz?= =?utf-8?B?cXE2bUxaVWFlNlFUSTN0K2x4V3R0b0IvcWlVOTVvSHVjTmZSYTdkSzJKeVhM?= =?utf-8?B?ZXJrZ1NCWHRIWkNGYTBBejQ3NzJ5SXRZNUQ5aDl0VTk5TTZJSGNrelZYdFpH?= =?utf-8?B?cTZaU0RxWlB0c1JCaUR3aDAxOXliQ3p4cFFXNFRJUjJGN0ZjUlNtdnZMK1lz?= =?utf-8?B?ZDFMeVREczVhNStpU0w2aXRTMlRvY3NxWEZ6R0dpKy9lb3dMZUN3QzA5SVlE?= =?utf-8?B?YnVWSGpHNFBVYVlIYUJvWk84aXJvVTZvNDRHKzBSS0tyeFdGL25Qb0RqUXFC?= =?utf-8?B?bzIyZkllWTJ6cktLbzMxWkpIRzNtd3RGelF6UDhxNWh5VGZrRUNtcFpxQ1gr?= =?utf-8?B?bXZMTXlvai9KV09ibVI1TDFIdFRjMm4yZ004aGMySTVuMHVFelhzR2RnZnha?= =?utf-8?B?T25MZm9xblF0WjE3NXNWS3FEeTBxSExNSm1aVEVhQVFzVkpBR3JmWE4vTitk?= =?utf-8?B?V0NhVitEQmtDMXlkWjF3UUZ0L3RJVlMrMDdUdXFxNUd0NDEySHhncnQzSDUx?= =?utf-8?B?M1E1V3d0dmxON0xoRjFiWGFYNi9meWpERUxwSUtoajJmSjZybzdKMmlkZHV6?= =?utf-8?B?MGVPUlUxTXhRSzg4UmYwalpsM0hjOGRKZUpJTUlkQVdBcGJoMHhGV3ppQUFJ?= =?utf-8?B?aHlreDEyNWZReEpHRGFVdUJ5WWJod2tpVkVSd0UrUjhiTFZYUFVhaldYODFs?= =?utf-8?B?NGw5ZXAzSjRRWXpGY1F2L3JpOE5ETC84eUJ3Z0p3eXRocEhHMXUwL1JkbFcz?= =?utf-8?B?M2FJZHdrNW5qSnZSOUZMcmZrOEtnRVk2ejdKdHJnck56VVJvV3Y3OFR1cGhm?= =?utf-8?B?UTU2V0JMck4rUmZNNndHNzBrUlBrOEwvckZmRkVVNTdFRCtSTkhqZi9vcDBn?= =?utf-8?B?aVZCTVFmbmppWDFwdC9RZHBRZUNiZU85Nkd5UmoxdUV4QXZtRmlKMnFOdGoy?= =?utf-8?B?dkJ5Qm5LSFd3V2VkekdtcXpIcXFFRnlTTmFzU3FLM2gvbHcyTjZaaEE4cStr?= =?utf-8?B?VVZzam9wU1BjYmlCa3JTTEJ1MGlOTVNoVE90dlp2b0hZWkJSbmVNbXNJdFcw?= =?utf-8?B?RTZNTy9QcDlLQ3hRWTN1RXptaytYRk9YYXhGaG5CK25yUzJNRlFaOVU1Y0pS?= =?utf-8?B?VEFJdVFnUHBPeUhrb0g1ZGQ1bzJhY0x5ZlZKZ1VGMEhwTVVtWVVIQzdmREdG?= =?utf-8?B?RFFsUmRXRHA0N1Q3Lyt2b0J5YUw3V2hqSnNQQUROSUNwUVQxMk5PSEJVU2xJ?= =?utf-8?B?NUM0RGRCNjVEZzZVanE4eU9TZ2pVMUJZb3FCTVpBUDA1L1JOejFsTlFpdUFl?= =?utf-8?B?d0xDZXN3Y09idEVWU2FYR2pSU3p5Wk5FWStVOEFZZFpLVjBCN2FmSHUxMmtL?= =?utf-8?B?YzFYVTZxcUFHUk1KNFhIQ3ZYNXJlZUJwYlR3c2FldGprU1FSVENTTzNHbFpC?= =?utf-8?B?bTRKbElzSDlIbVYvT0FWR1V1anhTUUpZZUNGVHBoQURBTzJmWkJjQjBMU012?= =?utf-8?B?eWxUazFHVElFaHdSckVBVWpuODRLcHNVV0MrUGRoVUNrcVdTOUJDRjYvRFZz?= =?utf-8?B?ZGFHWVF4WU1SR0ljVWg0Sk1IaGR0dDUyWVZGUkswemZ3WTMvSTgvN0hhT2sr?= =?utf-8?B?UDVsb0F2UGtCdUlRbWhzVjNMbnpVL3hPaEtjTkp3SEQzQkNnNHp5bE54VG90?= =?utf-8?B?Wm1QNUVkUE9Kc2JqOTdYT1NFdkdDd013QkFaV0lUR0VLRkdORmllbTY4OGVs?= =?utf-8?Q?OB969MsAr0MCIQ29WaYryLirz?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0230c43-890e-4b54-451d-08db104009a0 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 17:05:43.1318 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bBIyyIIDKfayPI/Cco30qtsuSoe1/hstqu3A1fbH0ShSeJ6Ul1rV1icRwkt4Qzad X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8056 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/16/2023 8:32 AM, Chaoyong He wrote: > From: Long Wu > > If bonding port is mode4 with disabling dedicated queue and there > are no other packets, forward loop will not call port's TX function > and bonding port will not send LACP packets. > > Add sending LACP packets periodically in forward loop to avoid > LACP negotiation failed. > > Signed-off-by: Long Wu > Reviewed-by: Niklas Söderlund > Reviewed-by: Chaoyong He > --- > app/test-pmd/config.c | 23 ++++++++++++++ > app/test-pmd/parameters.c | 10 +++++++ > app/test-pmd/testpmd.c | 43 ++++++++++++++++++++++++++- > app/test-pmd/testpmd.h | 9 ++++++ > doc/guides/testpmd_app_ug/run_app.rst | 4 +++ > 5 files changed, 88 insertions(+), 1 deletion(-) Is it possible to have this support in 'drivers/net/bonding/bonding_testpmd.c', to not add PMD specific ifdefs to the generic testpmd code. Like having a bonding specific command etc.. btw, I didn't check the details, just a high level question.