From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id B4E808D90 for ; Wed, 18 Apr 2018 14:15:07 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1C7A521AF8; Wed, 18 Apr 2018 08:15:07 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 18 Apr 2018 08:15:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=gc9PbvBgyDGyPdkJ/+Ce86hi/I 7Omnqmfq4ujS3xw88=; b=dCJun0T27Uphh5sdzjqsJnqSYHwMB6q+9nV/qoABlq 3HHdOEGqNAVSpf5GArAhlr5o4D8S9M/3lYAK08/538IY4a3feSEfWpstwviNv36w tuJM1J+ukf22Cm5hc//Fvmu5KB4r15FuzvgCIbu1lsLfT/B/PNjl+INQJFo3/75Z 0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=gc9Pbv BgyDGyPdkJ/+Ce86hi/I7Omnqmfq4ujS3xw88=; b=KfCvRQOGTlInv3dtyL5vcu VlOkcV4UY5VW3RJhsTUCZRkAd3c310MJYgtljP1fS5sUPd5YsBOBhzFM4yBTlb9l 44W7CufuSucq9zcVxtYikvwXEXLgGWwnXhHqwDbY0CHCU8+0EKbhPkd8YAHiAJCn 3vlvmxSFsK0xG1psXXpi58BXhlJvwosopsKwfvN/yGkVmuSB+rJuocTH9RKGm4c5 KP7kXWIHdd6QGWFSE9Nt0mGwbg347AVfACpop9yz/EEOkylkNToDKlKW7Wm2Fsyt uoGSWSidkwFLgIe6eRidvIjRwbSaPG9sXXdH6vCo4oo4T4qS6wgnT7JJCGvB/86g == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1683BE4122; Wed, 18 Apr 2018 08:15:06 -0400 (EDT) From: Thomas Monjalon To: "Xueming(Steven) Li" Cc: "dev@dpdk.org" , Shahaf Shuler , Nelio Laranjeiro , Wenzhuo Lu , Jingjing Wu Date: Wed, 18 Apr 2018 14:15:04 +0200 Message-ID: <6024675.SqA4AgUrAM@xps> In-Reply-To: References: <20180409121035.148813-1-xuemingl@mellanox.com> <38100809.DTC8XynbX7@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/2] ethdev: add supported hash function check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Apr 2018 12:15:07 -0000 18/04/2018 13:55, Xueming(Steven) Li: > From: Thomas Monjalon > > 17/04/2018 16:24, Xueming Li: > > > + /* Check that device supports requested rss hash functions. */ > > > + if ((dev_info.flow_type_rss_offloads | > > > + dev_conf->rx_adv_conf.rss_conf.rss_hf) != > > > + dev_info.flow_type_rss_offloads) { > > > + RTE_PMD_DEBUG_TRACE("ethdev port_id=%d invalid rss_hf: 0x%lx, valid value: 0x%lx\n", > > > + port_id, > > > + dev_conf->rx_adv_conf.rss_conf.rss_hf, > > > + dev_info.flow_type_rss_offloads); > > > + return -EINVAL; > > > + } > > > > Please use PRIx64 and test 32-bit compilation. > > > > Reminder from this recent post: > > > > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpdk.org%2Fml%2Farchives%2Fdev%2F201 > > 8- > > February%2F090882.html&data=02%7C01%7Cxuemingl%40mellanox.com%7C5508bc716aac41b932fb08d5a4aeb241%7Ca65 > > 2971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636595992591300475&sdata=1hirZ1j7VqCMnrzngZFAuQj42OACfxFUgYgzy > > VQyw%2F4%3D&reserved=0 > > " > > Most of the times, using %l is wrong (except when printing a long). > > So next time you write %l, please think "I am probably wrong". > > " > > Thanks, got following warning from checkpatch when applying this rule to my other patchset, is it normal? > CHECK:CAMELCASE: Avoid CamelCase: > #49: FILE: drivers/net/mlx5/mlx5_flow.c:2083: > + " hash:%" PRIx64 "/%u specs:%hhu(%hu), priority:%hu, type:%d," > Yes it is "normal". Something we should fix in checkpatch.