Re: [PATCH 2/2] baseband/acc: fix common logs

[Maxime Coquelin <maxime.coquelin@redhat.com>]

On 12/18/23 16:43, David Marchand wrote:
> Logs generated by helpers common to acc100 and vrb drivers were
> emitted with a RTE_LOG_NOTICE == 6 == RTE_LOGTYPE_HASH.
> Register a dedicated logtype for this.
> 
> Fixes: 32e8b7ea35dd ("baseband/acc100: refactor to segregate common code")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>   drivers/baseband/acc/acc_common.c | 7 +++++++
>   drivers/baseband/acc/acc_common.h | 4 +++-
>   drivers/baseband/acc/meson.build  | 2 +-
>   3 files changed, 11 insertions(+), 2 deletions(-)
>   create mode 100644 drivers/baseband/acc/acc_common.c
> 
> diff --git a/drivers/baseband/acc/acc_common.c b/drivers/baseband/acc/acc_common.c
> new file mode 100644
> index 0000000000..f8d2b19570
> --- /dev/null
> +++ b/drivers/baseband/acc/acc_common.c
> @@ -0,0 +1,7 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright (c) 2023 Red Hat, Inc.
> + */
> +
> +#include <rte_log.h>
> +
> +RTE_LOG_REGISTER_SUFFIX(acc_common_logtype, common, INFO);
> diff --git a/drivers/baseband/acc/acc_common.h b/drivers/baseband/acc/acc_common.h
> index bda2ad2f7a..fddeb0737b 100644
> --- a/drivers/baseband/acc/acc_common.h
> +++ b/drivers/baseband/acc/acc_common.h
> @@ -150,9 +150,11 @@
>   
>   #define ACC_MAX_FFT_WIN      16
>   
> +extern int acc_common_logtype;
> +
>   /* Helper macro for logging */
>   #define rte_acc_log(level, fmt, ...) \
> -	rte_log(RTE_LOG_ ## level, RTE_LOG_NOTICE, fmt "\n", \
> +	rte_log(RTE_LOG_ ## level, acc_common_logtype, fmt "\n", \
>   		##__VA_ARGS__)
>   
>   /* ACC100 DMA Descriptor triplet */
> diff --git a/drivers/baseband/acc/meson.build b/drivers/baseband/acc/meson.build
> index 449d1e176c..64fcf1537a 100644
> --- a/drivers/baseband/acc/meson.build
> +++ b/drivers/baseband/acc/meson.build
> @@ -24,6 +24,6 @@ endif
>   
>   deps += ['bus_pci']
>   
> -sources = files('rte_acc100_pmd.c', 'rte_vrb_pmd.c')
> +sources = files('acc_common.c', 'rte_acc100_pmd.c', 'rte_vrb_pmd.c')
>   
>   headers = files('rte_acc_cfg.h')

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime