From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DECBB4302C; Thu, 10 Aug 2023 18:49:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B6D3642D12; Thu, 10 Aug 2023 18:49:18 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id 9D33840691 for ; Thu, 10 Aug 2023 18:49:16 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id C74523200413; Thu, 10 Aug 2023 12:49:12 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 10 Aug 2023 12:49:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1691686152; x=1691772552; bh=4p3RbW/YD/+NYCVOl3j+WIX7oQ06I0+b1WY r3sjpXXQ=; b=HBu1LvSeWTGhQq3kx26enXMq7wzCaZsdTESL/ca9ZsVDnCTNjaE WhLnTjdNuckGMSTmATsTMmJyiu/QZThQNI2GlY0ZcCgzp2aunG2LQEd8jPYFW9c7 f9gmF91y9fLMpmoXAUijoFVIXVxxgJb/aabhAf2yqk+EK3KeanpI6FYp/SEVQBmu yO8rQddzPzZfIAW8pvtCPawBHE8gI6fehfoIVjYOyZ/oTU+Ytml003bTWlH7A/z7 mgtk2orM9xtWAm1nh9wpIR5qk4vQcfBLsAlc12/oaAPKpdoyWvDDdA8w0GXFCdAr mNa1PSMBZ0BjllliSBbUl2r8MEemqsiKbUQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1691686152; x=1691772552; bh=4p3RbW/YD/+NYCVOl3j+WIX7oQ06I0+b1WY r3sjpXXQ=; b=KTS4Rl0SFQRWwTQLeYH8OUalhBFx+Tb9IMagr3YhHul8olqN01t RDnhFqVaBGrR/Vmor+F6Hfnk0AZemy48ogON8U7G+OZETnRaz2hLYugVlZixBnhl jcY4Xh61qaROVfa9PrEypP6Canq++MOd8eZ4vOFL3BcXrYUbs+gKmr1WbyLeN8q6 Ub+0zcwBPSnnM58F6Km8mq3g1ygADZc5D2OrFL8OvbEJ9PrTaZ9/5t4tsj/asF3z /9bUakN85I3O8uu+3/N85MbD92rAW8fScbM9r85emeE/FZ6IuK57WAE2EM1ucehF TN/trtps1komNmol1Zor9RDPUEUhFV3aUDA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrleeigddutdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeegtddtleejjeegffekkeektdejvedtheevtdekiedvueeuvdei uddvleevjeeujeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 10 Aug 2023 12:49:10 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger , Bruce Richardson Cc: David Marchand , dev@dpdk.org, Morten =?ISO-8859-1?Q?Br=F8rup?= , Tyler Retzlaff , Ali Alnubani , galco@nvidia.com Subject: Re: [PATCH v5] build: update DPDK to use C11 standard Date: Thu, 10 Aug 2023 18:49:09 +0200 Message-ID: <60418966.matp6XCIr4@thomas> In-Reply-To: References: <20230731103858.1491751-1-bruce.richardson@intel.com> <20230810074839.446f655d@hermes.local> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 10/08/2023 18:35, Bruce Richardson: > On Thu, Aug 10, 2023 at 07:48:39AM -0700, Stephen Hemminger wrote: > > On Thu, 10 Aug 2023 15:34:43 +0200 > > Thomas Monjalon wrote: > >=20 > > > 03/08/2023 15:36, David Marchand: > > > > On Wed, Aug 2, 2023 at 2:32=E2=80=AFPM Bruce Richardson > > > > wrote: =20 > > > > > > > > > > As previously announced, DPDK 23.11 will require a C11 supporting > > > > > compiler and will use the C11 standard in all builds. > > > > > > > > > > Forcing use of the C standard, rather than the standard with > > > > > GNU extensions, means that some posix definitions which are not in > > > > > the C standard are unavailable by default. We fix this by ensuring > > > > > the correct defines or cflags are passed to the components that > > > > > need them. > > > > > > > > > > Signed-off-by: Bruce Richardson > > > > > Acked-by: Morten Br=C3=B8rup > > > > > Acked-by: Tyler Retzlaff =20 > > > > Tested-by: Ali Alnubani > > > >=20 > > > > The CI results look good. > > > >=20 > > > > Applied, thanks! =20 > > >=20 > > > The compiler support is updated, that's fine. > > > Should we go further and document some major Linux distributions? > > > One concern is to make clear RHEL 7 is not supported anymore. > > > Should it be a release note? > > >=20 >=20 > Well, DPDK currently is still building fine on Centos 7 for me, so let's > hold off on claiming anything until it's definitely broken. >=20 > > >=20 > >=20 > > Should be addressed in linux/sys_reqs.rst as well as deprecation notice. > > Also, is it possible to add automated check in build for compiler versi= on? >=20 > I'd be a little careful about what we claim, and I think current docs are > accurate vs our original plans. What we didn't plan to support was the GCC > and Clang compiler versions in RHEL 7, but if one installs an updated GCC, > for example, the build should be fine on RHEL 7. >=20 > Now, though, we are having to re-evaluate our use of stdatomics, which > means we may not actually break RHEL 7 compatibility after all. We'll have > to "watch this space" as the saying goes! >=20 > Overall, I think the approach of build-time checks is the best, but not > for specific versions, but instead for capabilities. If/when we add suppo= rt > for stdatomics to DPDK builds on Linux/BSD, at that point we put in the > initial compiler checks a suitable check for them being present and output > a suitable error if not found. OK looks good