From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4952943E7C; Mon, 15 Apr 2024 19:54:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A52B4028B; Mon, 15 Apr 2024 19:54:30 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2044.outbound.protection.outlook.com [40.107.93.44]) by mails.dpdk.org (Postfix) with ESMTP id C23F94021E for ; Mon, 15 Apr 2024 19:54:28 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jRT1c3egT025Z3tVnCCsqWKJtHW7ZZbqU8957m054bDeLjueTCNmVWkohfubCtKX8e6plYhjuTwqi9Hc4O4mUCM2bLpBSUN9IWmrhxIjy7hEjktMQPChRiTMtgMwIQYe+GigxjkKKdPjNr9oPNy7zqVxSNbATlCpSRhFJ/KWCMQ2LJ483MXKZZeQygCzoJLLtwtdtK5OVLG7efDlbV3IVBpWMu2VhddHIJWziwXsXnScg1cHOOKDVrOqT1ye6ahai4GU8mv2Cea83PbRh4ajPlJxnCDuKPOtZ2RGowPkto49kB7xTNVB9RYbsn6fELODNNUehlgJwLgD1ON7sFE1cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+DH8+MDSx+ADIqtcVPt9ob5SjAnNqWkBepbYmrEMKqw=; b=S86FRvh22hysJ27uUOTLO0p+kcJyxdPymfNIlExU6nj8LjF+3zNzCVYueMxxLMgzKpqbERagBb2DQCJCnkqnvEeKEbXOxC3Y0nFnFBkgqBcOz3x5J8SHG49iLOw70jjDJD9qd020Jo7p76QA2s6QbZuOfU+AWPSxz046AOplh+GURhduKLQ0RAnLlJbI5XCwi4SEDdd/mKwNtiK09Jt/bwZLIEbEwPgnCVwDGT3xs4mS44taZN0TfAHdvMICwnsLbsmm4D4rT6XdOkV77gXtlsJax5OSSgnvr7Hsnj3T3AsxIVvSuJW9VAMAAwdEVaUNh2gB4RkUaS8ub+/bldiS5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+DH8+MDSx+ADIqtcVPt9ob5SjAnNqWkBepbYmrEMKqw=; b=ylkxhKOEzBZ3B0ZlxBwLDod1wJRvSmAaeupu/fHRt67xL3iP7xjFwPTwbI02wA2MCeNXkySnsoIxSFskaxsNIJSEB10otIGCOEYgJEQAVWzWM1ARHmMQzXBfD5YRduM2WXOnZ08jlVZ+kEgpDEtEq6jr1vSZgDXxT4Co9/CRZ8E= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH8PR12MB6724.namprd12.prod.outlook.com (2603:10b6:510:1cf::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.49; Mon, 15 Apr 2024 17:54:25 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3%7]) with mapi id 15.20.7452.049; Mon, 15 Apr 2024 17:54:25 +0000 Message-ID: <6044ccda-9791-4d8c-9549-3e088fa52bbf@amd.com> Date: Mon, 15 Apr 2024 18:54:21 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [EXTERNAL] Re: [PATCH v3] net/netvsc: fix number Tx queues > Rx queues To: Alan Elder , Long Li , Andrew Rybchenko Cc: "dev@dpdk.org" , stephen References: Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0087.eurprd04.prod.outlook.com (2603:10a6:10:232::32) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH8PR12MB6724:EE_ X-MS-Office365-Filtering-Correlation-Id: ea4aa882-8bfd-42e4-aa42-08dc5d7516a2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1Yvc5up5mf8nluYHNtx47L4lZ4vResz271AOAKeaj9y2fYdBjf3zF0ffc/efW57YgkC+Yw0i80Of1QWXCtriK+3t4/UbjyhiK2/4fsc0AKpGxkmB+dRdL1jwIzhdqMQ7iKXWF6c57AaBhlahmcO+hFmS/3ug3AcXP4iwPBXnupKAawyr9PKyAB+i4p2jXKKIgQukVxgFLwJM2NP6rRi7A5Cn76ve0wlCpL12YKx4Xe2dvFGr8ks2CPgIdUVWFAVeucFPLAbrbP250tkoAfK6p3KbgcXbGdlN0SUNOaMvbWsP+Qt/4igJTUZmGD2gihSBrBqY96zPI/s1TvS8tKjgFSYDmiCI8zZn6wkR8/242yj9j8TioEZsovCEiCV7cvZEeZRs9FGPjtOBYCCK9fnxRJjBkYBbyCGA6L+YuTSAus0+bWxt71qwhUUAcz9A+w9Tnjfe/XPotatzc5wk+47tH3Odhll0NJLL+lFaLCZihujJaW3fXirVmvKjhbORfGQlMB3rwIg4a+W5bA7SZQxhJyf0WeFkTJxH9vHyRZnMdowHx6mKp5pdNqhPsN8AugzHoUvQB2V7fGUzIXJjcQehOuCt5GSWmZsbdovIprnR77NBJkeDzdCm2VPUNwRPItakOm8MWqHiK5CL5l9k6cTcfbtJL6mmlf9IfDQs99kYtaA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015)(366007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TjdyOC9TQmNSd2lqcFNHS3lLRC9sT09IWXgrK2FqQnJCdFE1QVRtMlNwU2t4?= =?utf-8?B?OVYyUGlVd3dPNllzYmRFaDlzUlA5R1hHcXpoK3p3L3E3VWlvWlVpVXNBVGtI?= =?utf-8?B?VzJMK0M1UWZ3QVVOTGd0K2VRcWxIbG5wZTZUVllyWXd5M0FLQ1ZiQkFpSElw?= =?utf-8?B?dlZ5d1A2NVdaUW1XR3VjSldUeG40WkdBZllCcEx0V1ZpZlVsWGtpWVAzNm5w?= =?utf-8?B?MVhZdnJHMC9kaWE4RlBNQzcxVHpxcE1nQWNMNGphTWQ3TE9qUWEwc1ZGSjNG?= =?utf-8?B?aUIvRm9kUFJRZkhIZlUzOGIxN0l0TytsalRidlY1Q1BkNDNjNVlkNm8vN1cz?= =?utf-8?B?Yit2VEgzU1U5MFVFbU1FUDZQNnRMQ0JiVkQ3a3BMZUczZGRKdHg3NHZ2Q3Fr?= =?utf-8?B?cCtHT3liUDc1RXRKZGJ4TWJWRFZ1b04xelNTclpBWEhSY0dtRFN5bmFHVmZS?= =?utf-8?B?OGRmV3VzUzBSSVhZcVVSZW5VeWszVzBGL2JQVDdrRHU4T3piOEMxdS9GaUhz?= =?utf-8?B?aGJTaDE2M0k0NldxdXhGdXZyWkJYalRYeXdpUnpNby9iYjJtcHNoaVhnWDlF?= =?utf-8?B?L3dURmdoZDVwV0N5bkt6VmRCc0Y1ZGkrSDFMSFpQVkxsTCsyUENqRnptQnk4?= =?utf-8?B?UnVBcTR6Y3poZXRHaCtpN1RkNE1lZDVGY3B3ZUJ0bEhJbDMvc3M1Q1M3MnQr?= =?utf-8?B?c2lETDFFOFNpMDgweDJTcTdmb1N2RlVGWVZKb1EycjlIdWc1aUdRYlZqTENM?= =?utf-8?B?ajJqU0FkbDZyR0pHaGQxQ1E0WWpGNzRxSmd6Tm1pQWlBWHFBeUxyK25pajFr?= =?utf-8?B?OTExTitJWTExdEovUDRodU9EMEpCOVJaUnMxR3JqajJEemtCblBOdERsUVdi?= =?utf-8?B?RVlaQmRVTFNETnZlMWdXdUxYNld1V0dMRWR2WE1vUFRYcGsrWmhQUW5nQkxq?= =?utf-8?B?RVkrR3doaUpSS1lneW5wcTIxN1lqNGpJclVEdi9WOXBldGFHOUtCRkhmamwv?= =?utf-8?B?dVovWXJwYUZ1dEYvUWxnQUU1ejdQR0F6U3Q3Mmc5cWtmK0dCTnYxK0Z0cS9r?= =?utf-8?B?TjViWEhTU0ZUaStxcWtJazdsMGtNQzdaVkJEVVVidWhlREJ5Qml5RUM5dERR?= =?utf-8?B?NklBOG1oRTB2d295VmVxQnRYWGxOVi9FRHVhMUo5a09KSVlRZ3BmUlh2QU9H?= =?utf-8?B?T29VNWRxWEoweG1HaEZQN2gwYllBVi9Gc210Yk8vckJVS3BGQjRYRjhrazdj?= =?utf-8?B?c2ViY0xKRkZJK21LUTN0TlphNVoyaDREbDZtRXVRc015M0lnM3dtTXZtZWVK?= =?utf-8?B?cnRZLzltWHIzeHlEcUhSd2MrZmJzRml0ZjRncUJCM0xXSUpmWVhMN2I5bjVv?= =?utf-8?B?RFh4Y2dIM2ZHSnlHZVdoRS81cVRsU0xCQVpucHl5Z29saEtKTlFEbmYrcGpS?= =?utf-8?B?Z20xRk1LY3RNbDFtMFg3UnlNNEZneWU2TnNJemozWU9MMWtUT1VyS1QwRmpt?= =?utf-8?B?cDU1bHV1cWwvWjFrZGlGOVZNU0RxUTYyUmkrV1Jib2NLa1ZIa2VpRGVVakh1?= =?utf-8?B?dFBSMFdPcjB0N0RGTnVYM3MrbkF1SGNTWThmRnVYdXJOMjVGakF4Nkp5WmVS?= =?utf-8?B?TEI3S2xFMVJ0eU5lZjJhcE9oVDZRMlczTE5LRzJkOExYL3ZSNmRhbTRYeDlZ?= =?utf-8?B?a013UFN4eWVjcHl5N0hKcERac0JtUktCSXpHRTFST2I0ZnA3UXV1OXRvNkh0?= =?utf-8?B?M3grQStnajlYNERkcXkvczVFY3hpVWtCcFJVVWFNcXdyaGZDY3EvWG5CY2VF?= =?utf-8?B?OFlDTXlibFJpSktxVmFDcFdmbUsyalNncXY2SWpXUGNIaitEL2sxZzRYLzRs?= =?utf-8?B?Zy9hOTFETngwNG5lRFZsUkMrNkcwUjhuWUdpL0I4Ym9xOCt0YStzNEN5R1dh?= =?utf-8?B?d3FvOExZcTFmK0Y1WjVCMkpmSFBNMW5GYkdsazZQUHhRSlNhVlBwOGtnZXZZ?= =?utf-8?B?dlBXVVpkR3BqRW0yRkx6ckx6SU5NRnVIYlQ1bk92ZE53K2lSUVNNUmlGa21a?= =?utf-8?B?Ni9HNTdHcnJKZHVHbGwyczlBcXd1TlRpZ2prQUg1eWhQTldTdFo0YStLWkd2?= =?utf-8?Q?OZkPM7VsYiNztd/afLcpIytYU?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea4aa882-8bfd-42e4-aa42-08dc5d7516a2 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2024 17:54:25.4457 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vXdHv7PqkhmtWd3+/JU/zb13yV+T0LcyUH7ZLiEF9XSx+O+QoVnZw2u2Iol3DCYk X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6724 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/12/2024 5:50 PM, Alan Elder wrote: > > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Friday, April 12, 2024 6:23 AM >> To: Alan Elder ; Long Li ; >> Andrew Rybchenko >> Cc: dev@dpdk.org; stephen >> Subject: Re: [EXTERNAL] Re: [PATCH v3] net/netvsc: fix number Tx queues > Rx >> queues >> >> On 4/11/2024 9:45 PM, Alan Elder wrote: >>>> -----Original Message----- >>>> From: Ferruh Yigit >>>> Sent: Thursday, April 11, 2024 7:38 AM >>>> To: Alan Elder ; Long Li >>>> ; Andrew Rybchenko >>>> >>>> Cc: dev@dpdk.org; stephen >>>> Subject: [EXTERNAL] Re: [PATCH v3] net/netvsc: fix number Tx queues > >>>> Rx queues >>>> >>>> On 3/19/2024 2:16 PM, Alan Elder wrote: >>>>> The previous code allowed the number of Tx queues to be set higher >>>>> than the number of Rx queues. If a packet was sent on a Tx queue >>>>> with index >>>>>> = number Rx queues there was a segfault. >>>>> This commit fixes the issue by creating an Rx queue for every Tx >>>>> queue meaning that an event buffer is allocated to handle receiving >>>>> Tx completion messages. >>>>> >>>>> mbuf pool and Rx ring are not allocated for these additional Rx >>>>> queues and RSS configuration ensures that no packets are received on >> them. >>>>> >>>>> Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device") >>>>> Cc: sthemmin@microsoft.com >>>>> Cc: stable@dpdk.org >>>>> >>>>> Signed-off-by: Alan Elder >>>>> >>>> >>>> Hi Alan, >>>> >>>> What is the root cause of the crash, is it in driver scope or application? >>> >>> Hi Ferruh, >>> >>> The root cause of the crash was in the driver - a packet received on a Tx >> queue that had no corresponding Rx queue would cause the dev->data- >>> rx_queues[] array to be accessed past the length of the array. >>> >>> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith >>> >> ub.com%2FDPDK%2Fdpdk%2Fblob%2Fmain%2Fdrivers%2Fnet%2Fnetvsc%2Fhn >> _rxtx. >>> >> c%23L1071&data=05%7C02%7Calan.elder%40microsoft.com%7C3985f99c07c1 >> 4a64 >>> >> 99fd08dc5ada98d0%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6 >> 3848514 >>> >> 2149539930%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjo >> iV2luMzI >>> >> iLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=Y%2F6lr6v2j4Q >> cSm6g0 >>> dTcV%2FEimyfPs0nMBJ0X5s9omAE%3D&reserved=0 >>> >>> >> >> Why there is an access to Rx queue when processing Tx queue? >> >> A backtrace of the crash can help to understand the issue, can you please >> include this in commit log, plus some explanation why crash happens? >> >> Thanks, >> Ferruh > > Hi Ferruh, > > Netvsc slow path needs to handle Tx completion messages (to know when it can reclaim Tx buffers). Tx completion messages are received on Rx queue, which is why the Rx queue is accessed as part of transmit processing. > > An example call stack is: > > #6 rte_spinlock_trylock (sl=0x20) at /include/rte_spinlock.h > #7 hn_process_events (hv=, queue_id=2, tx_limit=) at /drivers/net/netvsc/hn_rxtx.c > #8 hn_xmit_pkts (ptxq=, tx_pkts=, nb_pkts=1) at /drivers/net/netvsc/hn_rxtx.c > > Which leads to the SEGV as 0x20 is not a valid address. > > I'll update the commit messages and resubmit the patch. > > Hi Alan, Thanks for the detail. 'hn_xmit_pkts()' calls 'hn_process_events()' with the Tx queue_id, but 'hn_process_events()' seems designed for Rx event processing since it uses 'queue_id' to get rxq. Does it help to pass queue type to 'hn_process_events()'? And the patch creates Rx queues for access Tx queues. Are the Tx completion packets needs to be delivered to Rx queue with exact same Tx queue_id by design? Or the new Rx queues created just to prevent the crash, by providing 'rxq->ring_lock' etc? Please also check comments on v4, thanks.