From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 3266C2BD3 for ; Thu, 14 Jul 2016 23:59:03 +0200 (CEST) Received: by mail-wm0-f41.google.com with SMTP id f65so4889869wmi.0 for ; Thu, 14 Jul 2016 14:59:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=+gzuReb7Hk+wkW+Cc2+VlqsxmeTgQhilJxc3PSaFAcY=; b=YUvCY56CF8Xr2tX0gx/YgBOCw0mbsOuNxZAuT5NkIV5ydk8jL4JnFE0QgaMPh39jS4 8xS0OrG2y41x6p2fH2pRAM+aWAjHkKxc/bkKGQAKTij4WCLk3wT31QgCF3aNZvSwTrwY VJJbCiLQ//MGZJ9VA86yW0hVK3IMGdESVArIB/sNoTlCET1cNaLbQ2y5Zko0A4QFautx YQ+7ffZDTljPXlvfSZbhxWuMKuXejQZGxQrOdOUY1VrwTaNRbq6Ze1Ch4lmGE3StZ4aa Q1wkN6atz2hKexy6rKBbnfdyYutOhn5NEM0Tj9BKdZQ+DTCiHpiYU2/1LdgN9bowSPy6 8RkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=+gzuReb7Hk+wkW+Cc2+VlqsxmeTgQhilJxc3PSaFAcY=; b=QTttMRTI0fcYAI3V93zbG8prECrHVi7ekQ9rVGMzwbS1mXosgtuMkNJyXL0cN1Nfo9 dEFrgEvp+2To6ZAHpwMUxh87PDIjLCXeru93m07JU5Ot3Iu9ZX4me2ZBZFzTQRnL41/N cgTvhXalQnhUJN0MPcuTU4Z7PuDigSGKWLsmrxVIWus8en7pEUbxwbFmpKNe6sdM9MAQ uyMNwTHzeHfLmi50rBd1AZLNpuHVoQQ+sTv0OL/rMytEy0vxGfooarMaNPOJLu65HGFW Ifrcnh51YP5+9EjbFp/QA6Zzxfza3oOceLui5wPgHLw3GCgh7K2aIm9jtyg0rrmKm/hU 9VNg== X-Gm-Message-State: ALyK8tKEVy+BE6m2SPE0idOQuS02VQjUpTWvrNcBGaAGUJNlOG0kAQYsu/OgP+YxhbxvMXIH X-Received: by 10.28.156.87 with SMTP id f84mr34100503wme.86.1468533542925; Thu, 14 Jul 2016 14:59:02 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id r67sm689986wmb.14.2016.07.14.14.59.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Jul 2016 14:59:01 -0700 (PDT) Date: Thu, 14 Jul 2016 14:59:01 -0700 (PDT) X-Google-Original-Date: Thu, 14 Jul 2016 23:59 +0200 From: Thomas Monjalon To: Keith Wiles Cc: dev@dpdk.org, damarion@cisco.com, viktorin@rehivetech.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, david.marchand@6wind.com Message-ID: <6049792.6bXVORrbVs@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1468531886-34205-1-git-send-email-keith.wiles@intel.com> References: <1468531886-34205-1-git-send-email-keith.wiles@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] spinlock:move constructor function out of header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jul 2016 21:59:03 -0000 Thanks Keith for continuing work. 2016-07-14 14:31, Keith Wiles: > Moving the rte_rtm_init() constructor routine out of the > header file and into a new rte_spinlock.c for all archs/platforms. > Having constructor routines in a header file is not a good > place to keep these types of functions. > > The problem is with linking 3rd party libraries when > an application is not linked directly to dpdk libraries, which > in this case causes a missing symbol in the linking phase. > > Fixes: ba7468997ea6 ("spinlock: add HTM lock elision for x86") > > Originally submitted by Damjan Marion You should keep the original Signed-off and authorship (From: field) with "git am". It is also easier to track when using -v2 --in-reply-to=''. > Signed-off-by: Keith Wiles > --- > lib/librte_eal/bsdapp/eal/Makefile | 1 + > lib/librte_eal/common/arch/arm/rte_spinlock.c | 46 ++++++++++++++++++++++ > lib/librte_eal/common/arch/ppc_64/rte_spinlock.c | 46 ++++++++++++++++++++++ > lib/librte_eal/common/arch/tile/rte_spinlock.c | 46 ++++++++++++++++++++++ > lib/librte_eal/common/arch/x86/rte_spinlock.c | 46 ++++++++++++++++++++++ > .../common/include/arch/x86/rte_spinlock.h | 14 ++----- > lib/librte_eal/linuxapp/eal/Makefile | 1 + I am not sure we should add a .c file for each arch, given it is called only from arch/x86/rte_spinlock.h.