From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0054.outbound.protection.outlook.com [104.47.33.54]) by dpdk.org (Postfix) with ESMTP id 67CDF2BD4 for ; Tue, 30 Aug 2016 06:37:00 +0200 (CEST) Received: from BY2PR03CA043.namprd03.prod.outlook.com (10.141.249.16) by CY1PR0301MB2012.namprd03.prod.outlook.com (10.164.2.18) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.599.9; Tue, 30 Aug 2016 04:36:58 +0000 Received: from BN1BFFO11OLC004.protection.gbl (2a01:111:f400:7c10::1:195) by BY2PR03CA043.outlook.office365.com (2a01:111:e400:2c5d::16) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.599.9 via Frontend Transport; Tue, 30 Aug 2016 04:36:58 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1BFFO11OLC004.mail.protection.outlook.com (10.58.145.15) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.587.6 via Frontend Transport; Tue, 30 Aug 2016 04:36:58 +0000 Received: from [10.232.14.87] ([10.232.14.87]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u7U4ath1018795; Mon, 29 Aug 2016 21:36:56 -0700 To: Ferruh Yigit , References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1472219823-29486-1-git-send-email-shreyansh.jain@nxp.com> <1472219823-29486-10-git-send-email-shreyansh.jain@nxp.com> <57C46EE1.90303@intel.com> CC: , , , From: Shreyansh Jain Message-ID: <60511213-6271-1bfb-24c1-61d7c08971b5@nxp.com> Date: Tue, 30 Aug 2016 10:06:55 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <57C46EE1.90303@intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131170054187011256; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(3190300001)(339900001)(199003)(24454002)(189002)(377454003)(5660300001)(7846002)(31696002)(106466001)(586003)(23746002)(31686004)(11100500001)(64126003)(305945005)(15395725005)(86362001)(105606002)(68736007)(19580405001)(85426001)(50986999)(8936002)(81156014)(54356999)(230700001)(87936001)(8676002)(104016004)(50466002)(81166006)(93886004)(92566002)(65956001)(2906002)(4326007)(83506001)(47776003)(189998001)(76176999)(36756003)(65806001)(19580395003)(33646002)(5001770100001)(65826007)(77096005)(15975445007)(8666005)(626004)(97736004)(4001350100001)(2950100001)(356003)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0301MB2012; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11OLC004; 1:b6b4SsWLy9P/H/lGt3cNl84saVo+gM5fZACwU3JPCMD5vr21eg9wZ+43y+z7l9JeDeYymqo5QiDxakwxyBHCK50GFVRqdRL7Dn2HdDhIZC49Tr4c4FF7kxuegU39HvsfCZAUrvQCWzOq1CNRwMZlKLIyPiYLf+52Cv4021WNyRMq+iwb34PoL08e5Uj9uJ2oFtKxXZxgMpBqNn1cu1E96OvOVTDGmdjHTo1NGPfmEjW7XF85+h1jH0ckKjiS6WAPPASgpm4/ImJilwlSMFy01hFm2gx5TLudzquJQ6YsH4d0feuY0yfY7T2GU7jtNyTbZhSNnZsqPpeVBA4lg8oU6u/sk+vpi9kj7ciOrYnF8Gh3UiGxjQ9ylYbvREDJpfPw3lWs+el9O+styYhoJZ3PgcoE5gHQEC2rsjmRqBTYA88SYpNAP7D5OqWxLj6l1Omz+gfXCia8lY34ZOfpfZGWHvheO1JOg5L7pLhz2rbLW1e/xzvN44lfS9ht8JDT/4AvBJ7OGLvpyB3KQm0pOG5XU7mgMSzAcBDHFRQ3ZFOeEEVbMX1iedQnh7bXHphdncPJHAqibshqQnYr372Ah72PlwHQGNNwhYY7o5Em9LRxgIXbOHGLCSMhsb9EBCLKq1NHcL4XFybxT/xT//GD7Jyl+w== X-MS-Office365-Filtering-Correlation-Id: a50cca20-051e-4aff-eb59-08d3d08f4770 X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB2012; 2:VE+EyQlDiXr6V+De3rjyxN2isVWj76lAfpT9y10zPq3HcvMB3cXIN7xiL6hKN9IWzTLfSqNecHYO699dogZ4/km72YWiwthJlNULNA80B9WKe1XutRRCUpxwK/GPia+byqdJfi4Z2ILE7FxeFoJl6CBpG3JC29BhMQe0c2lhq8h2PTwh9+rW5XiZmi0YIUUR; 3:nhJ/F+KtOe21QJwMpckd/k36uZZfdp8J4YymSHmQTAdKy7SJxav5yn7a0B94oisMqzmRBXck8bVl9gaLqaClU2oGDQ4wgJiM9qK4ZBeeVLnls7hQigpCWxGXSvrtbcMtWLDZuf0tRCGqPBepzauB2U7wEtAOu7/syU4NHIMOvalTOyOOOJwOwBuphA3L1C0lc+jSeClwuoHw7ajYnC5jIXiNeqyypLhmOKJi67O8VMM=; 25:l/N+DcBrnGECI3MCUcpZnvtI3W+1KJJnFBqBTLMhhmCzKWos6PfxakIE/LNK5u2MbfMrLFneo45F8gv/Iyq5CZcIJHGMJskMngZgOhw+qzvwqt+OOwcnXBzSvQC8Yleh2vgbri012OstTEcikOmsVwZCN2mZzDY6AVjMVbSThhLrYPVqzC/yloJ8ELAqi2C6VmadAXwbg3kMdnQ919Q/41y/cf4LVQgaZUt4dYqpkp7+wKZppEWV9jnuPOOWAx4sf+Higj6KMF2BII6/H4g4lNz5X4GcIqa4bJVEut2yBmgGjs8az5xlhMyNR7pKkeva19GIUjCDvgU77KI57H67DxGQ/9sZnSTmV6XeyRSBrK9Vp40qyTFigVRyFTGBntGdIj+Y4kDQndyIzOZL6m/mfo6BZ0cbZIAqqJLGGb9KxJ0= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB2012; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB2012; 31:1JqWl/LBjt+8KSyxexfIzXU2petdiyUNoYmE/c/GTErDh1c3Zpdoo7ywOklxocayiNRKYmZX+XaZJ4gUkNivFN4R39OQ7j4fxjbBhL/JHc8ynmDbtEd6OtQnEqYKDXNXY+ZNHc7oaVL3RM1CXNLUhKndUm6zysA8KUv6GyBmznIaAd+7tGNYqv/GBFDlQKZte4R6qrT0sBEKLY8dIhL5wNZpo06GRn7ovlUMHzOMQmU=; 4:nJpDy4bKlMpKEB89v6Tu/RE6+fpr/31s+GG4qSQW1Iwn1nRmLZcEtSvwuOgIUJkvFP5mhZXlQI1BqzQI5pufuElvRh0oQ+M2XzLUwO0mio6Q9MwWaTOt1myxpmzDIjpMF9lKhwPQEgvwO9R6xHjXWzrMS8dggooajykSifxi3Qv1MY6eVfqhdPFDada3Y2glMg5K2ACbC5xw2qP429tV4O2xU0sf1GBvYq+s5A/80KX2XQfD0ViP8du9iu4RYLKv6uCBz+w3+XL1GB0A7yfCTXhZUnhBDEOB/DnBRZSR2/v6lPPfGG5sMiJApWKNGDbNYaceEtcrO19ctHcFvy8KVfuuiXKP1AXdpgK7OS5l+HZzQz52QhinRaF1I9FewdwFWerdznp4mX8fDcQX/cRgeQxU6iZedT8Er4N9dNMFoxlAARNO6Yq/O571xvHh2/V2MGyPLu1ISaMIsMuj1rKAiwIsxjLWJKonnIhmZK1PXkH5NUPPNLO96S3W61PGfVx6JZOIc3QKAudZTAqmQ3k8AKFjTSPYzjzGEbCvlwIz77k= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(13017025)(13024025)(13018025)(13015025)(13023025)(10201501046)(3002001)(6055026); SRVR:CY1PR0301MB2012; BCL:0; PCL:0; RULEID:(400006); SRVR:CY1PR0301MB2012; X-Forefront-PRVS: 0050CEFE70 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; CY1PR0301MB2012; 23:KeL5IQy8EMpktzQXtPd14v1e/aFoeO89pVq?= =?Windows-1252?Q?O+rTr3DTpu5SfFIR8XrbtbD+t0sDlNwUCDoqgr+qrYqMLI8bmdqk2s05?= =?Windows-1252?Q?Mc9/lEuF1eRFc0OTgZn3cx+sD7SoldyTPVTRG/lVl9oFztBOziSrhOPT?= =?Windows-1252?Q?9J4sx3YsaTKSjVPcud4cZ/KYbkpZF88eAMHibpnG4ZuYDOE+AP+PHwtQ?= =?Windows-1252?Q?/WG7yPJxlErVkEe1wz5ko+ACXOKXA6rwN/84E/k2TObEziK+SOns8312?= =?Windows-1252?Q?bERrgODJ6WiGJgLTMFmIa/NVg8qjFZLtpXZP5RYgo//sgOwU+SgjPg0K?= =?Windows-1252?Q?Aoat6kVqhEvO017j69wqi3TbaaIg1zSm2cMZyuUimnudx4QTWf64gb3E?= =?Windows-1252?Q?uFm6r+4Zb76LFCCKUkhg7ia26b3CcM7RNlBzZuhsZjynvezrslUmK1g7?= =?Windows-1252?Q?s4eu04bInY57b5Zm2r2jseFvWwGnab2LiKzHOc1GiF7Eugtu7XsBS9Pr?= =?Windows-1252?Q?8J/UIK8aFCL5MwnFUBPHJHTHMOQ5LxaAjhCWJqKqH1DuhoXQEPpn1w7g?= =?Windows-1252?Q?2A8bOHT4nKk/c2/oYS+RhaDc/1rzSQBGJ3Qx/hUAqLPwMSXQElD9tuDv?= =?Windows-1252?Q?cuBRlTSOlLokaGzcRF887JVIFxWXOp5VCKzpVOdyKBzojZvZCg12QpZo?= =?Windows-1252?Q?Hvw5Xt+HDdyD79xBCslsBfKWUGu+UAs8eiffr55zT2PzuGLvetH+7lao?= =?Windows-1252?Q?gPidEMQwLnbdJZr7yFfey+o/8fFw3X817aY9JmBJz6vDrWtGRGvXcqZy?= =?Windows-1252?Q?03PFyTczUEBGqJkSZbKkv2ttQXxfA/HK/mqZP+nBfnlKpzBPPfs0ZvT9?= =?Windows-1252?Q?ZbjXPySj2MaLANuIVTeLSmJS0jnHZcYWzr8nmm+ZiBEl/dwAppvaUHcq?= =?Windows-1252?Q?yETDJvbakllTs2g/ekdcMAwOP/9kVKmDtKHs0oMI4tV4UYWH3Ugp2RXp?= =?Windows-1252?Q?4yXIluLHu1OYlvTYIqnX3mj7Ii/nRGJXJU8r6mh+deI9IejCXMXTpD17?= =?Windows-1252?Q?zlhCfYNkbF3R8iyesb+T2bkRpjPlRrtVpd1twMHqDcCVfjIL30yB4bWx?= =?Windows-1252?Q?nHzWYos/MNDdp5SxIjvm69lZ4r1iuwZ6ILiPXSBnBSslCixvs5PuPlGR?= =?Windows-1252?Q?jVYy06yoN/+l+3lGO/hO/G7sKrEJukUL5H6cQ0dISyhKT+iTJUfAY96g?= =?Windows-1252?Q?FXqKULbSzcczkV5czLvpFZTEzHa/OgX7Ny86PwZuZ9mT+XEymPEALQgA?= =?Windows-1252?Q?ljHq6eR8NKTvdYiM6+qB4TTPf37MX+WuwI3ooBzQm8+a8/tGzVX0/++7?= =?Windows-1252?Q?lr92ek63zHM0rvWjCFFJsy2Qi8oUES2rhuxaaqJG0ZqZgQf5j5ZmOl/6?= =?Windows-1252?Q?6A667Rc0noFReJgjO9vMG1PpdezDzH08xiHIgkaLXbavp107CoVsSPSL?= =?Windows-1252?Q?9mP3eyExzZ317kaQXRKNc25RAt0L1wq7qoP+hDt90eNGuGiqnARnHreb?= =?Windows-1252?Q?eDcxEMpmPvcWZtd3hupo3r68k6/2+gc9UUDiW?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB2012; 6:5wsx3ESiyN2JlF8rfQSZObkBNwBlkAUOcfxsZi22OyjWCgCOLAvQmt5w0V2L1NoF94bG3nwzb3OPntmXzMHU5xpC4n4If7mWitNMP8N+cisTtRcY4fYaidWxTlIDaIn11JXuuyzwlHTyHwuGlcTF5SZuqL8PvZOdn7LFy9d99famIN3SLxPVhUzcTwVrasmOgY8qT39liEoNflnuXGWUGs2sr793eN4vT4UiwgAlV5/gM/ZygPljFVQifjU7chHWtI2t5C0eKkp+gFRV+qMWWLcVP24KuOG3ceGbQzNbGn8=; 5:blC1lou3O+0fwuuj9nscTc06iRhguw5py6VEQiu1S/uvBjx2nGBSRj8ml4wx0Z1l/e4/bVIvdFpaxots0CqRt3IDssToOa+SCz/xUoLD53Y5CnD2qFxyKqgr5T9MfLFeED6NBfM2quLSpa5FHLPhJObOP9emrnXa9FCj9pWr8qc=; 24:nYukT6kcJ/u+rFNpjn457lrZ4cNX4bwya1jftzbS82mK6KWm9ARNTmEeWDJad/Neu3Th41Nv9PkZ57U1SCdmyKFJ5tzTeeLrAdfmVHWZXEk=; 7:4j6lf+2Q77/+DNS5d3dfJNpkjL0Bvt6XTCczpF9+Eej296ZUwqzJHf8Rggz5Plx08v5bJ+2uMT/N9ghxmEU5aQE1gn805VYGi9ltcNNpoBUmE4qDjv/K2sCtumC6sLkOOWPGjgkdG02eL+0+aQtpwSEw6/Je0PTsPATHpCtMjpY/Z7vXhpy4tpfsBtHhNJyFC/Oqhq1ish0ALMI6ZCQc5HwLViio8gYKROZZWjBCd4PbDb9lvYR55dSPOCEimmgm SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2016 04:36:58.4515 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB2012 Subject: Re: [dpdk-dev] [PATCH v8 09/25] driver: Remove driver register callbacks for crypto/net X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Aug 2016 04:37:00 -0000 Hi Ferruh, On Monday 29 August 2016 10:50 PM, Ferruh Yigit wrote: > On 8/26/2016 2:56 PM, Shreyansh Jain wrote: >> Now that all pdev are pci drivers, we don't need to register crypto and ethdev >> drivers through a dedicated channel. >> >> Signed-off-by: David Marchand >> Signed-off-by: Shreyansh Jain > > .... > >> -void rte_eth_driver_register(struct eth_driver *eth_drv); > > Function needs to be removed from .map file Actually here I was a little confused. This is part of DPDK_2.2 - an old release. Would removing from an old release break compatibility for any system using the new release but still adhering to older APIs? Also, there is the case of this comment [1] from Neil Horman (and counter argument [2]) about not removing 'rte_cryptodev_pmd_driver_register' from map file because there was no deprecation notice. Overall situation is that I have maintained the previous patch of 'rte_cryptodev_pmd_driver_register' removal but refrained from removing new symbol - waiting for a little more clarification. Is it OK to remove a symbol from an older release without a deprecation notice? Or, should a deprecation notice follow this patch? [1] http://dpdk.org/ml/archives/dev/2016-June/042439.html [2] http://dpdk.org/ml/archives/dev/2016-June/042444.html > >> - >> -/** >> * Convert a numerical speed in Mbps to a bitmap flag that can be used in >> * the bitmap link_speeds of the struct rte_eth_conf >> * >> > > - Shreyansh