From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1EB5AA0525; Fri, 21 Feb 2020 09:19:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4738C1BF9A; Fri, 21 Feb 2020 09:19:39 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 9C31E397D; Fri, 21 Feb 2020 09:19:37 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Feb 2020 00:19:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,467,1574150400"; d="scan'208";a="409068818" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga005.jf.intel.com with ESMTP; 21 Feb 2020 00:19:36 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 21 Feb 2020 00:19:36 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.196]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.158]) with mapi id 14.03.0439.000; Fri, 21 Feb 2020 16:19:11 +0800 From: "Zhu, TaoX" To: Thomas Monjalon CC: "dev@dpdk.org" , "Ananyev, Konstantin" , "Lu, Wenzhuo" , "stable@dpdk.org" , "Ye, Xiaolong" , "Yigit, Ferruh" Thread-Topic: [dpdk-dev] [PATCH v2] net/ixgbe: fix blocking system events Thread-Index: AQHVy5JGY5+SyAIpmkKrmTPirNhe5agcD58AgAL3yACABOKcAIABnTBg Date: Fri, 21 Feb 2020 08:19:10 +0000 Message-ID: <60652C6914E08D41B9AA1580751B3CA9015DB0D6@SHSMSX103.ccr.corp.intel.com> References: <1577328342-216505-1-git-send-email-taox.zhu@intel.com> <20200215154150.GI16933@intel.com> <2b14bca2-f69c-bd29-8e6c-65a174ed609e@intel.com> <5029938.usfYGdeWWP@xps> In-Reply-To: <5029938.usfYGdeWWP@xps> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix blocking system events X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas =20 Thank you for your correction spelling error of 'cancel'. Indeed it is not the best solution by creating a thread. I refer to the sam= e solution with Linux kernel driver. Linux kernel driver manages link statu= s by using a thread. Maybe we can figure out another better solution to fix= this problem but it may take much more time. At this time, 20.02 formal re= lease is coming and this problem affect some basic library.=20 Tks for your understanding. BR, Zhu, Tao > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Thursday, February 20, 2020 11:37 PM > To: Ye, Xiaolong ; Zhu, TaoX ; > Yigit, Ferruh > Cc: dev@dpdk.org; Ananyev, Konstantin ; > Lu, Wenzhuo ; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix blocking system events >=20 > 17/02/2020 14:01, Ferruh Yigit: > > On 2/15/2020 3:41 PM, Ye Xiaolong wrote: > > > On 01/15, taox.zhu@intel.com wrote: > > >> From: Zhu Tao > > >> > > >> IXGBE link status task use rte alarm thread in old implementation. > > > > > > s/use/uses > > > > > >> Sometime ixgbe link status task takes up to 9 seconds. This will > > >> severely affect the rte-alarm-thread-dependent a task in the > > >> system, like interrupt or hotplug event. So replace with a > > > > > > s/a/an > > > > > >> independent thread which has the same thread affinity settings as > > >> rte interrupt. > > >> > > >> Fixes: 0408f47b ("net/ixgbe: fix busy polling while fiber link > > >> update") > > > > > > Should be: > > > > > > Fixes: 0408f47ba4d6 ("net/ixgbe: fix busy polling while fiber link > > > update") > > > > > >> Cc: stable@dpdk.org > > >> > > > > > > Applied to dpdk-next-net-intel with Konstantin's ack, Thanks. > > > > > > > Shared build is failing because of missing pthread library, fixing > > while merging to next-net: >=20 > One more thing looks strange in this patch: > ixgbe_dev_cannel_link_thread > Should it be > ixgbe_dev_cancel_link_thread > ? >=20 > Note: I looked at it because I am not sure multiplying the interrupt thre= ads is > a good idea. > Basically the link status management is too long in this driver. > Instead of fixing the root cause, you move the annoying workload > somewhere else. But it is still there... >=20 > Please could you work on a long term fix? >=20